webrtc/modules/video_coding/codecs/vp9
Ilya Nikolaevskiy 30323e2fb2 VP9 screenshare: fix incorrect assumptions on buffer contents
if higher layer is enabled, then disabled, then key-frame is issued, then
the layer is enabled again, the buffer would contain a picture from before
the key-frame and it might have a higher pid than the currently encoded one.
This would trigger the DCHECK. It's safe to remove the DCHECK completely, because
such occasions would cause unsigned overflow and cause the following check for
maximum allowed picture difference to fail and the wrong picture won't
be used as a temporal reference.

This error only caused failures in debug builds and couldn't lead to corruptions
because there're periodical key-frames generated and pid difference can never become so
big that negative value would overflow to something close to 0.

Bug: webrtc:10257
Change-Id: Ie3b3ed0e24421787e3b40a37987ccecb75d04635
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/151643
Reviewed-by: Sergey Silkin <ssilkin@webrtc.org>
Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29099}
2019-09-06 12:30:16 +00:00
..
include [vp9] Array temporal_up_switch wasn't properly initialized. 2019-08-26 09:17:57 +00:00
test VP9 screenshare: fix incorrect assumptions on buffer contents 2019-09-06 12:30:16 +00:00
DEPS Add VP9 profile negotiation to SDP 2018-07-02 23:38:41 +00:00
svc_config_unittest.cc Format almost everything. 2019-07-08 13:45:15 +00:00
svc_config.cc Reland "Tune vp9 screenshare bitrate and framerate of spatial layers" 2019-03-08 16:00:22 +00:00
svc_config.h Format almost everything. 2019-07-08 13:45:15 +00:00
svc_rate_allocator_unittest.cc Implement stable rate support in SimulcastRateAllocator 2019-09-06 11:17:30 +00:00
svc_rate_allocator.cc Implement stable rate support in SimulcastRateAllocator 2019-09-06 11:17:30 +00:00
svc_rate_allocator.h Add support for stable bitrate target in SvcRateAllocator 2019-09-04 14:22:43 +00:00
vp9_frame_buffer_pool.cc Format almost everything. 2019-07-08 13:45:15 +00:00
vp9_frame_buffer_pool.h Remove rtc_base/scoped_ref_ptr.h. 2019-01-25 20:29:58 +00:00
vp9_impl.cc VP9 screenshare: fix incorrect assumptions on buffer contents 2019-09-06 12:30:16 +00:00
vp9_impl.h Partially revert of ColorSpace information copying around decoders 2019-07-12 11:27:07 +00:00
vp9.cc Reland 2: Add VP9 Profile 2 to default profiles 2018-12-11 23:38:26 +00:00