if higher layer is enabled, then disabled, then key-frame is issued, then the layer is enabled again, the buffer would contain a picture from before the key-frame and it might have a higher pid than the currently encoded one. This would trigger the DCHECK. It's safe to remove the DCHECK completely, because such occasions would cause unsigned overflow and cause the following check for maximum allowed picture difference to fail and the wrong picture won't be used as a temporal reference. This error only caused failures in debug builds and couldn't lead to corruptions because there're periodical key-frames generated and pid difference can never become so big that negative value would overflow to something close to 0. Bug: webrtc:10257 Change-Id: Ie3b3ed0e24421787e3b40a37987ccecb75d04635 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/151643 Reviewed-by: Sergey Silkin <ssilkin@webrtc.org> Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29099} |
||
|---|---|---|
| .. | ||
| h264 | ||
| interface | ||
| multiplex | ||
| test | ||
| vp8 | ||
| vp9 | ||