a7e7130d51
The two-argument Buffer constructor could create uninintialized data. This refactor replaces it with CreateUninitializedWithSizeAndCapacity. It also refactors the CopyOnWriteBuffer class to use explicit functions when creating uninitialized Buffers. Also do some checking to ensure that SetData() always has room enough. Bug: webrtc:42223681 Change-Id: I160c88ca41944c9888d7862e8ce46cd673417a69 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/445040 Auto-Submit: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Harald Alvestrand <hta@webrtc.org> Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/main@{#46890}
88 lines
2.1 KiB
C++
88 lines
2.1 KiB
C++
/*
|
|
* Copyright 2015 The WebRTC Project Authors. All rights reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#include "rtc_base/buffer_queue.h"
|
|
|
|
#include <algorithm>
|
|
#include <cstdint>
|
|
#include <cstring>
|
|
|
|
#include "api/sequence_checker.h"
|
|
#include "rtc_base/buffer.h"
|
|
|
|
namespace webrtc {
|
|
|
|
BufferQueue::BufferQueue(size_t capacity, size_t default_size)
|
|
: capacity_(capacity), default_size_(default_size) {}
|
|
|
|
BufferQueue::~BufferQueue() {
|
|
RTC_DCHECK_RUN_ON(&sequence_checker_);
|
|
for (Buffer* buffer : queue_)
|
|
delete buffer;
|
|
for (Buffer* buffer : free_list_)
|
|
delete buffer;
|
|
}
|
|
|
|
size_t BufferQueue::size() const {
|
|
RTC_DCHECK_RUN_ON(&sequence_checker_);
|
|
return queue_.size();
|
|
}
|
|
|
|
void BufferQueue::Clear() {
|
|
RTC_DCHECK_RUN_ON(&sequence_checker_);
|
|
while (!queue_.empty()) {
|
|
free_list_.push_back(queue_.front());
|
|
queue_.pop_front();
|
|
}
|
|
}
|
|
|
|
bool BufferQueue::ReadFront(void* buffer, size_t bytes, size_t* bytes_read) {
|
|
RTC_DCHECK_RUN_ON(&sequence_checker_);
|
|
if (queue_.empty())
|
|
return false;
|
|
|
|
Buffer* packet = queue_.front();
|
|
queue_.pop_front();
|
|
|
|
bytes = std::min(bytes, packet->size());
|
|
memcpy(buffer, packet->data(), bytes);
|
|
|
|
if (bytes_read)
|
|
*bytes_read = bytes;
|
|
|
|
free_list_.push_back(packet);
|
|
return true;
|
|
}
|
|
|
|
bool BufferQueue::WriteBack(const void* buffer,
|
|
size_t bytes,
|
|
size_t* bytes_written) {
|
|
RTC_DCHECK_RUN_ON(&sequence_checker_);
|
|
if (queue_.size() == capacity_)
|
|
return false;
|
|
|
|
Buffer* packet;
|
|
if (!free_list_.empty()) {
|
|
packet = free_list_.back();
|
|
free_list_.pop_back();
|
|
} else {
|
|
packet = new Buffer(Buffer::CreateWithCapacity(default_size_));
|
|
}
|
|
|
|
packet->SetData(static_cast<const uint8_t*>(buffer), bytes);
|
|
if (bytes_written)
|
|
*bytes_written = bytes;
|
|
|
|
queue_.push_back(packet);
|
|
return true;
|
|
}
|
|
|
|
} // namespace webrtc
|