The two-argument Buffer constructor could create uninintialized data.
This refactor replaces it with CreateUninitializedWithSizeAndCapacity.
It also refactors the CopyOnWriteBuffer class to use explicit functions when creating uninitialized Buffers.
Also do some checking to ensure that SetData() always has room enough.
Bug: webrtc:42223681
Change-Id: I160c88ca41944c9888d7862e8ce46cd673417a69
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/445040
Auto-Submit: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#46890}
Done using
tools/clang/scripts/build_clang_tools_extra.py \
--fetch out/Default clang-tidy clang-apply-replacements
ninja -C out/Default
gn gen out/Default --export-compile-commands
cd out/Default
tools/clang/third_party/llvm/clang-tools-extra/clang-tidy/tool/run-clang-tidy.py -p . \
-clang-tidy-binary out/Default/tools/clang/third_party/llvm/build/bin/clang-tidy \
-clang-apply-replacements-binary \
out/Default/tools/clang/third_party/llvm/build/bin/clang-apply-replacements \
-checks='-*,modernize-deprecated-headers' \
-fix api/ pc/ rtc_base/
followed by
git cl format
and a round of IWYU followed by more git cl format
Bug: webrtc:424706384
Change-Id: I8add6fe713fba9d6ef4cc3783bdb7e7f975aaa0a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/400921
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Philipp Hancke <phancke@meta.com>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#45182}
Also remove test code that can cause leaks into production.
Add sequence checkers.
Bug: webrtc:11988
Change-Id: I67b4cec6ee77d73ccffbbc88c9081ebb3c3cc423
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/185503
Commit-Queue: Tommi <tommi@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32228}
