Signal-iOS/SignalMessaging/utils
Michael Kirk 6f8eddc955 unread indicator uses sortId
- removed timestamp parameter. This wasn't totally obvious, previously we were tracking two pieces of state

1. `unreadIndicator.firstUnseenTimestamp`:
    the first unseen timestamp for a conversation that exists in the database
2. `unreadIndicator.timestamp`:
    the timestamp of the first interaction *after* the unread indicator that fits in the loading window

We don't actually need to track `2` because it was only used in a comparison like:

   viewItem.interaction.timestampForSorting >= unreadIndicator.timestamp

But by definition, unreadIndicator.firstUnseenTimestamp is always less than or
equal to unreadIndicator.timestamp. Put into terms of the `sortId` corallary,
the sortId of the first unseen interaction in the database is always less than
or equal to the sortId of the first unseen interaction that fits in the loading
window.

In other words, there's no situation where

   viewItem.interaction.sortId >= unreadIndicator.firstUnseenSortId
2018-09-26 09:52:34 -06:00
..
Bench.swift benchmark migration 2018-09-26 09:52:34 -06:00
BlockListCache.swift add docs to BlockListCache 2018-09-12 19:16:14 -05:00
BlockListUIUtils.h Use cached group details when rendering blocklist 2018-09-14 10:31:17 -05:00
BlockListUIUtils.m Merge tag '2.29.3.3' 2018-09-15 09:17:08 -05:00
ConversationSearcher.swift sort search results by sortId 2018-09-26 09:52:34 -06:00
ConversationStyle.swift New grayscale palette. 2018-09-20 10:14:20 -04:00
DebugLogger.h Revert "Revert "Merge branch 'charlesmchen/debugLogs' into hotfix/2.20.1"" 2018-03-02 17:44:14 -05:00
DebugLogger.m Apply OWS log functions in Objective-C. 2018-08-27 12:58:52 -04:00
DeviceSleepManager.swift Use swift macros for main thread assert 2018-08-23 10:29:49 -06:00
DisplayableText.swift Unify log tags. 2018-08-15 10:24:29 -04:00
ImageCache.swift Fix tests broken by SAE. 2017-12-06 10:36:12 -05:00
LRUCache.swift Rename fail macros in Swift. 2018-08-27 10:27:48 -04:00
OWSAudioPlayer.h Respect system alert volume for notifications while in app 2018-04-03 16:28:33 -04:00
OWSAudioPlayer.m Step 2/2 %s/OWSAssert/OWSAssertDebug for existing previous assert semantics 2018-09-07 10:00:48 -06:00
OWSAvatarBuilder.h Share a photo from photos app 2017-12-07 10:13:06 -05:00
OWSAvatarBuilder.m Step 2/2 %s/OWSAssert/OWSAssertDebug for existing previous assert semantics 2018-09-07 10:00:48 -06:00
OWSContactAvatarBuilder.h conversation colors 2018-06-29 11:52:41 -06:00
OWSContactAvatarBuilder.m Step 2/2 %s/OWSAssert/OWSAssertDebug for existing previous assert semantics 2018-09-07 10:00:48 -06:00
OWSFormat.h Respond to CR. 2017-12-05 10:44:11 -05:00
OWSFormat.m Respond to CR. 2017-12-05 10:44:11 -05:00
OWSGroupAvatarBuilder.h Use cached group details when rendering blocklist 2018-09-14 10:31:17 -05:00
OWSGroupAvatarBuilder.m Use cached group details when rendering blocklist 2018-09-14 10:31:17 -05:00
OWSMath.h Move seed 2018-08-03 14:26:43 -06:00
OWSPreferences.h CR: clean up preferences 2018-08-08 10:04:59 -06:00
OWSPreferences.m Step 2/2 %s/OWSAssert/OWSAssertDebug for existing previous assert semantics 2018-09-07 10:00:48 -06:00
OWSScreenLock.swift Rename fail macros in Swift. 2018-08-27 10:27:48 -04:00
OWSScrubbingLogFormatter.h Sketch out SAE load screen; make a number of infrastructure changes. 2017-12-01 09:37:52 -05:00
OWSScrubbingLogFormatter.m cherry-pick Merge branch 'charlesmchen/logSdp' 2018-09-04 13:51:31 -06:00
OWSUnreadIndicator.h unread indicator uses sortId 2018-09-26 09:52:34 -06:00
OWSUnreadIndicator.m unread indicator uses sortId 2018-09-26 09:52:34 -06:00
OWSWindowManager.h rename to avoid confusion 2018-07-17 14:49:19 -06:00
OWSWindowManager.m New resolutions for call banner, rename to accommodate multiple X devices. 2018-09-19 11:17:40 -06:00
Searcher.swift Fix tests. 2017-12-07 14:44:38 -05:00
ThreadUtil.h minimize diff senderTimestamp -> timestamp 2018-09-26 09:52:33 -06:00
ThreadUtil.m unread indicator uses sortId 2018-09-26 09:52:34 -06:00
UIImage+OWS.swift Code cleanup per code review 2018-08-22 12:54:22 -06:00
UIUtil.h remove appearance juggling 2018-06-29 16:27:37 -06:00
UIUtil.m Code cleanup per code review 2018-08-22 12:54:22 -06:00
Weak.swift Don't de-activate audio sesion when other audio activities are happening 2018-02-16 14:00:15 -08:00