Signal-iOS/SignalMessaging
Michael Kirk 6f8eddc955 unread indicator uses sortId
- removed timestamp parameter. This wasn't totally obvious, previously we were tracking two pieces of state

1. `unreadIndicator.firstUnseenTimestamp`:
    the first unseen timestamp for a conversation that exists in the database
2. `unreadIndicator.timestamp`:
    the timestamp of the first interaction *after* the unread indicator that fits in the loading window

We don't actually need to track `2` because it was only used in a comparison like:

   viewItem.interaction.timestampForSorting >= unreadIndicator.timestamp

But by definition, unreadIndicator.firstUnseenTimestamp is always less than or
equal to unreadIndicator.timestamp. Put into terms of the `sortId` corallary,
the sortId of the first unseen interaction in the database is always less than
or equal to the sortId of the first unseen interaction that fits in the loading
window.

In other words, there's no situation where

   viewItem.interaction.sortId >= unreadIndicator.firstUnseenSortId
2018-09-26 09:52:34 -06:00
..
attachments Merge remote-tracking branch 'origin/release/2.29.2' 2018-09-07 15:27:50 -04:00
categories Tweak gray 95. 2018-09-20 10:15:09 -04:00
contacts Rework creation of singletons. 2018-09-19 15:11:26 -04:00
environment benchmark migration 2018-09-26 09:52:34 -06:00
Libraries/JSQMessagesViewController Use StoreKit for reviews 2018-08-07 15:56:52 -06:00
Models minimize diff senderTimestamp -> timestamp 2018-09-26 09:52:33 -06:00
profiles minimize diff senderTimestamp -> timestamp 2018-09-26 09:52:33 -06:00
utils unread indicator uses sortId 2018-09-26 09:52:34 -06:00
viewControllers Clean up ahead of PR. 2017-12-05 11:32:19 -05:00
ViewControllers Move more singletons to SSKEnvironment. 2018-09-21 09:06:48 -04:00
ViewModels replace thread.lastMessageDate/archivalDate -> thread.lastSortId, thread.archivedAsOfSortId 2018-09-26 09:52:34 -06:00
Views Merge tag '2.29.3.3' 2018-09-15 09:17:08 -05:00
Info.plist Shared framework between app and extension 2017-11-29 13:58:27 -08:00
SignalMessaging-Prefix.pch Update assertions. 2018-09-14 14:30:06 -04:00
SignalMessaging.h Remove legacy Error backdating - no changes in functionality 2018-09-26 09:52:33 -06:00