Commit Graph

11289 Commits

Author SHA1 Message Date
Michael Kirk
f8244eeefe Fix SAE crash for iOS9 2019-03-26 17:08:36 -06:00
Michael Kirk
840c811b95 Merge branch 'mkirk/ios9-deprecation' 2019-03-26 17:07:35 -06:00
Michael Kirk
58d99a480f Notify iOS9 users occasionally that iOS10 will soon be required 2019-03-26 11:21:30 -06:00
Matthew Chen
53299c139f Merge branch 'charlesmchen/cdsFeedbackErrors' 2019-03-25 15:58:42 -04:00
Matthew Chen
9b34e4ac61 Respond to CR. 2019-03-25 15:58:27 -04:00
Matthew Chen
c5a87c4d20 Add asserts around CDS feedback errors. 2019-03-25 15:58:27 -04:00
Michael Kirk
5cc6fc0632 Merge branch 'mkirk/ri_checks' 2019-03-25 08:55:42 -07:00
Michael Kirk
62ce0339a5 Update tags to ignore, introduce scheme for ignoring internal tags 2019-03-25 08:55:24 -07:00
Matthew Chen
c3ddb4b912 Merge branch 'charlesmchen/accessibilityIdentifiers3' 2019-03-25 09:33:58 -04:00
Matthew Chen
3ce3f9faaa Add accessibilityIdentifiers to conversation settings view. 2019-03-25 09:31:55 -04:00
Matthew Chen
f073dd9a52 Add accessibilityIdentifiers to conversation settings view. 2019-03-25 09:31:55 -04:00
Matthew Chen
d253c5aa91 Add accessibilityIdentifiers to conversation view. 2019-03-25 09:31:19 -04:00
Matthew Chen
50888b20d2 Add accessibilityIdentifiers to 'new group thread' view. 2019-03-25 09:31:19 -04:00
Matthew Chen
4188993fc5 Add accessibilityIdentifiers to 'new contact thread' view. 2019-03-25 09:31:19 -04:00
Matthew Chen
95e125d55e Simplify usage of accessibilityIdentifiers. 2019-03-25 09:31:19 -04:00
Matthew Chen
2d854406a1 Add accessibilityIdentifiers to home view. 2019-03-25 09:31:19 -04:00
Michael Kirk
2464fe230d sync translations 2019-03-22 18:35:51 -07:00
Michael Kirk
0e6647626d Merge branch 'mkirk/search-icon' 2019-03-22 18:21:08 -07:00
Michael Kirk
ed6b461662 search icon 2019-03-22 18:18:56 -07:00
Michael Kirk
c37fb42c7a "Bump build to 2.38.0.7." 2019-03-22 17:38:53 -07:00
Michael Kirk
753a60fe66 Merge branch 'charlesmchen/conversationViewIsDisappearing' 2019-03-22 17:38:32 -07:00
Matthew Chen
a6e00c8fec Respond to CR. 2019-03-22 16:53:55 -04:00
Matthew Chen
a7ae79aaad Ignore keyboard notifications while the view is disappearing or has disappeared. 2019-03-22 10:26:25 -04:00
Matthew Chen
8c345d0878 "Bump build to 2.38.0.6." 2019-03-21 16:41:51 -04:00
Matthew Chen
9cb137598a Merge branch 'charlesmchen/callsFromPhoneapp' 2019-03-21 15:22:52 -04:00
Matthew Chen
85d58d3396 Improve handling of call intents. 2019-03-21 15:22:47 -04:00
Matthew Chen
76ac745f8b Merge branch 'charlesmchen/imageEditorFixes3' 2019-03-21 15:22:10 -04:00
Matthew Chen
558b5f5816 Tap to dismiss caption editor. 2019-03-21 15:21:36 -04:00
Matthew Chen
4ea608cd45 Ensure status bar is hidden in image editor subviews. 2019-03-21 15:21:36 -04:00
Michael Kirk
607adbf261 Merge branch 'mkirk/search-qa' 2019-03-21 12:04:49 -07:00
Michael Kirk
e3cc8bb101 Keep results bar visible when dismissing keyboard or returning to view. 2019-03-21 12:04:37 -07:00
Michael Kirk
2c72775815 Merge branch 'mkirk/keyboard-dismiss-bug2' 2019-03-21 10:37:59 -07:00
Michael Kirk
3850ca29b0 Bigger hack to fix problem with lesser hack.
There were two symptoms to this bad "leave app while dismissing keyboard"
state...

The first, most noticeable symptom was that the main window no longer respected
the device orientation. This was caused by UIKit temporarily disabling
autorotate during an interactive keyboard dismissal, and not cleaning up after
itself when we hid the window mid dismissal due to our screen protection
feature. This was solved previously in: ca0a555f8

The second symptom remained, and is solved by this commit. Wherein after
getting in this bad state, the interactive keyboard dismiss function behaves
oddly. Normally when interactively dismissing the keyboard in a scroll view,
the keyboard top follows your finger, until you lift up your finger, at which
point, depending on how close you are to the bottom, the keyboard should
completely dismiss, or cancel and return to its fully popped position. In the
degraded state, the keyboard would follow your finger, but when you lifted your
finger, it would stay where your finger left it, it would not complete/cancel
the dismiss.

The solution is, instead of only re-enabling autorotate, to use a higher level
private method which is called upon complete/cancellation of the interactive
dismissal. The method, `UIScrollToDismissSupport#finishScrollViewTransition`,
as well as re-enabling autorotate, does some other work to restore the UI to
it's normal post interactive-keyboard-dismiss gesture state.

For posterity here's the decompiled pseudocode:

```
/* @class UIScrollToDismissSupport */
-(void)finishScrollViewTransition {
    *(int8_t *)&self->_scrollViewTransitionFinishing = 0x0;
    [self->_controller setInterfaceAutorotationDisabled:0x0];
    [self hideScrollViewHorizontalScrollIndicator:0x0];
    ebx = *ivar_offset(_scrollViewNotificationInfo);
    [*(self + ebx) release];
    *(self + ebx) = 0x0;
    esi = *ivar_offset(_scrollViewForTransition);
    [*(self + esi) release];
    *(self + esi) = 0x0;
    return;
}
```
2019-03-21 10:37:54 -07:00
Matthew Chen
a4c4ac9be4 Merge branch 'charlesmchen/callkitLocale' 2019-03-21 11:16:38 -04:00
Matthew Chen
1b9eb3c572 Ensure Callkit is enabled for locale. 2019-03-21 11:16:11 -04:00
Matthew Chen
6a82dd2ba7 Merge branch 'charlesmchen/accessibilityIdentifiers2' 2019-03-21 11:12:16 -04:00
Matthew Chen
40c9c196aa Fix memory leaks. 2019-03-21 11:12:04 -04:00
Matthew Chen
908fe1d0c9 Apply presentAlert() throughout codebase. 2019-03-21 10:58:49 -04:00
Matthew Chen
882dd16d7c Apply presentAlert() throughout codebase. 2019-03-21 10:55:04 -04:00
Matthew Chen
c9d62f47cc Respond to CR. 2019-03-21 10:26:38 -04:00
Matthew Chen
1a80f0c293 Add accessibility identifiers to privacy popups and subviews. 2019-03-21 10:08:57 -04:00
Matthew Chen
cb5ce42e76 Add accessibility identifiers to privacy popups and subviews. 2019-03-21 10:08:25 -04:00
Matthew Chen
f37a3059fa Add accessibility identifiers to debug log popups. 2019-03-21 10:08:25 -04:00
Matthew Chen
81508e9d02 Add accessibility identifiers to settings popups. 2019-03-21 10:08:25 -04:00
Matthew Chen
d7b1e65a71 Add accessibility identifiers to blocklist popups. 2019-03-21 10:08:25 -04:00
Matthew Chen
f1520d760e Add accessibility identifiers to other settings views. 2019-03-21 10:08:25 -04:00
Matthew Chen
b48e204b90 Add accessibility identifiers to notification settings views. 2019-03-21 10:08:25 -04:00
Matthew Chen
02340864f8 Add accessibility identifiers to blocklist view. 2019-03-21 10:08:25 -04:00
Matthew Chen
f7d86028da Add accessibility identifiers to profile view. 2019-03-21 10:08:25 -04:00
Matthew Chen
c619f815b5 Add accessibility identifiers to app settings view. 2019-03-21 10:08:25 -04:00