signalapp/Signal-iOS
signalapp/Signal-iOS
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases 4 Wiki Activity
21,812 Commits 1 Branch 2,246 Tags 1.8 GiB
f483ee2cac
Commit Graph

2517 Commits

Author SHA1 Message Date
Michelle Linington
f483ee2cac Fixes some name collision bugs 
- Fixes up content alignment issues from parallel changes to table view
  styling.
- Re-adds view controller presentation within a nav controller (stemming
  from parallel changes to table view styling)
- Fixes a bug around overzealous collision detection

Also fixes an unrelated issue. Setting up cv banners performs layout, which
can cause the conversation view controller's trait collection to change.
This can lead to us reenterantly setting up banners and updating trait
collection.

The workaround is to just call -ensureBannerState asynchronously from
-traitCollectionDidChange to break the synchronous chain.
 2021-03-17 01:14:25 -07:00
Nora Trapp
a19737c0bb Tweak selection animations to be slide in / out 2021-03-16 19:48:59 -03:00
Nora Trapp
53d49f71b6 Block loads while animating selection change 2021-03-16 19:48:59 -03:00
Nora Trapp
70f6e62877 Animate quoted replies 2021-03-16 19:48:59 -03:00
Nora Trapp
39c851218d Animate multi-select UI appearance/disappearance 2021-03-16 19:48:59 -03:00
Nora Trapp
1f7a592166 Animate message send and receive. 2021-03-16 19:48:59 -03:00
Jordan Rose
76b716462e SSK: Make OrderedDictionary a struct and improve it a bit 
- Now a struct, meaning no need for a clone() method
- Now a RandomAccessCollection indexed by Int
- Removed the subscript setter that EarlyMessageManager was using to
  make the reordering behavior more explicit
- Generalized insert(key:value:isAppend:) to insert(key:at:value:)
- Added removeSubrange(_:)
 2021-03-04 10:30:54 -08:00
Nora Trapp
0cefe0abe6 Resolve merge conflicts 2021-03-03 20:49:07 -08:00
Nora Trapp
5f1435113e Re-style privacy settings, group creation, compose, and other miscellany 2021-03-03 20:32:36 -08:00
Michelle Linington
10533102d6 Additional PR Feedback 
- Remove some test-only code
- Since we're prewarming our collision finder off the main thread, the
  ready flag should be made thread-safe.
 2021-03-03 12:51:07 -08:00
Michelle Linington
adabc1a06e PR Feedback 
The most significant change here is we defer initial loading of
collision interactions. We shouldn't block the main thread during
conversation presentation.

Instead, we'll perform it at UserInitiatedQoS. Once complete, we'll call
-ensureBannerState. Subsequent banner state updates will use the cached
interactions to find name collisions.
 2021-03-03 12:51:07 -08:00
Michelle Linington
4bb70840b9 Improve sorting of collisions 2021-03-03 12:51:07 -08:00
Michelle Linington
15eb64086c Most of the work for profile spoofing in group membership 
This separates the logic for finding spoofed profiles from the view
controller responsible for reporting collisions to the user
 2021-03-03 12:51:07 -08:00
Matthew Chen
d325b57bff Respond to CR. 2021-02-24 21:13:25 -03:00
Matthew Chen
33583050bd Batch processing of synced contacts. 2021-02-24 21:13:25 -03:00
Matthew Chen
590e03e124 Improve robustness of sticker handling. 2021-02-18 09:20:03 -03:00
Matthew Chen
98400a71b4 Improve robustness of sticker handling. 2021-02-18 09:20:03 -03:00
Jordan Rose
493e99eb8d Don't expose a CVComponentView to the CVComponentDelegate 
Instead of the delegate showing the share sheet for a tapped-on
attachment, let the CVComponentGenericAttachment do it itself. This
keeps the delegate from dealing with any specific component views
within the conversation.
 2021-02-17 11:43:22 -08:00
Matthew Chen
e01ae3e3c2 Respond to CR. 2021-02-15 13:49:16 -03:00
Matthew Chen
a2d6288a3b Improve hiding of banners. 2021-02-15 13:41:49 -03:00
Matthew Chen
461c846651 Improve hiding of banners. 2021-02-15 13:41:49 -03:00
Matthew Chen
11afd26f0a Add new table view controller with new style. 2021-02-12 17:30:30 -03:00
Nora Trapp
2202bf9700 Disable Apple's "Quick Look" feature on iOS versions that they no longer support. 2021-02-05 11:46:57 -08:00
Matthew Chen
2b6c28d953 Respond to CR. 2021-02-05 15:27:17 -03:00
Matthew Chen
c3e6235150 Elaborate date/time info in VoiceOver labels. 2021-02-05 15:13:36 -03:00
Matthew Chen
e359de0aad Merge branch 'release/5.3.3' 2021-02-04 10:57:26 -03:00
Matthew Chen
08f31a55e4 Hide link previews if there is a pending message request. 2021-02-04 10:49:45 -03:00
Matthew Chen
e8c23e78fe Do not linkify message bodies if there is a pending message request. 2021-02-04 10:49:45 -03:00
Matthew Chen
3a98384275 Do not linkify message bodies if there is a pending message request. 2021-02-04 10:49:45 -03:00
Matthew Chen
8366f01948 Respond to CR. 2021-02-03 09:54:49 -03:00
Matthew Chen
55f339e209 Hide attachment progress indicators if message send has failed. 2021-02-03 09:47:52 -03:00
Matthew Chen
549cbbc784 Hide attachment progress indicators if message send has failed. 2021-02-03 09:47:51 -03:00
Matthew Chen
b636d29ead Add logging around 413 errors. 2021-02-03 09:42:59 -03:00
Matthew Chen
cf1d24b60a Only offer to re-add dropped group members that are known to be re-addable. 2021-02-03 09:39:58 -03:00
Matthew Chen
6c6ae0014d Add voice memo duration to VoiceOver description. 2021-02-02 17:55:13 -03:00
Matthew Chen
138686d2d7 Fix accessibility in chat history items. 2021-01-29 16:43:02 -03:00
Matthew Chen
9c961b98b2 Fix accessibility in chat history items. 2021-01-29 16:43:02 -03:00
Matthew Chen
bec6d3cd09 Fix accessibility in chat history items. 2021-01-28 19:17:21 -03:00
Matthew Chen
cb358fd98b Fix accessibility in chat history items. 2021-01-28 19:17:21 -03:00
Matthew Chen
79c5cf0481 Adjust attachment progress style and layout. 2021-01-28 11:33:02 -03:00
Matthew Chen
f390b779d0 Adjust attachment progress style and layout. 2021-01-28 11:33:02 -03:00
Matthew Chen
49df8d2515 Fix issue around sharing a sticker pack URL to just the currently open conversation. 2021-01-28 11:32:13 -03:00
Nora Trapp
bd2e2a0b50 Fix system message cell measurement 2021-01-27 11:27:36 -08:00
Matthew Chen
a260a91c69 Fix cell layout edge cases around long sender names. 2021-01-25 15:14:12 -08:00
Matthew Chen
086ebf841a Never display outgoing attachment progress for attachments from linked device. 2021-01-25 15:13:33 -08:00
Matthew Chen
bb87613726 Render enter profile bio. 2021-01-25 15:13:03 -08:00
Nora Trapp
ddc0aca072 Fix stickers sent from linked devices 2021-01-23 22:06:52 -08:00
Nora Trapp
43c29c300b Fix issue where sticker suggestions linger after sending attachment 2021-01-23 15:42:56 -08:00
Nora Trapp
06f2657cac Improve sticker horizontal list view reuse 2021-01-23 15:33:48 -08:00
Matthew Chen
a5cd51f4a4 Fix progress indicators for stickers. 2021-01-23 11:30:19 -08:00