signalapp/Signal-iOS
signalapp/Signal-iOS
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases 4 Wiki Activity

Fix accessibility in chat history items.

Browse Source
This commit is contained in:
Matthew Chen 2021-01-27 11:27:18 -03:00
parent cb358fd98b
commit bec6d3cd09
2 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
Signal/src/ViewControllers/ConversationView/CV/CVComponent.swift
View File

@ -230,7 +230,8 @@ extension CVComponentBase: CVNode {
var isTextOnlyMessage: Bool { messageCellType == .textOnlyMessage }
func accessibilityLabel(description descriptionParam: String?) -> String {
func accessibilityLabel(description descriptionParam: String?,
ignoreMissingSenderName: Bool = false) -> String {
let description = { () -> String in
if let description = descriptionParam,
!description.isEmpty {
@ -241,6 +242,8 @@ extension CVComponentBase: CVNode {
if let authorName = itemViewState.accessibilityAuthorName,
!authorName.isEmpty {
return "\(authorName) \(description)"
} else if ignoreMissingSenderName {
return description
} else {
owsFailDebug("Missing sender name.")
return description

3
Signal/src/ViewControllers/ConversationView/CV/CVComponents/CVComponentSystemMessage.swift
View File

@ -99,7 +99,8 @@ public class CVComponentSystemMessage: CVComponentBase, CVRootComponent {
selectionView.isHiddenInStackView = !isShowingSelectionUI
titleLabelConfig.applyForRendering(label: titleLabel)
titleLabel.accessibilityLabel = accessibilityLabel(description: titleLabelConfig.stringValue)
titleLabel.accessibilityLabel = accessibilityLabel(description: titleLabelConfig.stringValue,
ignoreMissingSenderName: true)
let isReusing = componentView.rootView.superview != nil
if !isReusing {