This can get called asynchronously during tests, and that can lead to
flakiness if we’re between two tests. There doesn’t seem to be a
compelling reason to only distinguish critical errors from warnings in
the NSE, so distinguish the two types everywhere.
I made a mistake in 11c2cf0813 and
accidentally included an unreferenced child in
`SignalServiceKitTests/Storage/`. This was likely due to a merge/rebase
error on my part.
It caused this warning when installing dependencies:
> `<PBXGroup name=`Storage` path=`SignalServiceKit/tests/Storage`
> UUID=`F94261D7289B1B5400460798`>` attempted to initialize an object
> with an unknown UUID. `F97217FC28DCBC4100113D9F` for attribute:
> `children`. This can be the result of a merge and the unknown UUID is
> being discarded.
This fixes that!
_This change should have no user impact._
This flag had a condition that would always evaluate to `false`. This PR
fixes that, and adds a comment about why it's a little verbose.
For certain kinds of notifications, we attach "intents" to let the
system know who's contacting us (for use in, say, share sheet
suggestions; controlled by Settings > Chats > Share Contacts with
iOS). Previously we only provided "rich" intents on iOS 15 and a
minimal implementation for iOS 13, but even if iOS 13 won't do as much
with the information we can be more consistent.
_This change should have no user impact._
The database corruption flag lives on `UserDefaults`. Currently, this
flag is controlled through `SSKPreferences`, but I kinda think that's
the wrong place—database corruption isn't really a user preference.
This moves it into its own file, tests it, and [drops booleans in favor
of an enum][0]. I think this is useful on its own, but also prepares us
for an upcoming change.
[0]: https://www.luu.io/posts/dont-use-booleans
- Use Xcode 14 for all of our jobs. If something like `genstrings`
changes, this should keep that job consistent with everything else.
- Use macos-12 for all of our jobs. It’s probably best to keep things
consistent, and macos-11 will eventually go away.
