This updates our libPhoneNumber dependency. See [the libPhoneNumber-iOS
commit][0].
According to [the upstream libphonenumber release notes][1], they
updated the formatting for +49 numbers. That caused a test to break, so
I updated it (and tested a few additional dialing codes).
[0]: 8b6f552682
[1]: 90503ecef3/release_notes.txt (L21)
Allow to set just the gradient colors, without locations, relying on CAGradientLayer's
uniform color distribution logic.
Also update all the uses of GradientView to only specify colors because all the
places were using just two locations: 0 and 1.
* make StoryMessage author an enum and handle at all usage sites
* add system story case to story context; don't show replies for system stories
* [tentative] add system avatar image
* clean up context creation and other odds and ends
* fix merge conflicts
* pre-PR cleanup
* add avatar asset TODO
* pr comments
* remove StoryAuthor enum, pass around author UUID instead with extension for checking if it is the signal system author uuid
* pr comments
- Revert "More flexible selection styling in CVTextLabel"
(commit e1317d814c)
- Revert "Show the MemberActionSheet for tapped names in group system messages"
(commit 48bc3c07d0)
This dismisses the keyboard before you send a gift badge. I think this
is slightly better UX, but it also fixes a bug where the chat header
would be untappable after sending a gift badge.
As of 86b8eb08b8, the database initialization no longer has
asychronous components. The current code returns an already-resolved
promise in all situations, so remove the asynchronous infra entirely.
I added these tests in da322d3bf9, but we
decided that they're not worth it.
Also, it seems I forgot to add them to the project! So they were never
run anyway, outside of the times I ran them while developing.
_I recommend reviewing this with whitespace changes disabled._
This hides the "Approve New Members" section if the group link is
disabled, as it doesn't really make sense to include it.
See [#5319][0].
[0]: https://github.com/signalapp/Signal-iOS/pull/5319
* Split OWSSignalService into a swift protocol and implementation, migrated from objc
* Put OWSSignalService under SSKEnvironment and use mock in mock environment
* Rename from basename + impl to protocol + basename
* extend mock functionality a bit
* pr feedback
This view controller expects to be passed an instance that already
exists. The instanced created on this line is therefore created but
never read. Avoid creating it to save some CPU cycles.
...so it can be constrained to not overlap the call header or call
controls when in larger font sizes. Additionally, the new view uses a
smaller font, and a horizontal layout for the icon + label when on
small screens.
With more information on the group call lobby screen, it doesn't make
sense to have the entire camera feed replaced with a "Call is Full"
message. Instead, disable the Join button as before, and show a toast
if the user taps on it anyway.
Title: name of the group, unless someone is presenting
Status, when in a call:
- "Reconnecting",
- "Ringing Ahmed, Bianca, and N others",
- "No one else is here", or
- (call timer)
Status, before joining the call:
- "Akiko, Bharat, and N others are in the call",
- "Signal will ring Alex, Blue, and N others", or
- "Amy, Brian, and N others will be notified"
This allows hiding the members button when there is no one in the
call. It will also be useful for the redesigned lobby screen where the
info is in the middle of the screen instead of at the top.
While this text should still be kept terse, larger font sizes or other
languages can still end up wanting more horizontal space. The vertical
size is fixed so it doesn't mess up the layout, though.
This fixes a bug that was [reported on the forums][0]. If you:
1. Open a chat.
2. Quote a message.
3. Go back to the chat list.
4. Open that chat again.
Previously, the sticker button would be shown. This is because the
`quotedReply` member wouldn't be set yet. This fixes that by
initializing `quotedReply` with the `ConversationInputToolbar`.
[0]: https://community.signalusers.org/t/beta-feedback-for-the-upcoming-ios-5-50-release/46594/4
