On iOS 16, the nav bar itself is transparent, so the container view
controller’s background is visible. The color of that view wasn’t being
updated, which resulted in the nav bar appearing the wrong color.
A few view controllers worked around this by manually updating just the
background color to the same value used by the table view. It seems
cleaner to re-apply the overall styling when the theme changes.
* remove unecessary owsFailDebug
* fix context menu icon positioning
* fix layout of custom context menus near the left side of the screen in RTL languages
* UX tweaks for my story cell
* status
* apply theme changes to tab bar that happened while it was hidden
* pr feedback 1
* pr feedback 2
This reverts commits 41b381b1b1 and
856ced4062.
'supportedInterfaceOrientations' doesn't behave correctly in certain
scenarios, including when the app is *launched* in landscape.
There were some redundant checks as a result of the duplication between
the validation and lookup methods. Shift more of the logic into the
shared method to avoid repeating the same thing multiple times.
Also, return a single item rather than an `Array`. We only expect a
single result, so there’s no need to pass around an `Array.`
_This change should have no user impact._
In addition to recommended amounts, users can donate custom amounts when
making a one-time donation.
Previously, this was called `CustomValueTextField` and lived in
`BoostViewController.swift`. Now it's in its own file (which I think
makes more sense) and is called `OneTimeDonationCustomAmountTextField`.
This was a very quick change. I didn't change the class beyond updating
its name.
I think this is useful on its own, but it'll be nice in an upcoming
change.
* Fix faulty logic in validation of a URL parsed from string.
`OWSLinkPreview.isPermittedLinkPreviewUrl(parsedFrom:)` has logic to extract
hostname from a string that matches a detected URL. The logic was assuming that
every string begins with a scheme prefix (eg "http://"). That assumption isn't
always correct because NSDataDetector uses HTTP scheme when scheme prefix is not
present (eg "google.com" would result in "http://google.com" being detected).
* Two improvements to "attach link" UX.
• any valid HTTPS url can be attached to a text story, even if the link wouldn't
actually work.
• show progress indicator while fetching a link preview.
* Add "https://" to address in "attach link preview" UI if necessary.
* Use read timestamp in story badge count
* Add StoryBadgeCountManager
* Manager stories tab bar badge count in StoryBadgeCountManager
* Don't mark stories read while the app is backgrounded. Mark them read when foregrounding and on the tab bar
* Only mark the latest story per context as read
* fix tests
* apply theme to cells when conversation picker theme changes
* Retain selection UI when reloading conversation picker cells
* Prioritize newly created story threads for conversation picker sort ordering
* Index private story threads for searching
* Add story search results to conversation picker and fix issues with reloading with stuff pre-selected
* PR feedback 1: efficient thread migration
* PR feedback 2: don't allow expansion of story search results
This view controller is only created for gv2 threads, so we can assume
every thread is a gv2 thread.
In `ConversationSettingsViewController.showAddMembersView()`, we call
`canEditConversationMembership`, which checks a number of things, one of
which is `!isBlockedByMigration`; a thread is blocked by migration if
`isGroupV1Thread` returns true.
* Add readOnboardingStory to AccountRecord
* Add onboarding story read state to SystemStoryManager
* Sync onboarding story read state with storage service
* fix incorrect delete of unviewed system stories
* Add last read timestamp to StoryContextAssociatedData
* Write lastReadTimestamp on StoryContextAssociatedData
* Copy lastViewedTimestamp over to lastReadTimestamp to simplify badge query
* apply didSets for data that changed at rest
* Add read timestamp to incoming story manifest
* send story message read syncs to linked devices
* Process incoming story message read syncs from linked devices
This change should have no user impact.
We use `NSDecimalNumber` and `Decimal`. This tries to standardize on
`Decimal` where possible (though the former is still needed in a few
places).
Mostly a mechanical change, though a few little things changed.
