Commit Graph

2733 Commits

Author SHA1 Message Date
Michael Kirk
46ddaa9cae fix: unregistered user shows "add to contacts"
// FREEBIE
2017-07-19 09:44:33 -04:00
Michael Kirk
e039363873 Merge branch 'mkirk/remove-verification-debug-ui' 2017-07-19 09:43:42 -04:00
Michael Kirk
17b1b70726 Remove verification debug UI
There is a more true-to-life way to set verification state - mark
someone as verified or default via the SN UI.

If they are marked as verified, you can mark them as no-longer-verified
by toggling a keychange in the debug UI

// FREEBIE
2017-07-19 09:43:30 -04:00
Michael Kirk
8066c192b4 Merge branch 'mkirk/mapping-asserts' 2017-07-19 09:42:24 -04:00
Michael Kirk
df0cf76603 Assert that mapping is set whenever accessing
// FREEBIE
2017-07-19 09:42:14 -04:00
Michael Kirk
7adf5e81f7 Merge branch 'mkirk/add-to-existing-requires-contacts' 2017-07-19 09:41:48 -04:00
Michael Kirk
1c9ce5eaf3 CR: Don't just build, but present, alert controller
// FREEBIE
2017-07-19 09:39:50 -04:00
Michael Kirk
5c66e5584c Adding to existing contact requires contact access
Previously we'd show an empty "list" of existing contacts.

// FREEBIE
2017-07-19 09:38:48 -04:00
Matthew Chen
5552649553 Merge branch 'charlesmchen/moreOWSTables' 2017-07-19 09:36:53 -04:00
Matthew Chen
8b60765627 Respond to CR.
// FREEBIE
2017-07-19 09:36:43 -04:00
Matthew Chen
81a4ebdaf5 Apply OWSTableViewController to more views.
// FREEBIE
2017-07-19 09:34:55 -04:00
Matthew Chen
dc3f07cb54 Apply OWSTableViewController to more views.
// FREEBIE
2017-07-19 09:34:55 -04:00
Michael Kirk
878806aa52 [JSQMVC] Add Croatian translations
// FREEBIE
2017-07-18 18:22:01 -04:00
Michael Kirk
7c6d900314 sync translations
// FREEBIE
2017-07-18 16:05:07 -04:00
Michael Kirk
33e9f2e62e bump version
// FREEBIE
2017-07-18 16:03:05 -04:00
Michael Kirk
f027d400ba Bump build
// FREEBIE
2017-07-15 19:30:47 -04:00
Michael Kirk
50d6e2ccb4 rebuild WebRTC.framework on oak
// FREEBIE
2017-07-15 19:27:43 -04:00
Michael Kirk
2d23e365cb sync translations
// FREEBIE
2017-07-15 17:25:11 -04:00
Michael Kirk
df79c003f0 Merge branch 'mkirk/fix-audio-route' 2017-07-15 17:11:45 -04:00
Michael Kirk
9287b8560c clean up comments per code review
// FREEBIE
2017-07-15 17:11:41 -04:00
Michael Kirk
fb5c17a6b4 minimize sound overlap
Because there is some asynchrony involved, there may be a blip during
the switch between sounds/audio sessions

// FREEBIE
2017-07-15 17:11:41 -04:00
Michael Kirk
e3faddedbc Disallow bluetooth when user has opted for local receiver
// FREEBIE
2017-07-15 17:11:41 -04:00
Michael Kirk
524ba80b75 WIP: have ensureAudioSession set preferred input
Call it all the time, but only mutate the AVAudioSession when necessary

TODO

Can't switch to iPhone

// FREEBIE
2017-07-15 17:11:41 -04:00
Michael Kirk
220cd345f6 add comments
// FREEBIE
2017-07-15 17:11:41 -04:00
Michael Kirk
ba97ff3f5f Label tweaks for device listing
// FREEBIE
2017-07-15 17:11:41 -04:00
Matthew Chen
be3001e4fa Merge branch 'charlesmchen/emptyHomeView' 2017-07-14 20:46:43 -04:00
Matthew Chen
d36e60b0e9 Respond to CR.
// FREEBIE
2017-07-14 20:46:36 -04:00
Matthew Chen
b6264383d3 Add possible fixes for the ‘empty home view’ issue.
// FREEBIE
2017-07-14 20:46:35 -04:00
Matthew Chen
90dabe1c81 Add possible fixes for the ‘empty home view’ issue.
// FREEBIE
2017-07-14 20:46:35 -04:00
Matthew Chen
f52814bb70 Add possible fixes for the ‘empty home view’ issue.
// FREEBIE
2017-07-14 20:46:35 -04:00
Matthew Chen
3f805cd4cd Add possible fixes for the ‘empty home view’ issue.
// FREEBIE
2017-07-14 20:46:35 -04:00
Matthew Chen
5e58079e13 Update l10n strings.
// FREEBIE
2017-07-14 20:44:44 -04:00
Matthew Chen
5633982262 Bump build from to 2.14.0.3.
// FREEBIE
2017-07-14 09:54:35 -04:00
Michael Kirk
914d2936a3 Merge branch 'mkirk/fix-unnecessary-session-changes' 2017-07-14 09:49:53 -04:00
Michael Kirk
b8ec353d77 Use recommended approach for speakerphone mode
From: https://developer.apple.com/library/content/qa/qa1754/_index.html

Q:  Can you explain the difference between calling the AVAudioSession method overrideOutputAudioPort: with the value AVAudioSessionPortOverrideSpeaker and using the category option AVAudioSessionCategoryOptionDefaultToSpeaker with setCategory:withOptions:error:.

A: The difference is that setting the AVAudioSessionPortOverride by calling overrideOutputAudioPort: is more transient than using the category option AVAudioSessionCategoryOptionDefaultToSpeaker.

Important: The use of both AVAudioSessionPortOverrideSpeaker and AVAudioSessionCategoryOptionDefaultToSpeaker are only applicable to the AVAudioSessionCategoryPlayAndRecord category.
Calling overrideOutputAudioPort: and setting the AVAudioSessionPortOverride to AVAudioSessionPortOverrideSpeaker is a way of temporarily overriding the output to play to the speaker. Any route change or interruption will cause the audio to be routed back to its normal route, following the last-in wins rule. Think of using overrideOutputAudioPort: in terms of what you might use to implement a Speakerphone button where you want to be able to toggle between the speaker (AVAudioSessionPortOverrideSpeaker) and the normal output route (AVAudioSessionPortOverrideNone).

Note: This property is intended to allow 3rd party applications to mimic the behavior of a Speakerphone button and therefore may change the input route as well as output route. For example, setting the AVAudioSessionPortOverride to AVAudioSessionPortOverrideSpeaker while a headset is plugged in will cause the route to change to built-in mic / built-in speaker.

// FREEBIE
2017-07-14 09:49:48 -04:00
Michael Kirk
847a0ff8ba Merge branch 'mkirk/disappear-from-lock-screen' 2017-07-14 09:48:53 -04:00
Michael Kirk
fa42b4a45b Respect disappearing message timer from lockscreen
// FREEBIE
2017-07-14 09:48:46 -04:00
Matthew Chen
235a842137 [SSK] Use existing transaction in cleanup.
// FREEBIE.
2017-07-14 09:27:48 -04:00
Matthew Chen
ab7c1698cf Merge branch 'charlesmchen/anotherCallLeak' 2017-07-14 09:16:47 -04:00
Matthew Chen
6c61e6040c Fix another call view leak.
// FREEBIE
2017-07-13 18:14:26 -04:00
Matthew Chen
90ad83d494 Bump build from to 2.14.0.2.
// FREEBIE
2017-07-13 17:23:28 -04:00
Matthew Chen
8884cb5a2b [SSK] Fix copy and paste of voice messages.
// FREEBIE
2017-07-13 17:23:11 -04:00
Michael Kirk
77fb1dbf45 Merge branch 'mkirk/bt-audio-2' 2017-07-13 17:19:34 -04:00
Michael Kirk
90c2324f99 pixel cleanup in bluetooth speaker image
// FREEBIE
2017-07-13 17:08:42 -04:00
Michael Kirk
b495b23420 more cleanup and commenting
// FREEBIE
2017-07-13 17:08:42 -04:00
Michael Kirk
03f1bbca62 Move state from CallViewController -> Call
I think whenever reasonable we prefer to consodlidate state on the call

// FREEBIE
2017-07-13 17:08:42 -04:00
Michael Kirk
4e11e90ebb cleanup
- remove dead code
- rename vars
- add coments

// FREEBIE
2017-07-13 17:08:41 -04:00
Michael Kirk
a59eb25aef extract dismiss string -> CommonStrings.dismissButton
// FREEBIE
2017-07-13 17:08:41 -04:00
Michael Kirk
20a8e72198 disable audio source images until we have icons
// FREEBIE
2017-07-13 17:08:41 -04:00
Michael Kirk
9bd68ed490 WIP: bluetooth shows audio route button instead of speakerphone
// FREEBIE

TODO

NEED
-[ ] icon in route picker
-[ ] commit cleanup

NICE
-[ ] present action sheet automatically when making outgoing bluetooth call
-[ ] left align icons
-[ ] audio is paused when switching between video mode (maybe existing behavior, not sure)
-[ ] Copy: iPhone/iPad/iPod instead of "iPhone Microphone"

DONE
-[x] remove "receiver" from options while in video mode
-[x] show available audio routes
-[x] select available audio routes
-[x] notification if availabe inputs change so we can update call screen
     mid call with available BT route
-[x] include speakerphone in choices
-[x] Enabled button shows active speakerphone. Should still show
     bluetooth picker.
-[x] toggle back and forth between audio devices
-[x] hide audio route button in video mode if no BT available
-[x] Fixed: When on speakerphone - switching to video mode goes back to bluetooth.
-[x] Fixed: When switching to video w/ bluetooth device connected there is no
     audio picker.
-[x] respect speakerphone/BT selection when in or toggling to/from video
-[x] do not hide audio route button when in video mode and bluetooth
     connected
-[x] Show which is currently selected audio route
-[x] switching to speakerphone no longer works
-[x] switching *back* to bluetooth no longer works
-[x] add proper bluetooth button for audio calls
-[x] add proper bluetooth button for video calls
2017-07-13 17:08:41 -04:00