Commit Graph

5268 Commits

Author SHA1 Message Date
sdkjfhsdkjhfsdlkjhfsdf
46930b9354 Fix crash when viewing non-attachment message details.
// FREEBIE
2017-12-22 22:41:03 -06:00
sdkjfhsdkjhfsdlkjhfsdf
3b17c43e8b Merge branch 'mkirk/fix-profile-flicker' 2017-12-22 13:58:13 -06:00
sdkjfhsdkjhfsdlkjhfsdf
4e6816ec5e Code cleanup
// FREEBIE
2017-12-22 13:55:05 -06:00
sdkjfhsdkjhfsdlkjhfsdf
14723f3e7f Fix profile avatar flicker
- We were clobbering our saved avatar filepath.
- Our "should notify" check was too aggressive.
- Only fetch profiles when entering a conversation.
- Only fetch profiles in main app

Also added (a little) debounce time to debug profile fetching.

// FREEBIE
2017-12-21 19:34:45 -06:00
sdkjfhsdkjhfsdlkjhfsdf
34d2df8d67 Merge branch 'mkirk/attachment-progress' 2017-12-21 10:38:18 -06:00
sdkjfhsdkjhfsdlkjhfsdf
01fa3c89cc CR: cleanup comments, extract callback into method
// FREEBIE
2017-12-21 10:36:42 -06:00
sdkjfhsdkjhfsdlkjhfsdf
b87079d4b4 Sharing attachment shows progress / retry dialog
// FREEBIE
2017-12-20 20:57:17 -06:00
sdkjfhsdkjhfsdlkjhfsdf
37ee9f0e7f Merge branch 'mkirk/attachment-caption' 2017-12-20 16:59:13 -06:00
sdkjfhsdkjhfsdlkjhfsdf
42ea1dfbbe CR: more margin, match button size to default text field, fix layout
when rotated.

There was an issue with captions changing line-count when rotated.

// FREEBIE
2017-12-20 16:58:51 -06:00
sdkjfhsdkjhfsdlkjhfsdf
8141843f27 comment typo 2017-12-20 14:26:53 -06:00
sdkjfhsdkjhfsdlkjhfsdf
7907a64dfe move gradient up with keyboard
// FREEBIE
2017-12-20 14:26:53 -06:00
sdkjfhsdkjhfsdlkjhfsdf
653a272b54 Don't obscure attachment when keyboard is popped.
// FREEBIE
2017-12-20 14:26:53 -06:00
sdkjfhsdkjhfsdlkjhfsdf
38d94952f7 Shadow for Send button, clean up color accessors
// FREEBIE
2017-12-20 14:26:53 -06:00
sdkjfhsdkjhfsdlkjhfsdf
cfa147831a "Done" button for caption toolbar
// FREEBIE
2017-12-20 14:26:53 -06:00
sdkjfhsdkjhfsdlkjhfsdf
9eb4178c6f style for captioning toolbar
// FREEBIE
2017-12-20 14:26:53 -06:00
sdkjfhsdkjhfsdlkjhfsdf
513e33b0fd Cleanup before code review
// FREEBIE
2017-12-20 14:26:53 -06:00
sdkjfhsdkjhfsdlkjhfsdf
cf091758a5 Fix oversized text messages
// FREEBIE
2017-12-20 14:26:53 -06:00
sdkjfhsdkjhfsdlkjhfsdf
82aeee301d can delete text messages again
// FREEBIE
2017-12-20 14:26:53 -06:00
sdkjfhsdkjhfsdlkjhfsdf
f5b9ae97ef fix insets for incoming vs outgoin
// FREEBIE
2017-12-20 14:26:53 -06:00
sdkjfhsdkjhfsdlkjhfsdf
eeaea5fa01 better match for corner radius
// FREEBIE
2017-12-20 14:26:53 -06:00
sdkjfhsdkjhfsdlkjhfsdf
0ea3a36559 make sure captioned attachment doesn't grow too large
// FREEBIE
2017-12-20 14:26:53 -06:00
sdkjfhsdkjhfsdlkjhfsdf
2c20cb9e7b make sure mediaview isn't too tall in detail view
// FREEBIE
2017-12-20 14:26:53 -06:00
sdkjfhsdkjhfsdlkjhfsdf
411de65b40 TODO: Show caption in details
TODO:
- [ ] layout is shite

// FREEBIE
2017-12-20 14:26:53 -06:00
sdkjfhsdkjhfsdlkjhfsdf
0e9c9a9bb3 Separate gestures for text/vs media
// FREEBIE
2017-12-20 14:26:53 -06:00
sdkjfhsdkjhfsdlkjhfsdf
92477c78b7 cleanup before PR 2017-12-20 14:26:53 -06:00
Michael Kirk
bce18637f0 render attachments with captions
// FREEBIE
2017-12-20 14:26:53 -06:00
Michael Kirk
3176cb5a62 text sizing correctly 2017-12-20 14:26:53 -06:00
Michael Kirk
f8866c4e0b Fix some constraints, get other attachment types looking good
TODO
- [ ] message bubble sizes are not correct. Not always wide enough to
      fit their content.

// FREEBIE
2017-12-20 14:26:53 -06:00
Michael Kirk
76ca52f33c caption bubble properly sized, but all attachments make space now 2017-12-20 14:26:53 -06:00
Michael Kirk
3eb3c268a9 Towards a caption in message
TODO

- [ ] adjust height properly
- [ ] all media types
- [ ] include caption in message details
- [ ] gestures working on both independently
- [ ] perf benchmark

// FREEBIE
2017-12-20 14:26:53 -06:00
Michael Kirk
e20f44024c WIP: Support sending attachment captions
Looks fine on other clients, but locally we don't display the caption.

// FREEBIE
2017-12-20 14:26:53 -06:00
Michael Kirk
0964c16417 cleanup, plus ill fated attempt to offset content beyond keyboard height.
Probably should just pin scrollview above initial toolbar height. I
think it's somewhat convoluted because of the scroll view zoom
functionality that we already use in this view.

// FREEBIE
2017-12-20 14:26:53 -06:00
Michael Kirk
26be69975a cleanup constraint based layout 2017-12-20 14:26:53 -06:00
Michael Kirk
3a078c831d lays out in iOS11, but doesn't resize 2017-12-20 14:26:53 -06:00
Michael Kirk
03e786a145 input toolbar looks good on iOS9/10, but totally broken on 11
// FREEBIE
2017-12-20 14:26:53 -06:00
Michael Kirk
96906440a7 remove height animation, ensure growing text area has content in proper
place.

// FREEBIE
2017-12-20 14:26:53 -06:00
Michael Kirk
562e706ec9 animate height change, but looks goofy 2017-12-20 14:26:53 -06:00
Michael Kirk
a5c5dd3f96 WIP, extract subclass 2017-12-20 14:26:53 -06:00
Michael Kirk
9ee9a0efeb resizing input accessory view.
// FREEBIE
2017-12-20 14:26:52 -06:00
Michael Kirk
f9524b02e2 multiline must be textview, not textfield
// FREEBIE
2017-12-20 14:26:52 -06:00
Michael Kirk
57a5e62db8 WIP - attachment caption 2017-12-20 14:26:52 -06:00
sdkjfhsdkjhfsdlkjhfsdf
76481a86a5 stabalize sort for same-named SignalAccounts
// FREEBIE
2017-12-20 13:49:15 -06:00
Matthew Chen
4e8b836e03 Merge branch 'charlesmchen/sessionDatabase2' 2017-12-20 11:32:57 -05:00
Matthew Chen
05100b1143 Respond to CR. 2017-12-20 11:32:48 -05:00
Matthew Chen
6b0e3508a5 Respond to CR. 2017-12-20 11:28:07 -05:00
Matthew Chen
245304116f Respond to CR. 2017-12-20 11:19:09 -05:00
Matthew Chen
085f8a6f64 Clean up ahead of PR. 2017-12-19 12:02:58 -05:00
Matthew Chen
70926d7f10 Clean up ahead of PR. 2017-12-19 11:50:01 -05:00
Matthew Chen
6b58b4cbde Rework database view registration. 2017-12-19 11:42:06 -05:00
Matthew Chen
fe67cd924c Rework database view registration. 2017-12-19 11:42:06 -05:00