signalapp/Signal-iOS
signalapp/Signal-iOS
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases 4 Wiki Activity
2,681 Commits 1 Branch 2,246 Tags 1.8 GiB
3527df7ba0
Commit Graph

2681 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Matthew Chen
3527df7ba0 Merge branch 'charlesmchen/leakCallView' 2017-07-12 19:29:12 -04:00
Matthew Chen
ac616d6936 Reject the “call connected” promise immediately when clearing a call. 
// FREEBIE
 2017-07-12 18:12:27 -04:00
Matthew Chen
a58c71f4b8 Fix leak of call view. 
// FREEBIE
 2017-07-12 18:04:49 -04:00
Michael Kirk
55ddce79bf Merge branch 'mkirk/call-connectivity-fixes' 2017-07-12 16:18:56 -04:00
Michael Kirk
d9dfc3d7c7 update fastlane ci 
// FREEBIE
 2017-07-12 16:18:43 -04:00
Michael Kirk
b82aedc3a0 Assertion failures for unexpected promise state 
These don't currently result in failed calls, but we should at least
know about it in debug.

// FREEBIE
 2017-07-12 16:15:22 -04:00
Michael Kirk
438635393b Don't send ICE updates until after the CallOffer has been sent. 
This ensures message ordering for clients that can't handle out of order
call messages (legacy iOS and Android).

Even when we revert the previous commit, to send ICE Updates sooner,
we'll want to keep this (until we're confident all clients can receive
out of order call messages)

// FREEBIE
 2017-07-12 16:15:22 -04:00
Michael Kirk
d910da0157 Partial revert of: Send ICE updates immediately - 2dcfb4e3b8 
That change makes it more likely that the remote client will receive an
ICE update before their peer connection client is set.

We want to ship the robustness fix (waitForPeerConnection in
handleRemoteAddedIceCandidate) before we have the caller start sending
ICE updates immediately, in a future release.

At that time, we can simply revert this commit.

// FREEBIE
 2017-07-12 16:15:22 -04:00
Michael Kirk
3769ce8337 Merge branch 'mkirk/scrub-log-data' 2017-07-12 16:13:49 -04:00
Michael Kirk
2067697ed4 Add comment and clearer tests per CR 
// FREEBIE
 2017-07-12 16:06:35 -04:00
Michael Kirk
4f1ee98489 scrub any data that slips through to logs 
Similar to phone number scrubbing, we leave a short prefix of the data
to help with debugging without leaking much data.

// FREEBIE
 2017-07-12 16:06:35 -04:00
Matthew Chen
86d494becb Merge branch 'charlesmchen/addToExistingContact' 2017-07-12 15:49:46 -04:00
Matthew Chen
b7c2512eac Respond to CR. 
// FREEBIE
 2017-07-12 13:47:29 -04:00
Matthew Chen
81555d1225 Add “new contact” and “add to existing contact” buttons in 1:1 conversation settings view. 
// FREEBIE
 2017-07-12 13:18:14 -04:00
Matthew Chen
1e67bb52e3 Respond to CR. 
// FREEBIE
 2017-07-12 13:18:03 -04:00
Matthew Chen
990978ac3b Merge branch 'charlesmchen/orphanCleanup' 2017-07-12 12:15:50 -04:00
Matthew Chen
0357081cc7 [SSK] Run orphan cleanup on startup. 
// FREEBIE
 2017-07-12 12:15:21 -04:00
Matthew Chen
2202fe70fe Fix broken tests. 
// FREEBIE
 2017-07-12 12:14:15 -04:00
Matthew Chen
f584c4b434 Fix broken tests. 
// FREEBIE
 2017-07-12 12:14:15 -04:00
Matthew Chen
0b28285deb Fix broken tests. 
// FREEBIE
 2017-07-12 12:14:15 -04:00
Matthew Chen
69ba2811db Run orphan cleanup on startup. 
// FREEBIE
 2017-07-12 12:14:15 -04:00
Michael Kirk
4b7924cc72 [SSK] update CI gems 
// FREEBIE
 2017-07-12 11:57:30 -04:00
Michael Kirk
c0aa455714 fix tests 
// FREEBIE
 2017-07-12 09:44:11 -04:00
Michael Kirk
195f124afe Merge branch 'mkirk/fix-tests-again' 2017-07-11 16:37:02 -04:00
Michael Kirk
f4d675e952 update ci to use latest XCode / fastlane 
// FREEBIE
 2017-07-11 16:36:50 -04:00
Michael Kirk
d15da6e6d4 fix bubble calculator tests 
// FREEBIE
 2017-07-11 16:36:50 -04:00
Michael Kirk
3eb90ba383 Disable singleton assert for tests 
introduce a new build configuration, used by tests, which disables
singleton asserts

// FREEBIE
 2017-07-11 16:36:50 -04:00
Michael Kirk
82180f6a97 fix compilation problems 
// FREEBIE
 2017-07-11 16:36:50 -04:00
Matthew Chen
fa09ce08f2 Merge branch 'charlesmchen/owsFailSwift' 2017-07-11 16:21:28 -04:00
Matthew Chen
c9355630c7 Respond to CR. 
// FREEBIE
 2017-07-11 16:21:17 -04:00
Matthew Chen
d639d6557e Add owsFail free function for swift. 
// FREEBIE
 2017-07-11 16:20:20 -04:00
Matthew Chen
8000714151 Merge branch 'charlesmchen/archiveViewIndicator' 2017-07-11 16:14:07 -04:00
Matthew Chen
669e0644ea Respond to CR. 
// FREEBIE
 2017-07-11 16:11:56 -04:00
Matthew Chen
5cf0441f55 Add a reminder that you are in archive view. 
// FREEBIE
 2017-07-11 16:01:19 -04:00
Matthew Chen
54a5b960c7 Add a reminder that you are in archive view. 
// FREEBIE
 2017-07-11 16:01:19 -04:00
Matthew Chen
8f3b837a65 Add a reminder that you are in archive view. 
// FREEBIE
 2017-07-11 16:01:19 -04:00
Matthew Chen
2e727a24b5 Convert home view to programmatic layout. 
// FREEBIE
 2017-07-11 16:01:19 -04:00
Michael Kirk
cc31d88f29 [SSK] Fix persist view for upgrade scenario 
// FREEBIE
 2017-07-11 15:28:15 -04:00
Michael Kirk
f61980e376 [SSK] remove unhelpful logging 
// FREEBIE
 2017-07-11 13:21:33 -04:00
Michael Kirk
3162160b5e Merge branch 'mkirk/respect-contact-sort-pref' 2017-07-10 13:08:54 -05:00
Michael Kirk
5223104566 respect system sort order for contacts 
// FREEBIE
 2017-07-10 13:08:40 -05:00
Matthew Chen
b19dd648d2 Bump build number to v2.14.0.0. 
// FREEBIE
 2017-07-10 12:57:05 -04:00
Michael Kirk
dbf0235974 [SSK] persist thread view 
// FREEBIE
 2017-07-10 11:54:37 -05:00
Michael Kirk
2d8e4232aa Merge branch 'mkirk/trickle-ice-2' 2017-07-10 11:49:46 -05:00
Michael Kirk
2dcfb4e3b8 Send ICE updates immediately. 
Now that SN changes do not block incoming messages, the caller does not
need to enqueue outgoing ICE updates.

However this introduces the possibility that the call recipient could
recieve an ICE update before their peerConnectionClient is set up - so
now we ensure that call service waits for it's peerConnectionClient
before processing incoming ICE updates.

// FREEBIE
 2017-07-10 11:49:38 -05:00
Matthew Chen
0698d11619 Merge branch 'charlesmchen/doubleBusyRace' 2017-07-10 12:44:35 -04:00
Matthew Chen
1a400f8414 Respond to CR. 
// FREEBIE
 2017-07-10 12:39:44 -04:00
Matthew Chen
b6531a8b5d If two users call each other at the same time, ensure they both see “busy”. 
// FREEBIE
 2017-07-10 12:25:22 -04:00
Michael Kirk
eb9b6bffd2 Merge branch 'mkirk/update-webrtc' 2017-07-10 11:16:17 -05:00
Michael Kirk
961576448b Update WebRTC to M59 + signal patches 
// FREEBIE
 2017-07-10 11:15:57 -05:00