signalapp/Signal-iOS
signalapp/Signal-iOS
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases 4 Wiki Activity
4,456 Commits 1 Branch 2,246 Tags 1.8 GiB
2dfea25243
Commit Graph

4456 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Matthew Chen
2dfea25243 Split up GIF requests. 
// FREEBIE
 2017-10-27 17:23:51 -04:00
Matthew Chen
84406b5fec Split up GIF requests. 
// FREEBIE
 2017-10-27 17:23:51 -04:00
Michael Kirk
cca33f02b2 Sync translations 
// FREEBIE
 2017-10-27 11:12:54 -07:00
Michael Kirk
aee6b3c0cf Merge branch 'mkirk-2.18.0/handle-padded-attachments' into release/2.18.0 2017-10-27 10:01:37 -07:00
Michael Kirk
cf9874302b Remove unecessary subdata for unpadded attachment 
// FREEBIE
 2017-10-27 08:51:23 -07:00
Michael Kirk
ce51d2da3e Example (disabled) padding strategy for attachment sender 
The padding strategy the sender uses can change without needing to
update the receiver, so long as we continue to record the unpadded
length of the attachment in the attachment pointer.

// FREEBIE
 2017-10-27 08:47:53 -07:00
Michael Kirk
cbbb376860 Handle receiving padded attachments 
Don't send padded attachments yet.

// FREEBIE
 2017-10-27 08:47:53 -07:00
Michael Kirk
81386eae0c Merge branch 'mkirk-2.18.0/require-attachment-checksum' into release/2.18.0 2017-10-27 08:43:03 -07:00
Michael Kirk
259695a9fd Attachments require digest or show explanatory error. 
// FREEBIE
 2017-10-27 08:42:54 -07:00
Michael Kirk
334a04c430 Merge branch 'mkirk-2.18.0/attachment-size' into release/2.18.0 2017-10-27 08:42:32 -07:00
Michael Kirk
6eeb78157a Include size in attachment pointer 
// FREEBIE
 2017-10-26 15:11:37 -07:00
Michael Kirk
efd58022d0 bump version 
// FREEBIE
 2017-10-23 16:01:37 -07:00
Michael Kirk
288b975a17 Pull latest translations 
// FREEBIE
 2017-10-23 16:00:52 -07:00
Michael Kirk
f3f0d591ea Revert "Add workaround for bug in iOS 11.1 beta around hit area of custom back buttons." 
This reverts commit 7c82f6d448.

This wasn't helping our crash rate, and on my device, as of iOS11.1B2,
the button is easily tappable, not detectably different from prior iOS
releases.
 2017-10-20 16:37:07 -07:00
Michael Kirk
66ab4e2549 Merge tag '2.16.2.0' into release/2.18.0 2017-10-20 16:23:58 -07:00
Michael Kirk
2d10080c33 Merge tag '2.17.1.1' into release/2.18.0 2017-10-20 16:23:10 -07:00
Matthew Chen
e427d25c5a Bump build to 2.18.0.3. 
// FREEBIE
 2017-10-20 17:53:17 -04:00
Matthew Chen
8fdc980cad Update l10n strings. 
// FREEBIE
 2017-10-20 17:53:07 -04:00
Matthew Chen
bdb2890801 Merge branch 'charlesmchen/gifProxy' into release/2.18.0 2017-10-20 16:22:14 -04:00
Matthew Chen
c11b82ba30 Respond to CR. 
// FREEBIE
 2017-10-20 16:21:52 -04:00
Matthew Chen
9274d7fd9b Fix proxying of Giphy requests. 
// FREEBIE
 2017-10-20 16:12:11 -04:00
Michael Kirk
0cd56d4bcc On iOS11 doc picker requires system appearance. 
Otherwise nav items are illegible.

// FREEBIE
 2017-10-20 12:35:21 -07:00
Michael Kirk
b6c9a2a67f Merge branch 'mkirk/gif-data' into release/2.18.0 2017-10-20 12:35:04 -07:00
Michael Kirk
64c7c40b81 CR: add shadow to activity indicator 
// FREEBIE
 2017-10-20 12:34:55 -07:00
Michael Kirk
2af99eb710 Allow canceling GIF download 
// FREEBIE
 2017-10-20 12:34:55 -07:00
Michael Kirk
891cc6ee0d CR: better method names 
// FREEBIE
 2017-10-20 12:34:55 -07:00
Michael Kirk
6eaa49593d preview vs. sending have independent resolution min 
// FREEBIE
 2017-10-20 12:34:55 -07:00
Michael Kirk
688810c267 CR: Enforce "one time only" with a bool, not a cell ref 
Since cell's can be re-used, at a later point, we might not be
referencing the data we intend. Since all we want to do is enforce a
"one time only" check, just use a bool.

// FREEBIE
 2017-10-20 12:34:55 -07:00
Michael Kirk
591cba6468 fix comment typos 
// FREEBIE
 2017-10-20 12:34:55 -07:00
Michael Kirk
a01de44917 Fix intermittent crash 
// FREEBIE
 2017-10-20 12:34:55 -07:00
Michael Kirk
6db5895269 dismiss keyboard when scrolling after auto-search 
// FREEBIE
 2017-10-20 12:34:55 -07:00
Michael Kirk
be51776d82 Fix mask appearing partially above search bar 
// FREEBIE
 2017-10-20 12:34:55 -07:00
Michael Kirk
37177de7cb Make sure user knows what they're picking 
Abort selection until *some* kind of asset has been downloaded.

// FREEBIE
 2017-10-20 12:34:55 -07:00
Michael Kirk
e4ad169d71 Show retryable error alert when fetching GIF fails 
// FREEBIE
 2017-10-20 12:34:55 -07:00
Michael Kirk
3939e8a6ac Download picked GIF faster: cancel pending request 
// FREEBIE
 2017-10-20 12:34:55 -07:00
Michael Kirk
b8ce636afc Show loading screen while selected GIF downloads 
// FREEBIE
 2017-10-20 12:34:55 -07:00
Michael Kirk
ddf2fe21a1 Download smaller GIF for previews. 
Previously we were downloading a full sized GIF for each cell, which can
take dozens of seconds on a slower connection. Now we download a smaller
GIF for the picker view, and only download the full sized GIF for the
selected cell.

Some stats:

Before:

Scenario: search "Cat" and no scrolling, no picking
~10 MB

Scenario: search "Cat" and no scrolling, then pick
~10 MB

Scenario: search "Cat" and scroll 3 screens, no picking
~30 MB

Scenario: search "Cat" and scroll 3 screens, then pick
~30 MB

After:

Scenarios: search "Cat" and no scrolling, no picking
~1.0 MB (savings 90%)

Scenarios: search "Cat" and no scrolling, then pick
~3.5 MB (savings 65%)

Scenarios: search "Cat" and scroll 3 screens, no picking
~3.0 MB (savings 90%)

Scenarios: search "Cat" and scroll 3 screens, then pick
~5.5 MB (savings 81%)

// FREEBIE
 2017-10-20 12:34:55 -07:00
Michael Kirk
2a4c6506fb log giphy data usage in debug 
// FREEBIE
 2017-10-20 12:34:55 -07:00
Matthew Chen
4dabb71815 Fix "can't send same GIF twice" issue. 
// FREEBIE
 2017-10-19 22:33:51 -04:00
Michael Kirk
9eb4909185 bump build 
// FREEBIE
 2017-10-18 16:30:57 -07:00
Matthew Chen
a7195e4040 Merge branch 'charlesmchen/refineGifSearch' into release/2.18.0 2017-10-18 08:32:57 -07:00
Matthew Chen
a386ac5685 Respond to CR. 
// FREEBIE
 2017-10-18 08:32:28 -07:00
Matthew Chen
b90e9fcd64 Skip redundant GIF searches. 
// FREEBIE
 2017-10-17 18:07:29 -07:00
Matthew Chen
33d3c4123a Progressive GIF search shouldn't dismiss keyboard. 
// FREEBIE
 2017-10-17 17:56:05 -07:00
Michael Kirk
2716f50399 Bump version 
// FREEBIE
 2017-10-16 18:20:35 -07:00
Michael Kirk
6e12b9c898 Fix trailing edge of group member listing 
// FREEBIE
 2017-10-16 13:33:07 -07:00
Michael Kirk
90468135c3 Merge branch 'mkirk/compose-cr-fixups' into release/2.18.0 2017-10-16 12:59:40 -07:00
Michael Kirk
ab05bd32e8 compose search cleanup per code review 
// FREEBIE
 2017-10-16 12:59:15 -07:00
Michael Kirk
a76b1f52b0 Merge branch 'mkirk/show-entire-message' into release/2.18.0 2017-10-16 12:26:23 -07:00
Michael Kirk
9ae4a26eb1 Message details shows entire message 
When viewing a longer message, to avoid the risk of the user not being
aware they can scroll down, we scroll to the last couple lines of the
message, ensuring they can see the meta-data.

// FREEBIE
 2017-10-16 12:26:16 -07:00