* Hide navigation bar when searching in chats list
* Incomplete search bar layout
* apply story search filtering
* hide my stories section when searching
* Improve transitions for story tab bar search
* Show hidden stories in search results
* visual fixes to header when searching. include all unfiltered stories in viewer contexts
* delay getting the target story frame for interactive dismissal to give the view time to update after navigation bar changes
* fix strings
* pr feedback
If we’ve recently discovered that a phone number can’t be discovered,
there isn’t much benefit to checking again.
However, for other parts of the migration flow, we still want to
consider such users. For example, sometimes we want to require all users
to have a UUID to perform a migration. Before this change, we might
return a false positive after performing a CDS lookup since we wouldn’t
check whether or not recently undiscoverable users have a UUID.
In another case, we’re intentionally excluding users without UUIDs. In
this case, the end result is the same whether we drop them during the
first pass or the second pass, but the intent is more clear if we drop
all such users during the second pass.
Lastly, we want to fetch profiles even for undiscoverable users, even
though this operation is likely to fail.
If a currency is not in the list returned by the server, you shouldn't
be able to choose it because it won't work.
This worked correctly for monthly and gift donations, but not for
one-time. This fixes that.
This still has a bug where if your default currency isn't in the list,
you'll still be able to choose it. (Your default currency is locale-
-dependent; see `Stripe.defaultCurrencyCode`.) However, I plan to
address that in an upcoming change, and this commit doesn't make that
bug *worse*.
In text story composer, link preview might be collapsed to "compact" layout
after user enough text so that there's no more vertical room for both text
and link preview.
This change improves composer behavior to expand link preview back to
"regular" layout if user deletes some or all text and there's now room for both.
A "donation hero" is shown twice in the app: once on the donation
settings screen, and another on the subscription management screen.
Previously, they were slightly different. With some new copy changes,
they're the same, so we can use a single view for both.
* Shuffle code around, adding UnsentTextAttachment
* Replace usages of TextAttachment with UnsentTextAttachment where applicable, creating an actual TextAttachment (and associated OWSlinkPreview image TSAttachment, if applicable) only per-recipient
* Only upload one text story link preview image attachment and propagate it to the individual TSAttachments created for each destination
* update comments so I don't lose my mind the next time I read this code
* Dedupe text stories sent to the same person via multiple private threads
* fix non-compiling tests
* pr feedback
Several strings appear to be unused. As far as I can tell, these were
added in 54b743de2d but never used.
Script output:
PluralAware.stringsdict: Removed THREAD_DETAILS_MORE_MUTUAL_GROUP_%d
PluralAware.stringsdict: Removed TIME_AMOUNT_DAYS_%d
PluralAware.stringsdict: Removed TIME_AMOUNT_DAYS_SHORT_%d
PluralAware.stringsdict: Removed TIME_AMOUNT_HOURS_%d
PluralAware.stringsdict: Removed TIME_AMOUNT_HOURS_SHORT_%d
PluralAware.stringsdict: Removed TIME_AMOUNT_MINUTES_%d
PluralAware.stringsdict: Removed TIME_AMOUNT_MINUTES_SHORT_%d
PluralAware.stringsdict: Removed TIME_AMOUNT_SECONDS_%d
PluralAware.stringsdict: Removed TIME_AMOUNT_SECONDS_SHORT_%d
PluralAware.stringsdict: Removed TIME_AMOUNT_WEEKS_%d
PluralAware.stringsdict: Removed TIME_AMOUNT_WEEKS_SHORT_%d
PluralAware.stringsdict: Removed TIME_AMOUNT_YEARS_%d
On iOS 16, the nav bar itself is transparent, so the container view
controller’s background is visible. The color of that view wasn’t being
updated, which resulted in the nav bar appearing the wrong color.
A few view controllers worked around this by manually updating just the
background color to the same value used by the table view. It seems
cleaner to re-apply the overall styling when the theme changes.
* remove unecessary owsFailDebug
* fix context menu icon positioning
* fix layout of custom context menus near the left side of the screen in RTL languages
* UX tweaks for my story cell
* status
* apply theme changes to tab bar that happened while it was hidden
* pr feedback 1
* pr feedback 2
This reverts commits 41b381b1b1 and
856ced4062.
'supportedInterfaceOrientations' doesn't behave correctly in certain
scenarios, including when the app is *launched* in landscape.
There were some redundant checks as a result of the duplication between
the validation and lookup methods. Shift more of the logic into the
shared method to avoid repeating the same thing multiple times.
Also, return a single item rather than an `Array`. We only expect a
single result, so there’s no need to pass around an `Array.`
