Matthew Chen
04a300784f
Respond to CR.
2019-01-15 16:34:46 -05:00
Matthew Chen
42762ad907
Allow taps in albums with failed images.
2019-01-15 16:34:46 -05:00
Matthew Chen
b6e28adfe3
Merge branch 'charlesmchen/inputToolbarMarginsVsRotation3' into release/2.34.0
2019-01-15 16:34:09 -05:00
Matthew Chen
b8e2cb6267
Respond to CR.
2019-01-15 16:33:54 -05:00
Matthew Chen
18c890bb95
Fix input toolbar margins issue.
2019-01-15 16:30:32 -05:00
Michael Kirk
8d87449986
Merge branch 'mkirk/eagerly-load-rail' into release/2.34.0
2019-01-15 10:27:47 -07:00
Michael Kirk
7fddb35715
eagerly load entire album to populate rail
2019-01-15 10:27:29 -07:00
Michael Kirk
101d17cfeb
Merge branch 'mkirk/video-select' into release/2.34.0
2019-01-14 14:25:52 -07:00
Michael Kirk
a497e44cef
Fix iCloud download
2019-01-14 12:19:59 -07:00
Michael Kirk
59e037986a
Show error when image request fails
2019-01-14 12:15:13 -07:00
Michael Kirk
623c2574d0
Merge branch 'mkirk/dont-select-unless-batch'
2019-01-14 10:29:28 -07:00
Michael Kirk
5fdb88ddf4
Don't add to selection unless in batch select mode
...
Fixes:
- choose attachment > media library
- tap image A
- tap back
- tap select
- select images B, C
- tap Done
- see image A, B, and C in the rail, but should just see image B and C
2019-01-14 10:28:45 -07:00
Michael Kirk
2df6ae2cfd
Merge branch 'mkirk/scroll-to-bottom-when-switching-albums'
2019-01-14 10:02:17 -07:00
Michael Kirk
924b8b18ba
Scroll to bottom when switching albums
...
Fixes
1. start on "All Photos" which has many pages of content
You're at the bottom, as expected.
2. switch to "Video", which is much shorter
You're at the bottom, as expected.
3. Switch back to "All Photos"
Now you're unexpectedly in the middle of the content somewhere - at whatever
offset the "Videos" content height was.
Note that changes to "scrollToBottom". For some reason calling scroll to bottom
with infinity works fine initially, but subsequent calls hang. Because we only
used the "infinity" hack to account for the fact that we didn't have accurate
safeAreaInsets before `viewDidAppear`, we can accurately use safeAreaInsets
after that point (like here, when switching albums).
2019-01-14 10:01:55 -07:00
Matthew Chen
ff2fdcb7e1
Merge branch 'mkirk/fix-conversion'
2019-01-14 09:49:43 -05:00
Michael Kirk
119f309787
Fixup database conversion vis a vis SQLCipher4
2019-01-14 09:48:49 -05:00
Matthew Chen
96fffb92cc
Merge tag '2.33.1.0'
2019-01-14 09:14:14 -05:00
Michael Kirk
ed15e5cc4a
Update YapDB to fix DB conversion logic
2019-01-11 18:23:02 -07:00
Matthew Chen
433ef08235
"Bump build to 2.34.0.14."
2019-01-11 18:01:14 -05:00
Matthew Chen
fba26653c8
"Bump build to 2.34.0.13."
2019-01-11 18:01:10 -05:00
Matthew Chen
a8ba8b668f
Merge branch 'charlesmchen/imagePickingFixes'
2019-01-11 17:56:15 -05:00
Matthew Chen
63aa71c318
Respond to CR.
2019-01-11 17:56:07 -05:00
Matthew Chen
6c38f8d14c
Only complete media loads once.
2019-01-11 17:56:07 -05:00
Matthew Chen
6b100e80e2
Only enter batch select mode if user uses "add more" button.
2019-01-11 17:56:07 -05:00
Matthew Chen
3e36dcf91f
Merge branch 'charlesmchen/conversationRotationVsScrollContinuity'
2019-01-11 17:55:33 -05:00
Matthew Chen
d32372ec26
Respond to CR.
2019-01-11 17:55:21 -05:00
Matthew Chen
9dda2fa8c0
Improve scroll state continuity during conversation view rotations.
2019-01-11 17:55:21 -05:00
Matthew Chen
1fc90974fc
Merge branch 'charlesmchen/honorAlbumSelectionOrder'
2019-01-11 16:58:39 -05:00
Matthew Chen
9051191bab
Honor album selection order.
2019-01-11 16:54:11 -05:00
Matthew Chen
af81404e45
Merge branch 'mkirk/remain-landscape-after-media-dismiss'
2019-01-11 16:47:41 -05:00
Michael Kirk
0f85e52ecf
Remain landscape after media dismiss
...
Now that we support landscape everywhere, there's no need to force portrait upon leaving media.
2019-01-11 16:47:32 -05:00
Matthew Chen
c5cd52db06
Merge branch 'charlesmchen/cullUnknownMigrations'
2019-01-11 16:46:44 -05:00
Matthew Chen
efd1be30c7
Cull unknown migrations.
2019-01-11 16:46:33 -05:00
Michael Kirk
162a4894e3
Merge branch 'mkirk/remove-feature-flag'
2019-01-11 11:25:43 -07:00
Michael Kirk
371ff08d45
remove legal terms feature flag
2019-01-11 11:25:34 -07:00
Michael Kirk
145a94cf39
Merge branch 'mkirk/ci-label-branches'
2019-01-11 10:53:30 -07:00
Michael Kirk
0795fc9118
ci labels PRs with GH title
2019-01-11 10:53:22 -07:00
Matthew Chen
d58ffed11b
Merge branch 'mkirk/bump-migration'
2019-01-11 10:49:54 -05:00
Michael Kirk
0e78f9912b
bump migration version
2019-01-11 07:44:19 -07:00
Matthew Chen
5568482e4c
"Bump build to 2.33.1.0."
2019-01-10 17:16:25 -05:00
Matthew Chen
cc4d85a91e
Encrypted device names.
2019-01-10 17:12:29 -05:00
Michael Kirk
6fccd76cdf
update pods
2019-01-10 13:15:29 -07:00
Michael Kirk
444c2af650
Merge branch 'mkirk/clientside-registration-validation'
2019-01-10 13:08:18 -07:00
Michael Kirk
eb71c49794
registration validator
2019-01-10 13:08:10 -07:00
Michael Kirk
cd70f9d0c3
move to yapdb@signal-release
2019-01-10 13:04:03 -07:00
Matthew Chen
73f622db69
"Bump build to 2.34.0.5."
2019-01-10 14:41:51 -05:00
Matthew Chen
7fb2f2dc1e
"Bump build to 2.34.0.4."
2019-01-10 12:53:11 -05:00
Matthew Chen
1440998cb1
Merge branch 'mkirk/sqlcipher4'
2019-01-10 12:49:17 -05:00
Michael Kirk
5708754d30
update to sqlcipher4
2019-01-10 12:48:59 -05:00
Matthew Chen
7e3ccad22a
Merge branch 'mkirk/area-code-inference'
2019-01-10 12:44:56 -05:00
