This updates the CheckSSRtx function comment to refer to the correct
output indexes from the input ticket transaction. It also updates the
comment to refer to SSRtx outputs rather than SSGen outputs.
This adds a comment to MaxOutputsPerSSGen indicating that if the
treasury agenda is active, an OP_RETURN TV (treasury vote) output is
additionally included in the last position when voting on a treasury
spend.
The MaxOutputsPerSSGen value does NOT account for this output, and
should technically be increased by 1, but since the treasury agenda is
already active this cannot be updated without a consensus vote.
This modifies the version 2 block filters in gcs to avoid using
standardness code since they are part of consensus code through header
commitments and therefore must not change even though the policy
regarding standardness can change.
It accomplishes the change by making use of the consensus-specific
script identification methods available via the stake package.
This modifies the treasury code in blockchain which enforces the
treasury generation spending maturity to avoid using standardness code
since it is consensus level code which means it must not change even
though the policy regarding standardness can change.
This adds a method to stake which allow treasury generation scripts that
are enforced by consensus to be identified via a consensus-specific
method versus relying on the policy-based variant that is subject to
change.
This is consistent with the other consensus-enforced stake-related
scripts exported from the package.
This removes the unnecessary OP_TADD coinbase maturity check because
OP_TADD is not a spendable utxo and therefore it can never have a
maturity applied to it. Recall that treasurybase and treasury add stake
transactions are the only place an OP_TADD is valid and in both cases
they result in increasing the balance of the treasury account and are
never directly spendable.
This modifies the treasury code in stake to avoid using standardness
code since it is consensus level code which mean it must not change even
though the policy regarding standardness can change.
The consensus-specific methods are all already available in the stake
package, so the code is merely updated to use them instead.
An overview of the changes follows:
- Introduce an exported constant for the max data carrier size allowed
in stake transactions set to match the current standardness value
since that is now part of consensus for them
- Modify the calls to txscript.GetScriptClass used for determining null
data scripts to use consensus-specific IsNullDataScript method
- Use the consensus-specific methods for the following:
- IsStakeChangeScript
- isPubKeyHashScript
- isScriptHashScript
This modifies the TicketsWithAddress query method in blockchain to
accept the more specific stdaddr.StakeAddress since only stake-capable
addresses can be used in tickets and modifies the logic to compare the
expected voting rights script and associated script version directly
instead of extracting and comparing encoded addresses. It also updates
the callers and plumbing in rpcserver accordingly as well as adds a test
for the new non-stake address error in the RPC handler.
Not only is this approach more efficient, it also removes the reliance
on address extraction which in turn removes the need for the flag which
specifies whether or not the treasury is active.
This adds an example for extracting the script hash from a
pay-to-script-hash script.
This part of a series of commits to fully implement the stdscript
package.
This adds an example for extracting the public key hash from a
p2pkh-ecdsa-secp256k1 script.
This part of a series of commits to fully implement the stdscript
package.
This adds an example for determining the script type of a public key
script in terms of standardness.
This part of a series of commits to fully implement the stdscript
package.
BenchmarkExtractAtomicSwapDataPushes
------------------------------------
v0_complex_not_atomic_swap 15944958 76.34 ns/op 0 B/op 0 allocs/op
v0_normal_valid_atomic_swap 3660967 335.9 ns/op 96 B/op 1 allocs/op
This part of a series of commits to fully implement the stdscript
package.
This adds support for identifying if a redeem script is a version 0
atomic swap redeem script for an original pay-to-script-hash script as a
convenience method for consumers of the package.
Note that this is different than most other methods in the package in
that it applies to the redeem script as opposed to the public key script
and consequently there is no new script type introduced nor does the
overall script determination detect it. This is the case because a
redeem script is the final push of a signature script that is itself a
redemption of a pay-to-script-hash script.
Full test coverage is included.
This is part of a series of commits to fully implement the stdscript
package.
This adds a convenience method to create a standard version 0 ecdsa
multisignature redemption script that requires a threshold of signatures
from a set of public keys.
Full test coverage is included.
This is part of a series of commits to fully implement the stdscript
package.
BenchmarkIsTreasuryGenScriptHashScript
--------------------------------------
v0_complex_non_standard 814816624 1.310 ns/op 0 allocs/op
v0_treasury_generation_p2sh 520297904 2.274 ns/op 0 allocs/op
This is part of a series of commits to fully implement the stdscript
package.
This adds support for detecting version 0 treasury generation
pay-to-script-hash scripts as standard and extracting the associated
script hash.
Full test coverage is included.
This is part of a series of commits to fully implement the stdscript
package.
BenchmarkIsTreasuryGenPubKeyHashScript
--------------------------------------
v0_complex_non_standard 317927872 3.843 ns/op 0 allocs/op
v0_treasury_gen_p2pkh-ecdsa-secp256k1 225968358 5.261 ns/op 0 allocs/op
This is part of a series of commits to fully implement the stdscript
package.
This adds support for detecting version 0 treasury generation
pay-to-pubkey-hash scripts as standard and extracting the associated
public key hash.
Full test coverage is included.
This is part of a series of commits to fully implement the stdscript
package.
BenchmarkIsTreasuryAddScript
----------------------------
v0_complex_non_standard 905938653 1.328 ns/op 0 allocs/op
v0_treasury_add 1000000000 0.9594 ns/op 0 allocs/op
This is part of a series of commits to fully implement the stdscript
package.
This adds support for detecting version 0 treasury add scripts as
standard.
Full test coverage is included.
This is part of a series of commits to fully implement the stdscript
package.
BenchmarkIsStakeChangeScriptHash
--------------------------------
v0_complex_non_standard 688796947 1.626 ns/op 0 allocs/op
v0_stake_change_p2sh 503956689 2.282 ns/op 0 allocs/op
This is part of a series of commits to fully implement the stdscript
package.
This adds support for detecting version 0 stake change
pay-to-script-hash scripts as standard and extracting the associated
script hash.
Full test coverage is included.
This is part of a series of commits to fully implement the stdscript
package.
BenchmarkIsStakeChangePubKeyHash
--------------------------------
v0_complex_non_standard 311063840 3.794 ns/op 0 allocs/op
v0_stake_change_p2pkh-ecdsa-secp256k1 228116065 5.355 ns/op 0 allocs/op
This is part of a series of commits to fully implement the stdscript
package.
This adds support for detecting version 0 stake change
pay-to-pubkey-hash scripts as standard and extracting the associated
public key hash.
Full test coverage is included.
This is part of a series of commits to fully implement the stdscript
package.
BenchmarkIsStakeRevocationScriptHashScript
------------------------------------------
v0_complex_non_standard 725635868 1.631 ns/op 0 allocs/op
v0_stake_revoke_p2sh 522431919 2.571 ns/op 0 allocs/op
This is part of a series of commits to fully implement the stdscript
package.
This adds support for detecting version 0 stake revocation
pay-to-script-hash scripts as standard and extracting the associated
script hash.
Full test coverage is included.
This is part of a series of commits to fully implement the stdscript
package.
BenchmarkIsStakeRevocationPubKeyHashScript
------------------------------------------
v0_complex_non_standard 311770504 3.842 ns/op 0 allocs/op
v0_stake_revoke_p2pkh-ecdsa-secp256k1 228088618 5.316 ns/op 0 allocs/op
This is part of a series of commits to fully implement the stdscript
package.
This adds support for detecting version 0 stake revocation
pay-to-pubkey-hash scripts as standard and extracting the associated
public key hash.
Full test coverage is included.
This is part of a series of commits to fully implement the stdscript
package.
BenchmarkIsStakeGenScriptHashScript
-----------------------------------
v0_complex_non_standard 748967828 1.612 ns/op 0 allocs/op
v0_stake_gen_p2sh 536599674 2.234 ns/op 0 allocs/op
This is part of a series of commits to fully implement the stdscript
package.
This adds support for detecting version 0 stake generation
pay-to-script-hash scripts as standard and extracting the associated
script hash.
Full test coverage is included.
This is part of a series of commits to fully implement the stdscript
package.
BenchmarkIsStakeGenPubKeyHashScript
-----------------------------------
v0_complex_non_standard 311106744 3.842 ns/op 0 allocs/op
v0_stake_gen_p2pkh-ecdsa-secp256k1 217513142 5.305 ns/op 0 allocs/op
This is part of a series of commits to fully implement the stdscript
package.
This adds support for detecting version 0 stake generation
pay-to-pubkey-hash scripts as standard and extracting the associated
public key hash.
Full test coverage is included.
This is part of a series of commits to fully implement the stdscript
package.
BenchmarkIsStakeSubmissionScriptHashScript
------------------------------------------
v0_complex_non_standard 930421526 1.284 ns/op 0 allocs/op
v0_stake_submission_p2sh 529045244 2.273 ns/op 0 allocs/op
This is part of a series of commits to fully implement the stdscript
package.
This adds support for detecting version 0 stake submission
pay-to-script-hash scripts as standard and extracting the associated
script hash.
Full test coverage is included.
This is part of a series of commits to fully implement the stdscript
package.
BenchmarkIsStakeSubmissionPubKeyHashScript
------------------------------------------
v0_complex_non_standard 312435804 3.828 ns/op 0 allocs/op
v0_stake_sub_p2pkh-ecdsa-secp256k1 220546760 5.301 ns/op 0 allocs/op
This is part of a series of commits to fully implement the stdscript
package.
This adds support for detecting version 0 stake submission
pay-to-pubkey-hash scripts as standard and extracting the associated
public key hash.
Full test coverage is included.
This is part of a series of commits to fully implement the stdscript
package.
This adds support for detecting version 0 nulldata scripts as standard.
It should be noted that this code includes a change in the semantics as
compared to the existing code. In particular, the existing code detects
and treats any type of data push up to the maximum allowed length,
including those that are not canonical, as standard per policy, whereas
this new code further restricts the standardness policy to only treat
nulldata scripts with canonical data pushes up to the maximum allowed
length as standard since they occupy less space on chain and there is
really no good reason for using non-canonical pushes anyway. In
practice, all known software already only creates canonical pushes and
has since launch.
This does not affect consensus in any way since consensus enforces its
own code related to the associated opcode as required. Further,
nulldata scripts are unspendable by consensus, so this is purely a
policy change.
Full test coverage is included.
This is part of a series of commits to fully implement the stdscript
package.
BenchmarkMultiSigRedeemScriptFromScriptSigV0
--------------------------------------------
v0_multisig_1-of-1_redeem_script 22222550 51.36 ns/op 0 allocs/op
v0_multisig_1-of-2_redeem_script 27158536 42.95 ns/op 0 allocs/op
This is part of a series of commits to fully implement the stdscript
package.
BenchmarkIsMultiSigSigScript
----------------------------
v0_complex_non_standard 276108408 4.344 ns/op 0 allocs/op
v0_multisig_1-of-1_redeem 11796938 102.6 ns/op 0 allocs/op
v0_multisig_1-of-2_redeem 10727167 111.2 ns/op 0 allocs/op
This is part of a series of commits to fully implement the stdscript
package.
This adds support for identifying if a signature script likely consists
of a pay-to-script-hash multi-signature redeem script for an original
pay-to-script-hash script as a convenience method for consumers of the
package.
Note that this is different in that it applies to the signature script
as opposed to the public key script and consequently there is no new
script type introduced nor does the overall script determination detect
it. This is the case because determining if a signature script is
actually a redemption of pay-to-script-hash requires the associated
public key script which is often expensive to obtain. Therefore, this
makes a fast best effort guess that has a high probability of being
correct by checking if the signature script ends with a data push and
treating that data push as if it were a p2sh redeem script.
Also of note is that the same change in semantics regarding compressed
public keys and the required number of signatures as described in the
commit which introduced support for detecting version 0 ecdsa
multisignature scripts applies here.
Full test coverage is included.
This is part of a series of commits to fully implement the stdscript
package.
BenchmarkIsMultiSigScript
-------------------------
v0_complex_non_standard 211282112 5.694 ns/op 0 allocs/op
v0_multisig_1-of-1_compressed_pubkey 20099121 59.14 ns/op 0 allocs/op
v0_multisig_1-of-2_compressed_pubkeys 18043728 65.97 ns/op 0 allocs/op
v0_multisig_2-of-3_compressed_pubkeys 15902906 76.20 ns/op 0 allocs/op
This is part of a series of commits to fully implement the stdscript
package.
This adds support for detecting version 0 ecdsa multisignature scripts
as standard and extracting the associated details, including the number
of required signatures, number of public keys, and the public keys
themselves.
It should be noted that this code includes a change in the semantics as
compared to the existing code. In particular:
- The new code only multisignature scripts with compressed public keys
as standard versus the existing code that allows both compressed and
uncompressed public keys
- The new code requires at least one signature to be required versus the
existing code that only requires any small integer (which includes 0)
These ensure the scripts take up considerably less space on chain and
there really isn't a reasonable justification for not using compressed
public keys or not requiring any signatures since that could be done
with a smaller script if truly desired.
In practice, all known software already conforms to these semnatics and
has since launch.
This, of course, does not affect consensus in any way and it still
technically supports both uncompressed and compressed public keys as
well as zero required signatures for the associated multisig opcode.
Full test coverage is included.
This is part of a series of commits to fully implement the stdscript
package.
BenchmarkIsScriptHashScript
---------------------------
v0_complex_non_standard 923756949 1.279 ns/op 0 allocs/op
v0_p2sh 746887346 1.502 ns/op 0 allocs/op
This is part of a series of commits to fully implement the stdscript
package.
