openclaw/Peekaboo
openclaw/Peekaboo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 20 Wiki Activity
abb4e87a50
Peekaboo/docs/archive/refactor/mcp-command-split.md
Peter Steinberger dde7aa05b8 refactor: remove runner wrapper
2026-01-04 04:42:30 +01:00

1.3 KiB
Raw Blame History

summary read_when
MCPCommand split notes (Nov 17, 2025)
refactoring MCP CLI commands or helpers
aligning MCP subcommand formatting/error handling

MCPCommand Split Notes (Nov 17, 2025)

Status: Archived · Focus: decomposing MCPCommand and normalizing formatting/errors.

  • Broke the 1.2K-line MCPCommand.swift into per-subcommand files plus small helpers (MCPDefaults, MCPCallTypes, MCPCallFormatter, MCPArgumentParsing, MCPClientManaging) to localize responsibilities and cut duplication.
  • Behavior remains the same; the next improvement should be introducing an MCPClientService facade (wrapping TachikomaMCPClientManager) and a shared MCPContext to eliminate leftover RuntimeStorage boilerplate and make mocking straightforward.
  • Consolidate output rendering: move List/Info JSON + text formatting into the formatter so field naming/order stays consistent, and decide whether stderr/os_log suppression stays or moves into a single helper.
  • Normalize error handling across subcommands with a shared error type mapping to ErrorCode (today only Call uses CallError), and reuse key/value + JSON parsing helpers everywhere.
  • Testing gaps: add unit tests for argument parsing, call payload serialization, and list/info formatting with a mock client service; run swift build plus the CLI smoke tests once added.