2d44350b44 Revert "errors if expecing headers notification but not subscribed" (Riccardo Casatta)
Pull request description:
This reverts commit b86f2bb22c.
Some errors started to happen in downstream tests after this commit
#114
ACKs for top commit:
danielabrozzoni:
utACK 2d44350b44
Tree-SHA512: d31174055f4245cc9d99f336b166a44271067b8daecaf2bb55d507ecfa4eb557b9802d576742fba59fd4dfda3f45fc76f02d7896af31353f19fc3a38698ac5a2
the mtgox address used got too many txs, resulting in a server error:
"too many txs"
The address is changed with the peter todd sha256 breaking challenge, which
should be very difficult to spend :) and as of now has just a few txs
f5a438cd0a Bump version to 0.16.0 (Tobin C. Harding)
9a7cc14c94 Update rustls dependency to version 0.21 (Tobin C. Harding)
Pull request description:
Update the `rustls` dependency to version 0.21 and bump the version of this crate to 0.16 so the change can be released.
I don't know what stage in your release cycle you guys are up to so I put the version bump as a separate patch - can drop it if not needed.
Done to help with https://github.com/bitcoindevkit/rust-esplora-client/pull/51
ACKs for top commit:
danielabrozzoni:
utACK f5a438cd0a
Tree-SHA512: 106cbe57651a6e1365f87836598cbec9b1e837f0376ddc1c56cb75e5615543659f5c05cea7d5eb8da8b6cf278fcbe6ef866a019b9829db40cc8055798eb0f541
b86f2bb22c errors if expecing headers notification but not subscribed (Riccardo Casatta)
Pull request description:
the opposite, erroring when subscribing multiple times, is not handled because clients could call multiple times to trigger the server to reply with the tip
ACKs for top commit:
danielabrozzoni:
utACK b86f2bb22c - changes look good to me, didn't test locally
Tree-SHA512: e1a21223448e708cc054271eb1ac5285dc98bdadf7497a856fc4a19ff51655879352ca6ef9f3fb5ec5f9071dd7ee50b2e44d4c65e70694e5d9fa53d280179dd2
the opposite, erroring when subscribing multiple times, is not handled because
clients could call multiple times to trigger the server to reply with the tip
0f356ef94d Bump to v0.15.1 (Alekos Filini)
Pull request description:
Release as a bug fix with #107 merged
ACKs for top commit:
danielabrozzoni:
ACK 0f356ef94d
Tree-SHA512: 3da6a4701707549d62cfa936f5c185eec0967766797dfbacce1fb68b716b90f7e7e163c797dfb7792435cad2769a43e1b23247b0ec86f9a098a79ea4589ee281
3a61037733 Retry client should return AlreadySubscribed error (Riccardo Casatta)
Pull request description:
Users may leverage the Error to avoid remembering client-side the subscription status. eg. Always subscribing and calling script_pop in case AlreadySubscribed is returned.
Backport for version 0.14.0
ACKs for top commit:
afilini:
ACK 3a61037733
Tree-SHA512: d6542227ca03b9f3755cec05115f86de54789cfc49fc87b603b653e0458f6b03ae9fea57fa110221395a4e33cf62a5b2bd7639c4269ae5291e4c92c99ef41eba
Users may leverage the Error to avoid remembering client-side the subscription
status. eg. Always subscribing and calling script_pop in case AlreadySubscribed
is returned.
c925a9179e upgrade bitcoin dep to 0.30.0 (Riccardo Casatta)
Pull request description:
ACKs for top commit:
danielabrozzoni:
ACK c925a9179e
Tree-SHA512: 2b9b7756639af4d931213046866dc36ebee2a5adcbd01c906e27990696b07f1bcf87c2ee009a959f96b17407637801b856e8d4fb9a933fab148f22a619a0d586
80b2adeb4b Make ScriptStatus Serializable (Riccardo Casatta)
Pull request description:
it's common to cache this value client side, so making it Serializable simplify things downstream
ACKs for top commit:
afilini:
ACK 80b2adeb4b
Tree-SHA512: 9467b4f2ee24ee2a684931df31607135f44c624f65d7d3ee64b3991a06de73a07475e4d1a4b8062093500e6a7cb47c1b2ebf094596fca33bf4cc54b26851b910
40cecd5010 Use Borrow for all items in IntoIterator (Riccardo Casatta)
bf2f8ef2e5 script_subscribe IntoIterator accepts Borrow<&Script> (Riccardo Casatta)
156e6fc839 Implement batch call for script subscribe (Riccardo Casatta)
Pull request description:
script_subscribe call hasn't the batch counterpart which may be convenient for multiple subsequent subscribe.
ACKs for top commit:
afilini:
ACK 40cecd5010
Tree-SHA512: 26a3ebb9d1267a224c85b765cf793523771bf7e74990dd804a35693bfebc549f7524214725092eac2276f22cd24eafc72270986549ac02f52641db83fcb71324
561db261d3 `timeout()` and `socks()` don't return Result (Riccardo Casatta)
Pull request description:
The `Result` was necessary in the past because they couldn't both be set,
this is not true anymore after 7493630ed8
ACKs for top commit:
afilini:
ACK 561db261d3
Tree-SHA512: 7654cfbbc7beac6acec786060e373bbc046e1dae0faf2b2ca1df33121e9e92a8f4950c7f8775e44226a62483aeae41c76162cf037ce38137c44d2fedd38560c8
97e60bad4b Bump version to 0.12.0 (Alekos Filini)
Pull request description:
ACKs for top commit:
danielabrozzoni:
ACK 97e60bad4b
Tree-SHA512: e71c2093229552b5317f9309008924a6b2e8f6a48564535d2cd77e6830f342359574518836cfa579460b642c6aa8a2f36b81637b2ee8a48a68f695425333f1a2
d132572c14 Bump bitcoin dependency to ^0.29, minor related fixes (Steve Myers)
Pull request description:
This version bump for `bitcoin` dependency is required to fix https://github.com/bitcoindevkit/bdk/issues/646.
ACKs for top commit:
afilini:
ACK d132572c14
Tree-SHA512: ad89362fa32e386f02ef5721489d2c24b342af8997ceac09933dfc979f70a12b876b4856dd8982942968d8ad82ae34c49386744f51db22c70289a259a195c943
f3caf4a279 Bump version to 0.11.0 (Alekos Filini)
Pull request description:
ACKs for top commit:
danielabrozzoni:
ACK f3caf4a279
Tree-SHA512: 1b8f9853452f1462daa3788bfa3f110481d8674b870ad67eebcf8857f409312b3d69dc188ee1bc5093708f965c59c5e89fd75605bfa9059239de56fb1dbdeaee
fc8ba9de90 Use idiomatic rust for the `raw_call` method (Alekos Filini)
Pull request description:
ACKs for top commit:
danielabrozzoni:
tACK fc8ba9de90
Tree-SHA512: 1b2e92eff78df5b9fe3e6d9121af7c090e27e25aecd39187e6983252b288e0109350603d175ded2cf25365d6a85601ad4da5d8495c9943fe27280c36fe5f0c49
cbda7a22db Revert "Ignore empty lines" (Alekos Filini)
Pull request description:
This reverts commit 0e3e6325e6.
This has been causing issues with tests timing out
ACKs for top commit:
notmandatory:
utACK cbda7a22db
Tree-SHA512: ff683e16e623e71f017a361dc85e12fd7ea23d8ebd0f0616dd543aa3b12645540ae82f7eaab233dd846f5e802540064ce6a56e056d225a79e5347d730a736926
aa0b957818 Client: Drop script subscriptions to free lock (Sebastian Kung)
Pull request description:
This fixes a supposed deadlock when the reader thread receives a script subscription notification from the server before it receives a subscribing response.
I am not 100% sure if this actually fixes a deadlock, but I ran into this in a regtest setup where a bunch of subscriptions were made, while some script notifications could be processed in parallel. My test failed sporadically with the electrum client locking up completely and adding this drop made the tests consistently pass again.
ACKs for top commit:
afilini:
ACK aa0b957818, makes a lot of sense!
Tree-SHA512: b1bbea71fb56a189081b9aa602f768ef50d349a6ad6f3a3f64264259954a541fee85cad84461afeafe1ba17e11950c18fdcadb7c47a5fa1b3ce2fa2ac1cdcdc0
This fixes a supposed deadlock when the reader thread receives a script
subscription notification from the server before it receives a
subscribing response
7493630ed8 Implement timeout for socks connection (Riccardo Casatta)
Pull request description:
To achieve this we have to include a modified socks library, with supports for
timeout
Remove the error `BothSocksAndTimeout` which isn't needed anymore
ACKs for top commit:
afilini:
ACK 7493630ed8
Tree-SHA512: ec1b1eba739bd954ba7811eef603cf60f3ba29d7efcf98a9eadc8dcb9b67a49fce364760718faf7b860e78b7f9eebdc4da65783e7af47792573d32cd6c76ff10
acc05c3666 Handle EOF in the reader thread (Alekos Filini)
Pull request description:
Instead of ignoring empty lines we should return an error, because it means we are at EOF.
Fixes#70 and hopefully also #67
ACKs for top commit:
RCasatta:
ACK acc05c3666
Tree-SHA512: e92b27610c91a419cc0f71ecd77205fdaeed592b50e38c42fd8cde805773f4e9e8eeda75ba14f73002d6ae20a70986f981741e6a69d1a89cf61971c174614951
