fc8ba9de90 Use idiomatic rust for the `raw_call` method (Alekos Filini)
Pull request description:
ACKs for top commit:
danielabrozzoni:
tACK fc8ba9de90
Tree-SHA512: 1b2e92eff78df5b9fe3e6d9121af7c090e27e25aecd39187e6983252b288e0109350603d175ded2cf25365d6a85601ad4da5d8495c9943fe27280c36fe5f0c49
cbda7a22db Revert "Ignore empty lines" (Alekos Filini)
Pull request description:
This reverts commit 0e3e6325e6.
This has been causing issues with tests timing out
ACKs for top commit:
notmandatory:
utACK cbda7a22db
Tree-SHA512: ff683e16e623e71f017a361dc85e12fd7ea23d8ebd0f0616dd543aa3b12645540ae82f7eaab233dd846f5e802540064ce6a56e056d225a79e5347d730a736926
aa0b957818 Client: Drop script subscriptions to free lock (Sebastian Kung)
Pull request description:
This fixes a supposed deadlock when the reader thread receives a script subscription notification from the server before it receives a subscribing response.
I am not 100% sure if this actually fixes a deadlock, but I ran into this in a regtest setup where a bunch of subscriptions were made, while some script notifications could be processed in parallel. My test failed sporadically with the electrum client locking up completely and adding this drop made the tests consistently pass again.
ACKs for top commit:
afilini:
ACK aa0b957818, makes a lot of sense!
Tree-SHA512: b1bbea71fb56a189081b9aa602f768ef50d349a6ad6f3a3f64264259954a541fee85cad84461afeafe1ba17e11950c18fdcadb7c47a5fa1b3ce2fa2ac1cdcdc0
This fixes a supposed deadlock when the reader thread receives a script
subscription notification from the server before it receives a
subscribing response
7493630ed8 Implement timeout for socks connection (Riccardo Casatta)
Pull request description:
To achieve this we have to include a modified socks library, with supports for
timeout
Remove the error `BothSocksAndTimeout` which isn't needed anymore
ACKs for top commit:
afilini:
ACK 7493630ed8
Tree-SHA512: ec1b1eba739bd954ba7811eef603cf60f3ba29d7efcf98a9eadc8dcb9b67a49fce364760718faf7b860e78b7f9eebdc4da65783e7af47792573d32cd6c76ff10
acc05c3666 Handle EOF in the reader thread (Alekos Filini)
Pull request description:
Instead of ignoring empty lines we should return an error, because it means we are at EOF.
Fixes#70 and hopefully also #67
ACKs for top commit:
RCasatta:
ACK acc05c3666
Tree-SHA512: e92b27610c91a419cc0f71ecd77205fdaeed592b50e38c42fd8cde805773f4e9e8eeda75ba14f73002d6ae20a70986f981741e6a69d1a89cf61971c174614951
To achieve this we have to include a modified socks library, with supports for
timeout
Remove the error `BothSocksAndTimeout` which isn't needed anymore
d8e339c4c1 Update build badge to use GitHub badge (dandroid)
Pull request description:
The current build badge using Travis is not working anymore.
This PR uses the badge from GitHub instead.
ACKs for top commit:
afilini:
ACK d8e339c4c1
Tree-SHA512: c08b5dc4b0d6bc0915843d95bfcf84c62317bb8a210f219feca31ce622b2f2b1241ae7987f5c395a980c6b2b3defc48227d43e8491e1adeafadc6e71ecde0db1
3d96644a0f Add raw_call to ElectrumApi (Zoe Faltibà)
Pull request description:
In order to give more flexibility to the users of this library I added a `raw_call` method to the `ElectrumApi` trait that will allow to call any arbitrary electrum API call.
ACKs for top commit:
afilini:
ACK 3d96644a0f
Tree-SHA512: b88ece7bd9ff8121272c3b3528430e9ccb8778661b15cce276c6f67a8797a4dbf4c52a8521191942c21e8b67ebde8187fd75ac49189440b0fbb71274974b4b41
29d77de2f5 doc: s/Satoshi/Bitcoin (zkao)
Pull request description:
Unit was wrong in the docs
ACKs for top commit:
afilini:
ACK 29d77de2f5
Tree-SHA512: a172647cb3c7dc55444f89f9b05832c2b073fc6062c439719bb5c4aecc739be20592ee93111ecee491b0b37e0a0c49f7c3c331a1099bbd6070711d9f5ae0c093
aea9da234b Add `Config::builder` method (志宇)
Pull request description:
The intention is to reduce some confusion on how to manipulate `Config`.
The alternative is to make `Config` fields public.
ACKs for top commit:
afilini:
ACK aea9da234b
Tree-SHA512: 4077e821260c8f6e4bc32a66548e11b1091d384988b392c981102dc3c198a5040831c5feb13b1f7b1a88fd3890d7c44c7516b94f4c2e9cbbc551581c8c72d803
68d2f23306 Upgrade rustls and webpki version (Thomas Eizinger)
Pull request description:
ACKs for top commit:
afilini:
ACK 68d2f23306
Tree-SHA512: 3578954d6629470742fec326525fb34377380c429ff51d5f15e128045161fc6fba4852a22089c2fa9e6bfa7c35ffbaf06eadb0f457fbcb414d15962b9283cd64
Previously, we were logging the retry attempt before we even evaluated
whether or not we are going to retry again. Instead, we now compute
the number of failed attempts and either log and bail from the function
or inform the user that we are going to retry the call.
We also include the name of the failed call and the reason why it failed
in case we are retrying it. Once we have exhausted the the number of
retries, we return all errors anyway so there is no reason to log them.
It is up to the caller to perform error handling.
