signalapp/webrtc
signalapp/webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
e5a93a7201
webrtc/modules/video_capture
History
Per Kjellander a0f5f60c93 Revert "Revert "Make some more targets publicly visible"" 
This reverts commit 55d1809d0d.

Reason for revert: This cl was not the culprit for breaking chrome content/renderer deps.

Original change's description:
> Revert "Make some more targets publicly visible"
> 
> This reverts commit 60d1792562.
> 
> Reason for revert: 
> 
> Breaks Chrome FYI:
> 
> /b/c/b/Linux_Builder/src/buildtools/linux64/gn gen //out/Release --check
>   -> returned 1
> ERROR at //build/split_static_library.gni:12:5: Dependency not allowed.
>     static_library(target_name) {
>     ^----------------------------
> The item //content/renderer:renderer
> can not depend on //third_party/webrtc/media:rtc_internal_video_codecs
> because it is not in //third_party/webrtc/media:rtc_internal_video_codecs's visibility list: [
>   //third_party/webrtc/*
>   //third_party/webrtc_overrides/*
> ]
> 
>  https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.webrtc.fyi%2FLinux_Builder%2F23560%2F%2B%2Frecipes%2Fsteps%2Fgenerate_build_files%2F0%2Fstdout
> 
> Original change's description:
> > Make some more targets publicly visible
> > 
> > To fix build errors introduced by
> > https://webrtc-review.googlesource.com/c/src/+/24140
> > 
> > BUG=webrtc:8254
> > NOTRY=true
> > 
> > Change-Id: I9cdf9cee39735368af78291134dbad70aebb7195
> > Reviewed-on: https://webrtc-review.googlesource.com/38660
> > Commit-Queue: Karl Wiberg <kwiberg@webrtc.org>
> > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> > Cr-Commit-Position: refs/heads/master@{#21552}
> 
> TBR=mbonadei@webrtc.org,kwiberg@webrtc.org
> 
> Change-Id: I475ac382218fa77d33abc595f0773275d715a28e
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: webrtc:8254
> Reviewed-on: https://webrtc-review.googlesource.com/38740
> Reviewed-by: Per Kjellander <perkj@webrtc.org>
> Commit-Queue: Per Kjellander <perkj@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#21554}

TBR=mbonadei@webrtc.org,kwiberg@webrtc.org,perkj@webrtc.org

Change-Id: If8e9b7b1c934ec4b5ed61941c845e62e43bef97e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:8254
Reviewed-on: https://webrtc-review.googlesource.com/38841
Reviewed-by: Per Kjellander <perkj@webrtc.org>
Commit-Queue: Per Kjellander <perkj@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21559}
2018-01-10 15:57:43 +00:00
..
external Add explicit includes of refcountedobject.h where it is used. 2017-10-06 13:00:14 +00:00
linux Stop using LOG macros in favor of RTC_ prefixed macros. 2017-11-09 11:56:32 +00:00
objc Stop using LOG macros in favor of RTC_ prefixed macros. 2017-11-09 11:56:32 +00:00
test Stop using ANDROID macro in favour of WEBRTC_ANDROID. 2017-10-16 11:37:08 +00:00
windows Stop using LOG macros in favor of RTC_ prefixed macros. 2017-11-09 11:56:32 +00:00
BUILD.gn Revert "Revert "Make some more targets publicly visible"" 2018-01-10 15:57:43 +00:00
DEPS Including libyuv headers using fully qualified paths. 2017-12-11 15:51:26 +00:00
device_info_impl.cc Fixes to build WebRTC for Fuchsia 2017-12-12 23:37:28 +00:00
device_info_impl.h Fixing WebRTC after moving from src/webrtc to src/ 2017-09-15 05:02:56 +00:00
OWNERS Moving src/webrtc into src/. 2017-09-15 04:25:06 +00:00
video_capture_config.h Fixing WebRTC after moving from src/webrtc to src/ 2017-09-15 05:02:56 +00:00
video_capture_defines.h Adding NOLINT for typedefs.h and common_types.h 2017-09-15 13:03:51 +00:00
video_capture_factory.cc Stop using ANDROID macro in favour of WEBRTC_ANDROID. 2017-10-16 11:37:08 +00:00
video_capture_factory.h Fixing WebRTC after moving from src/webrtc to src/ 2017-09-15 05:02:56 +00:00
video_capture_impl.cc Including libyuv headers using fully qualified paths. 2017-12-11 15:51:26 +00:00
video_capture_impl.h Fixing WebRTC after moving from src/webrtc to src/ 2017-09-15 05:02:56 +00:00
video_capture.h Move videosinkinterface.h to common_video to solve a circular dep. 2018-01-04 13:19:49 +00:00