signalapp/webrtc
signalapp/webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
cf2aeffdc2
webrtc/modules/video_capture
History
Markus Handell ad5037b4a8 Reland "Refactor the PlatformThread API." 
This reverts commit 793bac569f.

Reason for revert: rare compilation error fixed

Original change's description:
> Revert "Refactor the PlatformThread API."
>
> This reverts commit c89fdd716c.
>
> Reason for revert: Causes rare compilation error on win-libfuzzer-asan trybot.
> See https://ci.chromium.org/p/chromium/builders/try/win-libfuzzer-asan-rel/713745?
>
> Original change's description:
> > Refactor the PlatformThread API.
> >
> > PlatformThread's API is using old style function pointers, causes
> > casting, is unintuitive and forces artificial call sequences, and
> > is additionally possible to misuse in release mode.
> >
> > Fix this by an API face lift:
> > 1. The class is turned into a handle, which can be empty.
> > 2. The only way of getting a non-empty PlatformThread is by calling
> > SpawnJoinable or SpawnDetached, clearly conveying the semantics to the
> > code reader.
> > 3. Handles can be Finalized, which works differently for joinable and
> > detached threads:
> >   a) Handles for detached threads are simply closed where applicable.
> >   b) Joinable threads are joined before handles are closed.
> > 4. The destructor finalizes handles. No explicit call is needed.
> >
> > Fixed: webrtc:12727
> > Change-Id: Id00a0464edf4fc9e552b6a1fbb5d2e1280e88811
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/215075
> > Commit-Queue: Markus Handell <handellm@webrtc.org>
> > Reviewed-by: Harald Alvestrand <hta@webrtc.org>
> > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> > Reviewed-by: Tommi <tommi@webrtc.org>
> > Cr-Commit-Position: refs/heads/master@{#33923}
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> TBR=handellm@webrtc.org
>
> Bug: webrtc:12727
> Change-Id: Ic0146be8866f6dd3ad9c364fb8646650b8e07419
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/217583
> Reviewed-by: Guido Urdaneta <guidou@webrtc.org>
> Reviewed-by: Markus Handell <handellm@webrtc.org>
> Commit-Queue: Guido Urdaneta <guidou@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#33936}

# Not skipping CQ checks because this is a reland.

Bug: webrtc:12727
Change-Id: Ifd6f44eac72fed84474277a1be03eb84d2f4376e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/217881
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Markus Handell <handellm@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#33950}
2021-05-07 14:14:43 +00:00
..
linux Reland "Refactor the PlatformThread API." 2021-05-07 14:14:43 +00:00
test Reland "Migrate modules/desktop_capture and modules/video_capture to webrtc::Mutex." 2020-07-13 12:22:08 +00:00
windows Replace more instances of rtc::RefCountedObject with make_ref_counted. 2021-04-27 17:01:59 +00:00
BUILD.gn Delete unneeded dependencies on the Module abstraction 2020-12-21 09:09:57 +00:00
DEPS Including libyuv headers using fully qualified paths. 2017-12-11 15:51:26 +00:00
device_info_impl.cc Replace RWLockWrapper --> Mutex in DeviceInfoImpl 2020-11-04 10:20:10 +00:00
device_info_impl.h Replace RWLockWrapper --> Mutex in DeviceInfoImpl 2020-11-04 10:20:10 +00:00
OWNERS Remove wildcard ownership for build files. 2020-02-19 14:05:46 +00:00
video_capture_config.h Reformat the WebRTC code base 2018-06-19 14:00:39 +00:00
video_capture_defines.h Include module_common_types.h only where needed 2019-09-24 08:22:38 +00:00
video_capture_factory.cc Delete interface class VideoCaptureExternal 2019-04-09 08:18:20 +00:00
video_capture_factory.h Delete interface class VideoCaptureExternal 2019-04-09 08:18:20 +00:00
video_capture_impl.cc Reland "Migrate modules/desktop_capture and modules/video_capture to webrtc::Mutex." 2020-07-13 12:22:08 +00:00
video_capture_impl.h Reland "Migrate modules/desktop_capture and modules/video_capture to webrtc::Mutex." 2020-07-13 12:22:08 +00:00
video_capture.h Delete unneeded dependencies on the Module abstraction 2020-12-21 09:09:57 +00:00