signalapp/webrtc
signalapp/webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
8f736c0aeb
webrtc/modules/pacing
History
Mirko Bonadei 317a1f09ed Use std::make_unique instead of absl::make_unique. 
WebRTC is now using C++14 so there is no need to use the Abseil version
of std::make_unique.

This CL has been created with the following steps:

git grep -l absl::make_unique | sort | uniq > /tmp/make_unique.txt
git grep -l absl::WrapUnique | sort | uniq > /tmp/wrap_unique.txt
git grep -l "#include <memory>" | sort | uniq > /tmp/memory.txt

diff --new-line-format="" --unchanged-line-format="" \
  /tmp/make_unique.txt /tmp/wrap_unique.txt | sort | \
  uniq > /tmp/only_make_unique.txt
diff --new-line-format="" --unchanged-line-format="" \
  /tmp/only_make_unique.txt /tmp/memory.txt | \
  xargs grep -l "absl/memory" > /tmp/add-memory.txt

git grep -l "\babsl::make_unique\b" | \
  xargs sed -i "s/\babsl::make_unique\b/std::make_unique/g"

git checkout PRESUBMIT.py abseil-in-webrtc.md

cat /tmp/add-memory.txt | \
  xargs sed -i \
  's/#include "absl\/memory\/memory.h"/#include <memory>/g'
git cl format
# Manual fix order of the new inserted #include <memory>

cat /tmp/only_make_unique | xargs grep -l "#include <memory>" | \
  xargs sed -i '/#include "absl\/memory\/memory.h"/d'

git ls-files | grep BUILD.gn | \
  xargs sed -i '/\/\/third_party\/abseil-cpp\/absl\/memory/d'

python tools_webrtc/gn_check_autofix.py \
  -m tryserver.webrtc -b linux_rel

# Repead the gn_check_autofix step for other platforms

git ls-files | grep BUILD.gn | \
  xargs sed -i 's/absl\/memory:memory/absl\/memory/g'
git cl format

Bug: webrtc:10945
Change-Id: I3fe28ea80f4dd3ba3cf28effd151d5e1f19aff89
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/153221
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Alessio Bazzica <alessiob@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29209}
2019-09-17 15:47:29 +00:00
..
mock Removes deprecated InsertPacket/TimeToSendPacket/TimeToSendPadding 2019-08-26 11:55:55 +00:00
bitrate_prober_unittest.cc Format almost everything. 2019-07-08 13:45:15 +00:00
bitrate_prober.cc Stop using rtc_event.h forward header 2019-09-11 08:20:29 +00:00
bitrate_prober.h Format almost everything. 2019-07-08 13:45:15 +00:00
BUILD.gn Use std::make_unique instead of absl::make_unique. 2019-09-17 15:47:29 +00:00
DEPS Replace field trials with WebRtcKeyValueConfig in PacedSender 2019-02-22 13:08:18 +00:00
interval_budget_unittest.cc Make interval budget use ratio instead of percent 2019-06-07 08:53:57 +00:00
interval_budget.cc Fix potential signed overflow in IntervalBudget::set_target_rate_kbps 2019-06-18 15:42:54 +00:00
interval_budget.h Fix potential signed overflow in IntervalBudget::set_target_rate_kbps 2019-06-18 15:42:54 +00:00
OWNERS Adds srte@webrtc.org as modules/pacing/ OWNER. 2018-06-29 15:25:24 +00:00
paced_sender_unittest.cc Use std::make_unique instead of absl::make_unique. 2019-09-17 15:47:29 +00:00
paced_sender.cc Remove lock for process thread pointer from PacedSender. 2019-08-29 17:08:24 +00:00
paced_sender.h Remove lock for process thread pointer from PacedSender. 2019-08-29 17:08:24 +00:00
pacing_controller_unittest.cc Use std::make_unique instead of absl::make_unique. 2019-09-17 15:47:29 +00:00
pacing_controller.cc Use std::make_unique instead of absl::make_unique. 2019-09-17 15:47:29 +00:00
pacing_controller.h Revert "Simplify pacer queue" 2019-09-01 12:59:06 +00:00
packet_router_unittest.cc Use std::make_unique instead of absl::make_unique. 2019-09-17 15:47:29 +00:00
packet_router.cc Make NetworkStateEstimator injectable in RemoteBitrateEstimator 2019-09-10 18:47:36 +00:00
packet_router.h Make NetworkStateEstimator injectable in RemoteBitrateEstimator 2019-09-10 18:47:36 +00:00
round_robin_packet_queue.cc Revert "Simplify pacer queue" 2019-09-01 12:59:06 +00:00
round_robin_packet_queue.h Revert "Simplify pacer queue" 2019-09-01 12:59:06 +00:00
rtp_packet_pacer.h Add RtpPacketPacer interface for pacer control 2019-07-29 15:37:39 +00:00