8e1343aeda
The plugin transport parameters (a=x-opaque: lines) relate to how to create and set up a plugin transport. When SDP bundle is used, the x-opaque line needs to be copied into the bundled m= section. This means x-opaque can appear on a section even if the offerer does not intend to use the transport for the media described by that section. Consequently, the answerer cannot currently tell whether the caller is offering an alternate transport for media, data, or both. This change adds an a=x-alt-protocol: line to SDP. The value following this line matches the <protocol> part of the x-opaque:<protocol>:<params> line. However, alt-protocol is not bundled--it only ever applies to the m= section that contains the line. This allows the offerer to express which m= sections should actually use an alternate transport, even in the case of bundle. Note that this is still limited by the available configuration options: datagram transport can be used for media (audio + video) and/or data. It is still not possible to use it for audio but not video, or vice versa. PeerConnection places an alt-protocol line in each media (audio/video) m= section if it is configured to use a datagram transport for media. It places an alt-protocol line in each data m= section if it is configured to use a datagram transport for data channels. PeerConnection leaves alt-protocol in media (audio/video) m= sections of the answer if it is configured to use a datagram transport for media, and in data m= sections of the answer if it is configured to use a datagram transport for data channels. JsepTransport now negotiates use of the datagram transport independently for media and data channels. It only uses it for media if the m= sections for bundled audio/video have an alt-protocol line matching the x-opaque protocol, and only uses it for data channels if a bundled m= section for data has an alt-protocol line matching the x-opaque protocol. Bug: webrtc:9719 Change-Id: I773e4fc10c57d815afcd76a2a74da38dd0c52b3b Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/154763 Reviewed-by: Steve Anton <steveanton@webrtc.org> Reviewed-by: Seth Hampson <shampson@webrtc.org> Commit-Queue: Bjorn Mellem <mellem@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29351} |
||
|---|---|---|
| .. | ||
| audio | ||
| audio_codecs | ||
| call | ||
| crypto | ||
| rtc_event_log | ||
| stats | ||
| task_queue | ||
| test | ||
| transport | ||
| units | ||
| video | ||
| video_codecs | ||
| array_view_unittest.cc | ||
| array_view.h | ||
| async_resolver_factory.h | ||
| audio_options.cc | ||
| audio_options.h | ||
| BUILD.gn | ||
| candidate.cc | ||
| candidate.h | ||
| congestion_control_interface.h | ||
| create_peerconnection_factory.cc | ||
| create_peerconnection_factory.h | ||
| crypto_params.h | ||
| data_channel_interface.cc | ||
| data_channel_interface.h | ||
| data_channel_transport_interface.h | ||
| datagram_transport_interface.h | ||
| DEPS | ||
| DESIGN.md | ||
| dtls_transport_interface.cc | ||
| dtls_transport_interface.h | ||
| dtmf_sender_interface.h | ||
| fec_controller_override.h | ||
| fec_controller.h | ||
| function_view_unittest.cc | ||
| function_view.h | ||
| ice_transport_factory.cc | ||
| ice_transport_factory.h | ||
| ice_transport_interface.h | ||
| jsep_ice_candidate.cc | ||
| jsep_ice_candidate.h | ||
| jsep_session_description.h | ||
| jsep.cc | ||
| jsep.h | ||
| media_stream_interface.cc | ||
| media_stream_interface.h | ||
| media_stream_proxy.h | ||
| media_stream_track_proxy.h | ||
| media_transport_config.h | ||
| media_transport_interface.h | ||
| media_types.cc | ||
| media_types.h | ||
| network_state_predictor.h | ||
| notifier.h | ||
| OWNERS | ||
| packet_socket_factory.h | ||
| peer_connection_factory_proxy.h | ||
| peer_connection_interface.cc | ||
| peer_connection_interface.h | ||
| peer_connection_proxy.h | ||
| proxy.cc | ||
| proxy.h | ||
| README.md | ||
| ref_counted_base.h | ||
| rtc_error_unittest.cc | ||
| rtc_error.cc | ||
| rtc_error.h | ||
| rtc_event_log_output_file_unittest.cc | ||
| rtc_event_log_output_file.cc | ||
| rtc_event_log_output_file.h | ||
| rtc_event_log_output.h | ||
| rtp_headers.cc | ||
| rtp_headers.h | ||
| rtp_packet_info_unittest.cc | ||
| rtp_packet_info.cc | ||
| rtp_packet_info.h | ||
| rtp_packet_infos_unittest.cc | ||
| rtp_packet_infos.h | ||
| rtp_parameters_unittest.cc | ||
| rtp_parameters.cc | ||
| rtp_parameters.h | ||
| rtp_receiver_interface.cc | ||
| rtp_receiver_interface.h | ||
| rtp_sender_interface.cc | ||
| rtp_sender_interface.h | ||
| rtp_transceiver_interface.cc | ||
| rtp_transceiver_interface.h | ||
| scoped_refptr.h | ||
| sctp_transport_interface.cc | ||
| sctp_transport_interface.h | ||
| set_remote_description_observer_interface.h | ||
| stats_types.cc | ||
| stats_types.h | ||
| turn_customizer.h | ||
| uma_metrics.h | ||
| video_track_source_proxy.h | ||
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.