signalapp/webrtc
signalapp/webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
7f24fb9c1e
webrtc/test/fuzzers
History
Sam Zackrisson 421c859351 Remove crit_render_ lock from webrtc::GainControlImpl 
The lock is unnecessary and potentially unsafe:
1) All gain_control accesses in AudioProcessingImpl happen - and are intended to happen - while holding the crit_capture_ lock, and all external API calls take the same lock once inside GainControlImpl.
2) If ProcessCaptureStreamLocked (locked by crit_capture) calls a gain_control function that takes crit_render, the mandated locking order (render before capture) is violated and we might get a deadlock with the render thread.

Bug: b/123456404
Change-Id: Id7a888827e347e5e1d50e2f87d90e8b68f52b7b8
Reviewed-on: https://webrtc-review.googlesource.com/c/122087
Reviewed-by: Alessio Bazzica <alessiob@webrtc.org>
Commit-Queue: Sam Zackrisson <saza@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#26637}
2019-02-11 14:14:40 +00:00
..
configs/replay_packet_fuzzer Add rtp_generator utility to rtc_tools. 2019-02-01 18:36:19 +00:00
corpora Add the multicast DNS message format. 2018-08-31 00:02:44 +00:00
agc_fuzzer.cc Remove crit_render_ lock from webrtc::GainControlImpl 2019-02-11 14:14:40 +00:00
audio_decoder_fuzzer.cc Cap the number of fuzzed decoder packets to 200 2018-07-17 09:14:45 +00:00
audio_decoder_fuzzer.h Delete root header file typedef.h. 2018-07-25 14:59:26 +00:00
audio_decoder_ilbc_fuzzer.cc Update fuzzer max input length handling 2018-10-25 12:19:18 +00:00
audio_decoder_isac_fuzzer.cc Update fuzzer max input length handling 2018-10-25 12:19:18 +00:00
audio_decoder_isac_incoming_packet_fuzzer.cc Update fuzzer max input length handling 2018-10-25 12:19:18 +00:00
audio_decoder_isacfix_fuzzer.cc Update fuzzer max input length handling 2018-10-25 12:19:18 +00:00
audio_decoder_opus_fuzzer.cc Fixing WebRTC after moving from src/webrtc to src/ 2017-09-15 05:02:56 +00:00
audio_decoder_opus_redundant_fuzzer.cc Fixing WebRTC after moving from src/webrtc to src/ 2017-09-15 05:02:56 +00:00
audio_encoder_opus_fuzzer.cc Create a fuzzer for the Opus encoder 2018-05-09 13:35:23 +00:00
audio_processing_configs_fuzzer.cc AEC3: Remove remaining kill-switches 2019-01-29 10:31:45 +00:00
audio_processing_fuzzer_helper.cc Remove deprecated AudioProcessing::GetStatistics function 2018-11-01 11:21:15 +00:00
audio_processing_fuzzer_helper.h AEC-m and AEC-2 fuzzing. 2018-01-16 13:15:04 +00:00
BUILD.gn Remove rtc_base/scoped_ref_ptr.h. 2019-01-25 20:29:58 +00:00
comfort_noise_decoder_fuzzer.cc Update fuzzer max input length handling 2018-10-25 12:19:18 +00:00
congestion_controller_feedback_fuzzer.cc Fix potential overflow in congestion controller fuzzer. 2017-11-23 14:18:38 +00:00
DEPS Move remaining traces of VoiceEngine 2018-01-17 13:27:47 +00:00
flexfec_header_reader_fuzzer.cc Remove rtc_base/scoped_ref_ptr.h. 2019-01-25 20:29:58 +00:00
flexfec_receiver_fuzzer.cc Update fuzzer max input length handling 2018-10-25 12:19:18 +00:00
flexfec_sender_fuzzer.cc Update fuzzer max input length handling 2018-10-25 12:19:18 +00:00
forward_error_correction_fuzzer.cc Remove rtc_base/scoped_ref_ptr.h. 2019-01-25 20:29:58 +00:00
frame_buffer2_fuzzer.cc Delete method EncodedFrame::GetBitstream, part 1 2018-11-28 14:52:32 +00:00
fuzz_data_helper.cc Create a fuzzer for ComfortNoiseDecoder 2017-12-07 08:53:37 +00:00
fuzz_data_helper.h Update packet_buffer_fuzzer to fuzz full packets. 2018-06-01 10:00:36 +00:00
h264_bitstream_parser_fuzzer.cc Fixing WebRTC after moving from src/webrtc to src/ 2017-09-15 05:02:56 +00:00
h264_depacketizer_fuzzer.cc Fixing WebRTC after moving from src/webrtc to src/ 2017-09-15 05:02:56 +00:00
mdns_parser_fuzzer.cc Improve the documentation of MdnsResponderInterface and rename MDns.* 2018-11-01 02:39:59 +00:00
neteq_rtp_fuzzer.cc Fix RTC_CHECK in neteq_rtp_fuzzer 2019-01-14 12:24:02 +00:00
neteq_signal_fuzzer.cc Delete method DecoderDatabase::RegisterPayload(...NetEqDecoder...) 2019-01-11 07:39:45 +00:00
OWNERS Add benwright@webrtc.org to test/fuzzers/OWNERS. 2019-01-14 17:45:20 +00:00
packet_buffer_fuzzer.cc Update fuzzer max input length handling 2018-10-25 12:19:18 +00:00
pseudotcp_parser_fuzzer.cc (4) Rename files to snake_case: update BUILD.gn, include paths, header guards, and DEPS entries 2019-01-11 17:11:39 +00:00
residual_echo_detector_fuzzer.cc (4) Rename files to snake_case: update BUILD.gn, include paths, header guards, and DEPS entries 2019-01-11 17:11:39 +00:00
rtcp_receiver_fuzzer.cc Remove the audio/video split for the RTCP report intervals. 2018-11-22 01:39:41 +00:00
rtp_frame_reference_finder_fuzzer.cc Calculate min and max receive timestamps for packets in a video frame 2018-12-07 16:22:34 +00:00
rtp_header_fuzzer.cc Fixing WebRTC after moving from src/webrtc to src/ 2017-09-15 05:02:56 +00:00
rtp_packet_fuzzer.cc Change HdrMetadataExtension to ColorSpaceExtension 2018-11-27 14:05:31 +00:00
sdp_parser_fuzzer.cc (4) Rename files to snake_case: update BUILD.gn, include paths, header guards, and DEPS entries 2019-01-11 17:11:39 +00:00
stun_parser_fuzzer.cc Fixing WebRTC after moving from src/webrtc to src/ 2017-09-15 05:02:56 +00:00
stun_validator_fuzzer.cc Fixing WebRTC after moving from src/webrtc to src/ 2017-09-15 05:02:56 +00:00
transport_feedback_packet_loss_tracker_fuzzer.cc Move remaining traces of VoiceEngine 2018-01-17 13:27:47 +00:00
turn_unwrap_fuzzer.cc (4) Rename files to snake_case: update BUILD.gn, include paths, header guards, and DEPS entries 2019-01-11 17:11:39 +00:00
ulpfec_generator_fuzzer.cc In ULP FEC fuzzer test, make sure sequence number is not the same as previous sequence number. 2018-07-02 15:51:10 +00:00
ulpfec_header_reader_fuzzer.cc Remove rtc_base/scoped_ref_ptr.h. 2019-01-25 20:29:58 +00:00
ulpfec_receiver_fuzzer.cc Update fuzzer max input length handling 2018-10-25 12:19:18 +00:00
url_decode_fuzzer.cc (4) Rename files to snake_case: update BUILD.gn, include paths, header guards, and DEPS entries 2019-01-11 17:11:39 +00:00
vp8_depacketizer_fuzzer.cc Fixing WebRTC after moving from src/webrtc to src/ 2017-09-15 05:02:56 +00:00
vp8_qp_parser_fuzzer.cc Fixing WebRTC after moving from src/webrtc to src/ 2017-09-15 05:02:56 +00:00
vp9_depacketizer_fuzzer.cc Fixing WebRTC after moving from src/webrtc to src/ 2017-09-15 05:02:56 +00:00
vp9_qp_parser_fuzzer.cc Fixing WebRTC after moving from src/webrtc to src/ 2017-09-15 05:02:56 +00:00
webrtc_fuzzer_main.cc Reformat the WebRTC code base 2018-06-19 14:00:39 +00:00