signalapp/webrtc
signalapp/webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
63673fe2cc
webrtc/api/task_queue
History
Tommi 6866dc7806 Reland "Make sure that "current" rtc::Thread instances are always current for TaskQueueBase." 
This reverts commit 28685dc08c.

Reason for revert: Speculative reland after looking into downstream
failures. It's possible that carryover state from unrelated tests
running in parallel was causing failures.

Original change's description:
> Revert "Make sure that "current" rtc::Thread instances are always current for TaskQueueBase."
> 
> This reverts commit 46b3bc6c24.
> 
> Reason for revert: Speculative revert. Breaks downstream project
> 
> Original change's description:
> > Make sure that "current" rtc::Thread instances are always current for TaskQueueBase.
> > 
> > This is a necessary part of fulfilling the TaskQueueBase
> > interface. If a thread does not register as the current TQ, yet offers
> > the TQ interface, TQ 'current' checks will not work as expected and
> > code that relies them (TaskQueueBase::Current() and IsCurrent())
> > will run in unexpected ways.
> > 
> > Bug: webrtc:11572
> > Change-Id: Iab747bc474e74e6ce4f9e914cfd5b0578b19d19c
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/175080
> > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> > Commit-Queue: Tommi <tommi@webrtc.org>
> > Cr-Commit-Position: refs/heads/master@{#31254}
> 
> TBR=mbonadei@webrtc.org,tommi@webrtc.org
> 
> Change-Id: I69ff3355f0ec447b25604bd95fdacbdb4d4f3f27
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: webrtc:11572
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/175104
> Reviewed-by: Artem Titov <titovartem@webrtc.org>
> Commit-Queue: Artem Titov <titovartem@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#31259}

TBR=mbonadei@webrtc.org,tommi@webrtc.org,titovartem@webrtc.org

# Not skipping CQ checks because this is a reland.

Bug: webrtc:11572
Change-Id: I00c82d99af8e05851769e09cb682b5b73895a6f3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/175133
Reviewed-by: Tommi <tommi@webrtc.org>
Reviewed-by: Artem Titov <titovartem@webrtc.org>
Commit-Queue: Tommi <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31273}
2020-05-15 10:20:03 +00:00
..
BUILD.gn Reformat GN files. 2020-01-21 12:13:11 +00:00
default_task_queue_factory_gcd.cc Migrate gcd task queue implementation to TaskQueueBase interface 2019-02-20 17:08:53 +00:00
default_task_queue_factory_libevent.cc Migrate libevent task queue implementation to TaskQueueBase interface 2019-02-12 10:58:36 +00:00
default_task_queue_factory_stdlib.cc Migrate stdlib task queue to TaskQueueBase interface 2019-02-21 14:36:07 +00:00
default_task_queue_factory_unittest.cc Test default TaskQueue implementation via TaskQueueBase interface 2019-02-26 14:01:45 +00:00
default_task_queue_factory_win.cc Migrate win task queue to TaskQueueBase interface 2019-02-21 09:33:42 +00:00
default_task_queue_factory.h Introduce global task queue factory. 2019-01-18 11:25:15 +00:00
DEPS Migrate RepeatingTask to take raw pointer to TaskQueueBase instead of TaskQueue 2019-03-06 18:44:35 +00:00
queued_task.h Publish rtc::QueuedTask in api as webrtc::QueuedTask 2019-01-14 14:48:12 +00:00
task_queue_base.cc Migrate gcd task queue implementation to TaskQueueBase interface 2019-02-20 17:08:53 +00:00
task_queue_base.h RTC_EXPORT missing symbols for Chromium's component build. 2019-11-12 21:50:01 +00:00
task_queue_factory.h Drop support for link-time injection of the rtc::TaskQueue::Impl 2019-02-27 10:07:34 +00:00
task_queue_test.cc Reland "Make sure that "current" rtc::Thread instances are always current for TaskQueueBase." 2020-05-15 10:20:03 +00:00
task_queue_test.h Use task queue factory factory as parameter for TaskQueueTest 2019-02-07 11:00:17 +00:00