webrtc/modules/rtp_rtcp
Sebastian Jansson a72d583271 Fix for potential out of bounds reading in rtcp::RemoteEstimate parser.
packet_size() includes the size of padding, this means that the size
check might incorrectly not trigger even if the payload is empty. In
turn this means that the ReadBigEndian call might read out of bounds
memory.

Refactored the code to reuse the App parsing code more, eliminating
the risk of this particular kind of error.

Bug: chromium:987507
Change-Id: Id8f3e292c3d30460d3cdb551f0a45070fdf8f022
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/146716
Reviewed-by: Stefan Holmer <stefan@webrtc.org>
Commit-Queue: Sebastian Jansson <srte@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28680}
2019-07-25 10:54:05 +00:00
..
include Move RtpPacketSender and merge it with RtpPacketPacer. 2019-07-24 13:28:21 +00:00
mocks Adds remote estimate RTCP packet. 2019-07-24 10:17:26 +00:00
source Fix for potential out of bounds reading in rtcp::RemoteEstimate parser. 2019-07-25 10:54:05 +00:00
test/testFec Revert "Refactor FEC code to use COW buffers" 2019-07-11 19:55:28 +00:00
BUILD.gn Move RtpPacketSender and merge it with RtpPacketPacer. 2019-07-24 13:28:21 +00:00
DEPS Replace field trials with WebRtcKeyValueConfig in RtpRtcpModule 2019-02-21 14:25:34 +00:00
OWNERS Add sprang@ as owner in modules/rtp_rtcp 2019-07-24 17:06:36 +00:00