signalapp/webrtc
signalapp/webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
35fa280229
webrtc/api/audio_codecs/isac
History
Karl Wiberg 801500cf99 Audio encoder tests: Create audio encoders the new way 
Specifically, don't expect the ACM to be able to create encoders; we
have to give it an encoder that we make ourselves.

The new way of creating encoders used a 32 kbit/s bitrate
unconditionally for iSAC; I had to change it to 32 kbit/s for 16 kHz
and 56 kbit/s for 32 kHz, which is what the old way of creating
encoders has used since forever.

I also had to change some test expectations on Opus, because the new
way defaults to 32 kbit/s for mono and 64 kbit/s for stereo (which I
believe to be correct), while the old way defaults to 64 kbit/s in
both cases.

Bug: webrtc:8396
Change-Id: I3aab944175a8e27f4c63380e822b27e839bba7f2
Reviewed-on: https://webrtc-review.googlesource.com/94540
Reviewed-by: Ivo Creusen <ivoc@webrtc.org>
Commit-Queue: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24375}
2018-08-22 07:48:55 +00:00
..
audio_decoder_isac_fix.cc Use absl::make_unique and absl::WrapUnique directly 2018-07-05 10:59:49 +00:00
audio_decoder_isac_fix.h Replace rtc::Optional with absl::optional in api 2018-06-21 12:50:03 +00:00
audio_decoder_isac_float.cc Use absl::make_unique and absl::WrapUnique directly 2018-07-05 10:59:49 +00:00
audio_decoder_isac_float.h Replace rtc::Optional with absl::optional in api 2018-06-21 12:50:03 +00:00
audio_decoder_isac.h Make iSAC build targets and headers that automatically pick fix or float 2017-10-10 14:01:28 +00:00
audio_encoder_isac_fix.cc Use absl::make_unique and absl::WrapUnique directly 2018-07-05 10:59:49 +00:00
audio_encoder_isac_fix.h Replace rtc::Optional with absl::optional in api 2018-06-21 12:50:03 +00:00
audio_encoder_isac_float.cc Audio encoder tests: Create audio encoders the new way 2018-08-22 07:48:55 +00:00
audio_encoder_isac_float.h Audio encoder tests: Create audio encoders the new way 2018-08-22 07:48:55 +00:00
audio_encoder_isac.h Make iSAC build targets and headers that automatically pick fix or float 2017-10-10 14:01:28 +00:00
BUILD.gn Use absl::make_unique and absl::WrapUnique directly 2018-07-05 10:59:49 +00:00