4c619d7b0f
using
find test -name "*.h" -o -name "*.cc" | xargs tools_webrtc/iwyu/apply_include_cleaner.py
followed by
git cl format
and
tools_webrtc/gn_check_autofix.py -C out/Default
followed by running clang-tidy with
tools/clang/scripts/build_clang_tools_extra.py \
--fetch out/Default clang-tidy clang-apply-replacements
ninja -C out/Default
gn gen out/Default --export-compile-commands
cd out/Default
tools/clang/third_party/llvm/clang-tools-extra/clang-tidy/tool/run-clang-tidy.py -p . \
-clang-tidy-binary out/Default/tools/clang/third_party/llvm/build/bin/clang-tidy \
-clang-apply-replacements-binary \
out/Default/tools/clang/third_party/llvm/build/bin/clang-apply-replacements \
-checks='-*,modernize-deprecated-headers' \
-fix
to move from C style standard headers to C++ style variants followed
another round of IWYU (which brought back stdio.h), format and gn_check_autofix.
This was followed by a manual pass removing C style headers from C++ headers when the corresponding C++-style header was in included in the .cc file. IWYU after thought brought some instances of stdio.h back *again*.
Bug: webrtc:42226242
Change-Id: I3ec5ee4bd3d4f81e25f5dfca3764bb85c2cad99b
No-Iwyu: false positive of jpeg include
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/396321
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Philipp Hancke <phancke@meta.com>
Cr-Commit-Position: refs/heads/main@{#44937}
76 lines
2.3 KiB
C++
76 lines
2.3 KiB
C++
/*
|
|
* Copyright (c) 2018 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#ifndef TEST_FUNCTION_AUDIO_DECODER_FACTORY_H_
|
|
#define TEST_FUNCTION_AUDIO_DECODER_FACTORY_H_
|
|
|
|
#include <functional>
|
|
#include <memory>
|
|
#include <optional>
|
|
#include <utility>
|
|
#include <vector>
|
|
|
|
#include "api/audio_codecs/audio_codec_pair_id.h"
|
|
#include "api/audio_codecs/audio_decoder.h"
|
|
#include "api/audio_codecs/audio_decoder_factory.h"
|
|
#include "api/audio_codecs/audio_format.h"
|
|
#include "api/environment/environment.h"
|
|
#include "rtc_base/checks.h"
|
|
|
|
namespace webrtc {
|
|
namespace test {
|
|
|
|
// A decoder factory producing decoders by calling a supplied create function.
|
|
class FunctionAudioDecoderFactory : public AudioDecoderFactory {
|
|
public:
|
|
explicit FunctionAudioDecoderFactory(
|
|
std::function<std::unique_ptr<AudioDecoder>()> create)
|
|
: create_([create](const Environment&,
|
|
const SdpAudioFormat&,
|
|
std::optional<AudioCodecPairId> codec_pair_id) {
|
|
return create();
|
|
}) {}
|
|
explicit FunctionAudioDecoderFactory(
|
|
std::function<std::unique_ptr<AudioDecoder>(
|
|
const Environment&,
|
|
const SdpAudioFormat&,
|
|
std::optional<AudioCodecPairId> codec_pair_id)> create)
|
|
: create_(std::move(create)) {}
|
|
|
|
// Unused by tests.
|
|
std::vector<AudioCodecSpec> GetSupportedDecoders() override {
|
|
RTC_DCHECK_NOTREACHED();
|
|
return {};
|
|
}
|
|
|
|
bool IsSupportedDecoder(const SdpAudioFormat& format) override {
|
|
return true;
|
|
}
|
|
|
|
std::unique_ptr<AudioDecoder> Create(
|
|
const Environment& env,
|
|
const SdpAudioFormat& format,
|
|
std::optional<AudioCodecPairId> codec_pair_id) override {
|
|
return create_(env, format, codec_pair_id);
|
|
}
|
|
|
|
private:
|
|
const std::function<std::unique_ptr<AudioDecoder>(
|
|
const Environment&,
|
|
const SdpAudioFormat&,
|
|
std::optional<AudioCodecPairId> codec_pair_id)>
|
|
create_;
|
|
};
|
|
|
|
} // namespace test
|
|
} // namespace webrtc
|
|
|
|
#endif // TEST_FUNCTION_AUDIO_DECODER_FACTORY_H_
|