4c619d7b0f
using
find test -name "*.h" -o -name "*.cc" | xargs tools_webrtc/iwyu/apply_include_cleaner.py
followed by
git cl format
and
tools_webrtc/gn_check_autofix.py -C out/Default
followed by running clang-tidy with
tools/clang/scripts/build_clang_tools_extra.py \
--fetch out/Default clang-tidy clang-apply-replacements
ninja -C out/Default
gn gen out/Default --export-compile-commands
cd out/Default
tools/clang/third_party/llvm/clang-tools-extra/clang-tidy/tool/run-clang-tidy.py -p . \
-clang-tidy-binary out/Default/tools/clang/third_party/llvm/build/bin/clang-tidy \
-clang-apply-replacements-binary \
out/Default/tools/clang/third_party/llvm/build/bin/clang-apply-replacements \
-checks='-*,modernize-deprecated-headers' \
-fix
to move from C style standard headers to C++ style variants followed
another round of IWYU (which brought back stdio.h), format and gn_check_autofix.
This was followed by a manual pass removing C style headers from C++ headers when the corresponding C++-style header was in included in the .cc file. IWYU after thought brought some instances of stdio.h back *again*.
Bug: webrtc:42226242
Change-Id: I3ec5ee4bd3d4f81e25f5dfca3764bb85c2cad99b
No-Iwyu: false positive of jpeg include
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/396321
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Philipp Hancke <phancke@meta.com>
Cr-Commit-Position: refs/heads/main@{#44937}
53 lines
1.6 KiB
C++
53 lines
1.6 KiB
C++
/*
|
|
* Copyright (c) 2013 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
#ifndef TEST_FRAME_UTILS_H_
|
|
#define TEST_FRAME_UTILS_H_
|
|
|
|
#include <cstdint>
|
|
#include <cstdio>
|
|
|
|
#include "api/scoped_refptr.h"
|
|
#include "api/video/nv12_buffer.h"
|
|
|
|
namespace webrtc {
|
|
class I420Buffer;
|
|
class VideoFrame;
|
|
class VideoFrameBuffer;
|
|
namespace test {
|
|
|
|
bool EqualPlane(const uint8_t* data1,
|
|
const uint8_t* data2,
|
|
int stride1,
|
|
int stride2,
|
|
int width,
|
|
int height);
|
|
|
|
static inline bool EqualPlane(const uint8_t* data1,
|
|
const uint8_t* data2,
|
|
int stride,
|
|
int width,
|
|
int height) {
|
|
return EqualPlane(data1, data2, stride, stride, width, height);
|
|
}
|
|
|
|
bool FramesEqual(const webrtc::VideoFrame& f1, const webrtc::VideoFrame& f2);
|
|
|
|
bool FrameBufsEqual(const scoped_refptr<webrtc::VideoFrameBuffer>& f1,
|
|
const scoped_refptr<webrtc::VideoFrameBuffer>& f2);
|
|
|
|
scoped_refptr<I420Buffer> ReadI420Buffer(int width, int height, FILE*);
|
|
|
|
scoped_refptr<NV12Buffer> ReadNV12Buffer(int width, int height, FILE*);
|
|
|
|
} // namespace test
|
|
} // namespace webrtc
|
|
|
|
#endif // TEST_FRAME_UTILS_H_
|