using
find test -name "*.h" -o -name "*.cc" | xargs tools_webrtc/iwyu/apply_include_cleaner.py
followed by
git cl format
and
tools_webrtc/gn_check_autofix.py -C out/Default
followed by running clang-tidy with
tools/clang/scripts/build_clang_tools_extra.py \
--fetch out/Default clang-tidy clang-apply-replacements
ninja -C out/Default
gn gen out/Default --export-compile-commands
cd out/Default
tools/clang/third_party/llvm/clang-tools-extra/clang-tidy/tool/run-clang-tidy.py -p . \
-clang-tidy-binary out/Default/tools/clang/third_party/llvm/build/bin/clang-tidy \
-clang-apply-replacements-binary \
out/Default/tools/clang/third_party/llvm/build/bin/clang-apply-replacements \
-checks='-*,modernize-deprecated-headers' \
-fix
to move from C style standard headers to C++ style variants followed
another round of IWYU (which brought back stdio.h), format and gn_check_autofix.
This was followed by a manual pass removing C style headers from C++ headers when the corresponding C++-style header was in included in the .cc file. IWYU after thought brought some instances of stdio.h back *again*.
Bug: webrtc:42226242
Change-Id: I3ec5ee4bd3d4f81e25f5dfca3764bb85c2cad99b
No-Iwyu: false positive of jpeg include
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/396321
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Philipp Hancke <phancke@meta.com>
Cr-Commit-Position: refs/heads/main@{#44937}
65 lines
1.8 KiB
C++
65 lines
1.8 KiB
C++
/*
|
|
* Copyright (c) 2019 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
#include "test/frame_forwarder.h"
|
|
|
|
#include "api/video/video_frame.h"
|
|
#include "api/video/video_sink_interface.h"
|
|
#include "api/video/video_source_interface.h"
|
|
#include "rtc_base/checks.h"
|
|
#include "rtc_base/synchronization/mutex.h"
|
|
|
|
namespace webrtc {
|
|
namespace test {
|
|
|
|
FrameForwarder::FrameForwarder() : sink_(nullptr) {}
|
|
FrameForwarder::~FrameForwarder() {}
|
|
|
|
void FrameForwarder::IncomingCapturedFrame(const VideoFrame& video_frame) {
|
|
MutexLock lock(&mutex_);
|
|
if (sink_)
|
|
sink_->OnFrame(video_frame);
|
|
}
|
|
|
|
void FrameForwarder::AddOrUpdateSink(VideoSinkInterface<VideoFrame>* sink,
|
|
const VideoSinkWants& wants) {
|
|
MutexLock lock(&mutex_);
|
|
AddOrUpdateSinkLocked(sink, wants);
|
|
}
|
|
|
|
void FrameForwarder::AddOrUpdateSinkLocked(VideoSinkInterface<VideoFrame>* sink,
|
|
const VideoSinkWants& wants) {
|
|
RTC_DCHECK(!sink_ || sink_ == sink);
|
|
sink_ = sink;
|
|
sink_wants_ = wants;
|
|
}
|
|
|
|
void FrameForwarder::RemoveSink(VideoSinkInterface<VideoFrame>* sink) {
|
|
MutexLock lock(&mutex_);
|
|
RTC_DCHECK_EQ(sink, sink_);
|
|
sink_ = nullptr;
|
|
}
|
|
|
|
VideoSinkWants FrameForwarder::sink_wants() const {
|
|
MutexLock lock(&mutex_);
|
|
return sink_wants_;
|
|
}
|
|
|
|
VideoSinkWants FrameForwarder::sink_wants_locked() const {
|
|
return sink_wants_;
|
|
}
|
|
|
|
bool FrameForwarder::has_sinks() const {
|
|
MutexLock lock(&mutex_);
|
|
return sink_ != nullptr;
|
|
}
|
|
|
|
} // namespace test
|
|
} // namespace webrtc
|