4c619d7b0f
using
find test -name "*.h" -o -name "*.cc" | xargs tools_webrtc/iwyu/apply_include_cleaner.py
followed by
git cl format
and
tools_webrtc/gn_check_autofix.py -C out/Default
followed by running clang-tidy with
tools/clang/scripts/build_clang_tools_extra.py \
--fetch out/Default clang-tidy clang-apply-replacements
ninja -C out/Default
gn gen out/Default --export-compile-commands
cd out/Default
tools/clang/third_party/llvm/clang-tools-extra/clang-tidy/tool/run-clang-tidy.py -p . \
-clang-tidy-binary out/Default/tools/clang/third_party/llvm/build/bin/clang-tidy \
-clang-apply-replacements-binary \
out/Default/tools/clang/third_party/llvm/build/bin/clang-apply-replacements \
-checks='-*,modernize-deprecated-headers' \
-fix
to move from C style standard headers to C++ style variants followed
another round of IWYU (which brought back stdio.h), format and gn_check_autofix.
This was followed by a manual pass removing C style headers from C++ headers when the corresponding C++-style header was in included in the .cc file. IWYU after thought brought some instances of stdio.h back *again*.
Bug: webrtc:42226242
Change-Id: I3ec5ee4bd3d4f81e25f5dfca3764bb85c2cad99b
No-Iwyu: false positive of jpeg include
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/396321
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Philipp Hancke <phancke@meta.com>
Cr-Commit-Position: refs/heads/main@{#44937}
68 lines
2.1 KiB
C++
68 lines
2.1 KiB
C++
/*
|
|
* Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
#ifndef TEST_ENCODER_SETTINGS_H_
|
|
#define TEST_ENCODER_SETTINGS_H_
|
|
|
|
#include <cstddef>
|
|
#include <string>
|
|
#include <vector>
|
|
|
|
#include "api/field_trials_view.h"
|
|
#include "api/video/video_codec_type.h"
|
|
#include "call/video_receive_stream.h"
|
|
#include "call/video_send_stream.h"
|
|
#include "video/config/video_encoder_config.h"
|
|
|
|
namespace webrtc {
|
|
namespace test {
|
|
|
|
class DefaultVideoStreamFactory
|
|
: public VideoEncoderConfig::VideoStreamFactoryInterface {
|
|
public:
|
|
DefaultVideoStreamFactory();
|
|
|
|
static const size_t kMaxNumberOfStreams = 3;
|
|
// Defined as {150000, 450000, 1500000};
|
|
static const int kMaxBitratePerStream[];
|
|
// Defined as {50000, 200000, 700000};
|
|
static const int kDefaultMinBitratePerStream[];
|
|
|
|
private:
|
|
std::vector<VideoStream> CreateEncoderStreams(
|
|
const FieldTrialsView& field_trials,
|
|
int frame_width,
|
|
int frame_height,
|
|
const webrtc::VideoEncoderConfig& encoder_config) override;
|
|
};
|
|
|
|
// Creates `encoder_config.number_of_streams` VideoStreams where index
|
|
// `encoder_config.number_of_streams -1` have width = `width`, height =
|
|
// `height`. The total max bitrate of all VideoStreams is
|
|
// `encoder_config.max_bitrate_bps`.
|
|
std::vector<VideoStream> CreateVideoStreams(
|
|
int width,
|
|
int height,
|
|
const webrtc::VideoEncoderConfig& encoder_config);
|
|
|
|
void FillEncoderConfiguration(VideoCodecType codec_type,
|
|
size_t num_streams,
|
|
VideoEncoderConfig* configuration);
|
|
|
|
VideoReceiveStreamInterface::Decoder CreateMatchingDecoder(
|
|
int payload_type,
|
|
const std::string& payload_name);
|
|
|
|
VideoReceiveStreamInterface::Decoder CreateMatchingDecoder(
|
|
const VideoSendStream::Config& config);
|
|
} // namespace test
|
|
} // namespace webrtc
|
|
|
|
#endif // TEST_ENCODER_SETTINGS_H_
|