213119e51e
https://clang.llvm.org/extra/clang-tidy/checks/readability/redundant-smartptr-get.html and https://clang.llvm.org/extra/clang-tidy/checks/readability/named-parameter.html (which resulted only in a single change) Done using tools/clang/scripts/build_clang_tools_extra.py \ --fetch out/Default clang-tidy clang-apply-replacements ninja -C out/Default gn gen out/Default --export-compile-commands cd out/Default tools/clang/third_party/llvm/clang-tools-extra/clang-tidy/tool/run-clang-tidy.py -p . \ -clang-tidy-binary tools/clang/third_party/llvm/build/bin/clang-tidy \ -clang-apply-replacements-binary \ tools/clang/third_party/llvm/build/bin/clang-apply-replacements \ -checks='-*,readability-redundant-smartptr-get,readability-named-parameter' \ -fix followed by git cl format Bug: webrtc:424706384 Change-Id: Ie5a4077286d34c1363a1d341aca50a7047f6543b Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/402584 Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Philipp Hancke <phancke@meta.com> Cr-Commit-Position: refs/heads/main@{#45247}
83 lines
2.4 KiB
C++
83 lines
2.4 KiB
C++
/*
|
|
* Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#include "rtc_base/memory/aligned_malloc.h"
|
|
|
|
#include <cstddef>
|
|
#include <memory>
|
|
|
|
#ifdef _WIN32
|
|
#include <windows.h>
|
|
#else
|
|
#include <cstdint>
|
|
#endif
|
|
|
|
#include "test/gtest.h"
|
|
|
|
namespace webrtc {
|
|
|
|
// Returns true if `size` and `alignment` are valid combinations.
|
|
bool CorrectUsage(size_t size, size_t alignment) {
|
|
std::unique_ptr<char, AlignedFreeDeleter> scoped(
|
|
static_cast<char*>(AlignedMalloc(size, alignment)));
|
|
if (scoped == nullptr) {
|
|
return false;
|
|
}
|
|
const uintptr_t scoped_address = reinterpret_cast<uintptr_t>(scoped.get());
|
|
return 0u == scoped_address % alignment;
|
|
}
|
|
|
|
TEST(AlignedMalloc, GetRightAlign) {
|
|
const size_t size = 100;
|
|
const size_t alignment = 32;
|
|
const size_t left_misalignment = 1;
|
|
std::unique_ptr<char, AlignedFreeDeleter> scoped(
|
|
static_cast<char*>(AlignedMalloc(size, alignment)));
|
|
EXPECT_TRUE(scoped.get() != nullptr);
|
|
const uintptr_t aligned_address = reinterpret_cast<uintptr_t>(scoped.get());
|
|
const uintptr_t misaligned_address = aligned_address - left_misalignment;
|
|
const char* misaligned_ptr =
|
|
reinterpret_cast<const char*>(misaligned_address);
|
|
const char* realigned_ptr = GetRightAlign(misaligned_ptr, alignment);
|
|
EXPECT_EQ(scoped.get(), realigned_ptr);
|
|
}
|
|
|
|
TEST(AlignedMalloc, IncorrectSize) {
|
|
const size_t incorrect_size = 0;
|
|
const size_t alignment = 64;
|
|
EXPECT_FALSE(CorrectUsage(incorrect_size, alignment));
|
|
}
|
|
|
|
TEST(AlignedMalloc, IncorrectAlignment) {
|
|
const size_t size = 100;
|
|
const size_t incorrect_alignment = 63;
|
|
EXPECT_FALSE(CorrectUsage(size, incorrect_alignment));
|
|
}
|
|
|
|
TEST(AlignedMalloc, AlignTo2Bytes) {
|
|
size_t size = 100;
|
|
size_t alignment = 2;
|
|
EXPECT_TRUE(CorrectUsage(size, alignment));
|
|
}
|
|
|
|
TEST(AlignedMalloc, AlignTo32Bytes) {
|
|
size_t size = 100;
|
|
size_t alignment = 32;
|
|
EXPECT_TRUE(CorrectUsage(size, alignment));
|
|
}
|
|
|
|
TEST(AlignedMalloc, AlignTo128Bytes) {
|
|
size_t size = 100;
|
|
size_t alignment = 128;
|
|
EXPECT_TRUE(CorrectUsage(size, alignment));
|
|
}
|
|
|
|
} // namespace webrtc
|