signalapp/webrtc
signalapp/webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
47,020 Commits 2 Branches 174 Tags 441 MiB
main
Commit Graph

20 Commits

Author SHA1 Message Date
Danil Chapovalov
565bbdd51c Replace ArrayView with std::span in rtc_base/ 
Search&Replace MakeArrayView and ArrayView with std::span
Search&Replace include "api/array_view.h" with include <span>
Remove build dependencies on array_view target
Rename tests that were named PrefixArrayView
 from "Prefixstd::span" to "PrefixSpan"

Bug: webrtc:439801349
Change-Id: Iad951423733c8676c7356047f115eb3fcf2e885d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/454241
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#47107}
 2026-03-10 07:27:21 -07:00
Philipp Hancke
3bd6510e6f clang-tidy: apply readability-container-size-empty rule 
which prefers .empty() over .size() == 0

Bug: webrtc:424706384
Change-Id: I7fb63a60ae8cd2e572d35ff3247940087c1c202f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/403505
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Philipp Hancke <phancke@meta.com>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#45306}
 2025-08-07 14:38:41 -07:00
Philipp Hancke
b2ea936d33 Modernize deprecated headers in api/, pc/ and rtc_base/ 
Done using
  tools/clang/scripts/build_clang_tools_extra.py \
    --fetch out/Default clang-tidy clang-apply-replacements
  ninja -C out/Default
  gn gen out/Default --export-compile-commands
  cd out/Default
  tools/clang/third_party/llvm/clang-tools-extra/clang-tidy/tool/run-clang-tidy.py -p . \
    -clang-tidy-binary out/Default/tools/clang/third_party/llvm/build/bin/clang-tidy \
    -clang-apply-replacements-binary \
        out/Default/tools/clang/third_party/llvm/build/bin/clang-apply-replacements \
    -checks='-*,modernize-deprecated-headers' \
    -fix api/ pc/ rtc_base/
followed by
  git cl format
and a round of IWYU followed by more git cl format

Bug: webrtc:424706384
Change-Id: I8add6fe713fba9d6ef4cc3783bdb7e7f975aaa0a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/400921
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Philipp Hancke <phancke@meta.com>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#45182}
 2025-07-21 00:02:35 -07:00
Evan Shrubsole
318cc33c71 [cleanup] Fix redundant webrtc name specifier 
This CL was uploaded by git cl split.

R=hta@webrtc.org

No-IWYU: LSC
Bug: webrtc:42232595
Change-Id: I34e14bba2b09d3b344d434b9779effffba7b745c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/390606
Commit-Queue: Evan Shrubsole <eshr@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Auto-Submit: Evan Shrubsole <eshr@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#44575}
 2025-05-09 08:33:26 -07:00
Evan Shrubsole
f0a4647816 Use webrtc name specifier instead of rtc/cricket in rtc_base 
WebRTC has unified all namespaces to webrtc, and the rtc:: and cricket::
name specifiers need to be replaced with webrtc::. This was generated using
a combination of clang AST rewriting tools and sed.

This CL was uploaded by git cl split.

Bug: webrtc:42232595
Change-Id: Iace25685e2fe722359ba89baa7a0f3984cba7670
No-Iwyu: LSC
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/386650
Reviewed-by: Henrik Andreassson <henrika@webrtc.org>
Commit-Queue: Henrik Andreassson <henrika@webrtc.org>
Auto-Submit: Evan Shrubsole <eshr@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#44409}
 2025-04-17 02:08:43 -07:00
Evan Shrubsole
daf96cfd6d Migrate most of rtc_base/ to webrtc namespace 
Files moved,

- boringssl_certificate.h
- buffer_queue.h
- byte_buffer.h
- data_rate_limiter.h
- recursive_critical_section.h
- dscp.h
- file_rotating_stream.h
- ifaddrs_converter.h
- log_sinks.h
- fifo_buffer.h
- memory_stream.h
- message_digest.h
- win32.h
- rate_tracker.h
- openssl_digest.h
- openssl_key_pair.h
- memory_usage.h
- ssl_certificate.h
- ssl_adapter.h
- platform_thread_types.h
- ssl_fingerprint.h
- cpu_time.h
- proxy_server.h
- boringssl_identity.h
- string_utils.h
- default_socket_server.h
- openssl_session_cache.h
- net_helpers.h
- network.h
- network_monitor_factory.h
- network_route.h
- sent_packet.h
- openssl_adapter.h
- openssl_stream_adapter.h
- operations_chain.h
- net_helper.h

No-Iwyu: ssl and socket related files don't play well it include cleaner
Bug: webrtc:42232595
Change-Id: I949cf4e8be6dab99ce170d8c7388c84fdcdd6447
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/382520
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Evan Shrubsole <eshr@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#44274}
 2025-04-01 02:36:58 -07:00
Evan Shrubsole
49ba3e2af0 Move byte_order.h to webrtc namespace 
Bug: webrtc:42232595
Change-Id: I92163a7374104c7b78fd83769bdb2b4a676d71f3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/380381
Auto-Submit: Evan Shrubsole <eshr@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#44072}
 2025-03-09 17:04:36 -07:00
Tommi
eb4a3140fd Add ReadStringView() to ByteBufferReader 
ReadStringView() is a simple alternative to ReadString() but doesn't
involve a heap allocation for a new std::string.
Using the new methods in one place to start with.

Bug: none
Change-Id: I1100c6d258ffb4c8a31a46ba88a7f8bff9cf35cb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/332120
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41533}
 2024-01-16 09:10:09 +00:00
Harald Alvestrand
5692649b9b Revert^2 "Remove deprecated ByteBufferReader and ByteBufferWriter functions" 
This reverts commit ca58f0eb9d.

Reason for revert: Webkit Linux Leak bot seems flaky

Original change's description:
> Revert "Remove deprecated ByteBufferReader and ByteBufferWriter functions"
>
> This reverts commit e0e03ba73a.
>
> Reason for revert: Speculative rollback (breaks WebKit Linux Leak)
>
> Original change's description:
> > Remove deprecated ByteBufferReader and ByteBufferWriter functions
> >
> > This completes the conversion of ByteBufferReader and ByteBufferWriter
> > to uint8_t.
> >
> > No-Try: True
> > Bug: webrtc:15661
> > Change-Id: I4152a8a4fd2462282d4107b3c2eed19acc8b29b0
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/331640
> > Commit-Queue: Harald Alvestrand <hta@webrtc.org>
> > Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
> > Cr-Commit-Position: refs/heads/main@{#41403}
>
> Bug: webrtc:15661, chromium:1513059
> Change-Id: I3938b8209f5cc1596307deadac157a8f6c2b2253
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/331940
> Owners-Override: Mirko Bonadei <mbonadei@webrtc.org>
> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
> Cr-Commit-Position: refs/heads/main@{#41411}

Bug: webrtc:15661, chromium:1513059
Change-Id: I702c695ba0f83bba5721b18ebd994435a8932c0a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/331980
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41419}
 2023-12-20 07:48:54 +00:00
Mirko Bonadei
ca58f0eb9d Revert "Remove deprecated ByteBufferReader and ByteBufferWriter functions" 
This reverts commit e0e03ba73a.

Reason for revert: Speculative rollback (breaks WebKit Linux Leak)

Original change's description:
> Remove deprecated ByteBufferReader and ByteBufferWriter functions
>
> This completes the conversion of ByteBufferReader and ByteBufferWriter
> to uint8_t.
>
> No-Try: True
> Bug: webrtc:15661
> Change-Id: I4152a8a4fd2462282d4107b3c2eed19acc8b29b0
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/331640
> Commit-Queue: Harald Alvestrand <hta@webrtc.org>
> Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
> Cr-Commit-Position: refs/heads/main@{#41403}

Bug: webrtc:15661, chromium:1513059
Change-Id: I3938b8209f5cc1596307deadac157a8f6c2b2253
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/331940
Owners-Override: Mirko Bonadei <mbonadei@webrtc.org>
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41411}
 2023-12-19 08:20:40 +00:00
Harald Alvestrand
e0e03ba73a Remove deprecated ByteBufferReader and ByteBufferWriter functions 
This completes the conversion of ByteBufferReader and ByteBufferWriter
to uint8_t.

No-Try: True
Bug: webrtc:15661
Change-Id: I4152a8a4fd2462282d4107b3c2eed19acc8b29b0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/331640
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41403}
 2023-12-18 13:41:44 +00:00
Harald Alvestrand
f0ddae8c22 Convert ByteBufferWriter to be type uint8_t 
and make follow-on changes.

Bug: webrtc:15665
Change-Id: Ice646f88ba5a09d6a8d9ce70415d8a14d7050d3c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/329781
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41393}
 2023-12-15 12:27:50 +00:00
Harald Alvestrand
eb14497d7c Delete obsolete ByteBufferReader constructors 
Bug: webrtc:15661
Change-Id: I9dcffad3ee092ffeac8506fcea02b8ce90d3afd7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/329840
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41342}
 2023-12-08 14:49:27 +00:00
Harald Alvestrand
572502c2ab Deprecate char* functions on ByteBufferReader 
Bug: webrtc:15661, webrtc:15665
Change-Id: Ia35b0092c219a89b5eba08d2e1a91be6e47dc746
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/328000
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41210}
 2023-11-22 11:46:25 +00:00
Harald Alvestrand
f0907c6f5b Expunge some more "char" from ByteBufferReader 
Bug: webrtc:15661
Change-Id: I620a5327ca64e89d7816a1ea6f69ad8363ff37e1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/327720
Auto-Submit: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Per Kjellander <perkj@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41193}
 2023-11-20 11:18:08 +00:00
Per K
cf2e08b798 Add ByteBufferReader constructor for ArrayView 
Bug: webrtc:14870
Change-Id: I0643af4a44bb2bc26581df971221766316124996
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/327520
Auto-Submit: Per Kjellander <perkj@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41182}
 2023-11-17 12:07:05 +00:00
Harald Alvestrand
72defe459b Use uint8_t as inner type for rtc::ByteBufferReader 
Bug: webrtc:15661
Change-Id: Iefca01c953c4e69bebb1eb14391d0cfa6c69846e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/327581
Reviewed-by: Per Kjellander <perkj@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41177}
 2023-11-17 06:27:12 +00:00
Danil Chapovalov
7b46e17c31 In rtc::ByteBuffer drop support for ORDER_HOST as unused 
Bug: None
Change-Id: Ideab428b13d981cddf9784cfd07fb7dfb2e914fe
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159698
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29803}
 2019-11-15 11:48:42 +00:00
Steve Anton
10542f21c8 (4) Rename files to snake_case: update BUILD.gn, include paths, header guards, and DEPS entries 
Mechanically generated by running this command:

tools_webrtc/do-renames.sh update all-renames.txt && git cl format

Then manually updating:

tools_webrtc/sanitizers/tsan_suppressions_webrtc.cc

Bug: webrtc:10159
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: I54824cd91dada8fc3ee3d098f971bc319d477833
Reviewed-on: https://webrtc-review.googlesource.com/c/115653
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#26226}
 2019-01-11 17:11:39 +00:00
Steve Anton
1c05765831 (3) Rename files to snake_case: move the files 
Mechanically generated with this command:

tools_webrtc/do-rename.sh move all-renames.txt

Bug: webrtc:10159
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: I8b05b6eab9b9d18b29c2199bbea239e9add1e690
Reviewed-on: https://webrtc-review.googlesource.com/c/115481
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#26225}
 2019-01-11 17:05:20 +00:00