signalapp/sgx_common
signalapp/sgx_common
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert "log Intel quote attestation signing certs (#6)" (#7)

Browse Source 
This reverts commit 979f7b8dbd.
This commit is contained in:
jmhodges-signal 2020-07-08 09:41:51 -07:00 committed by GitHub
parent 979f7b8dbd
commit 1fcff83d9e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 0 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
ias_client/Cargo.toml
View File

@ -12,9 +12,6 @@ futures = "0.1"
http = "0.1"
hyper = "0.12"
kbupd_util = { path = "../kbupd_util" }
log = { version = "0.4", features = ["std"] }
openssl = { rev = "ea6761d5e7b63b415b7fda6ba5c5026f4218bcd0", git = "https://github.com/signalapp/rust-openssl.git" }
openssl-sys = { rev = "ea6761d5e7b63b415b7fda6ba5c5026f4218bcd0", git = "https://github.com/signalapp/rust-openssl.git" }
serde = "1.0"
serde_derive = "1.0"
serde_json = "1.0"

15
ias_client/src/lib.rs
View File

@ -26,8 +26,6 @@ use http::{self, HeaderMap, Uri};
use hyper::client::connect::Connect;
use hyper::{Body, Chunk, Client, Method, Request, Response};
use kbupd_util::base64;
use log::warn;
use openssl::x509::X509;
use serde_derive::{Deserialize, Serialize};
use serde_json;
use sgx_sdk_ffi::SgxQuote;
@ -218,19 +216,6 @@ fn validate_quote_signature(
return Err(QuoteVerificationError::InvalidCertificates(pem_certificates.to_string()));
}
// TODO(KBS-174): remove this logging or make it a return, not a log
for (i, cert_bytes) in certificates.iter().enumerate() {
let res = X509::from_der(cert_bytes);
match res {
Ok(_) => {
// do nothing
}
Err(err) => warn!(
"unable to parse X-IAS-Report-Signing-Certificate index {} (full bytes: '{}'): {}",
i, pem_certificates, err
),
}
}
let body = response_body_data.to_vec();
let parsed_body: QuoteSignatureResponseBody =