It's been deprecated for decades and in Debian system it's starting
to print warnings. Just use grep -F instead.
Signed-off-by: Ralph Giles <giles@thaumas.net>
meson.source_root() and meson.build_root() have been deprecated in
latest Meson release because they are a trap. They point to the root of
parent project instead of root of current subproject. Meson 0.56.0 added
meson.project_source/build_root() but it is just as easy to use
meson.current_source/build_dir() in the root meson.build file and avoids
bumping required meson version.
Signed-off-by: Ralph Giles <giles@thaumas.net>
Tested on:
- Linux/x86* with gcc
- Android armv7 arm64 x86 x86_64 with clang
- Windows x86 x86_64 with Visual Studio 2017
- Windows x86 x86_64 with MinGW
- macOS x86_64 with clang
- iOS arm64 x86_64 with clang
Co-authored by: Nirbheek Chauhan <nirbheek@centricular.com>
https://gitlab.xiph.org/xiph/opus/-/merge_requests/13
Add newer source directories to the destdir file tree so we
can include all sources referenced from opus_sources.mk.
Signed-off-by: Ralph Giles <giles@thaumas.net>
[[ ]], the compound command is not supported by all
shell interpreter. [ ], the buildin command is more
common.
Signed-off-by: Ralph Giles <giles@thaumas.net>
Silence a gcc warning by checking the return value of the fread()
call instead of the feof() guard. This prevents an infinite loop
in the case of a read error. Otherwise, when end-of-file is reached
fread() will certainly return a smaller number of elements read
than requested, so both cases are handled now.
Add a comment to clarify that we're dropping a partial frame on
purpose to keep the code simple.
Also add more braces around conditional bodies for less error-prone
style.
Signed-off-by: Mark Harris <mark.hsj@gmail.com>
The simple codec round-trip example file in the doc directory
opens an input and output pcm file. It was working fine on
POSIX systems, but not on Windows, which treats text files
differently.
This is confusing in a example, so it's better to add an
explicit binary flag to the fopen() calls. This does nothing
on unix-like systems, but should make the example work for
developers on Windows.
Thanks to Wavesonics who reported this on irc.
Signed-off-by: Mark Harris <mark.hsj@gmail.com>
Remove version.mk and references to it in the repo.
genversion.bat will now generate the same version strings as
update_version script, i.e. without 'v' prefix and without a
fallback if git archive is used.
If run from a release tarball it'll use package_version,
like configure. If run from a git repo, it will use the same
'git describe' with '-dirty' as update_version.
Signed-off-by: Ralph Giles <giles@thaumas.net>
Different distributions of doxygen have different default
values of HAVE_DOT setting, so we need to pick a specific
setting to avoid 'missing dot' warnings on some platforms.
Doxygen uses it to generate inclusion graphs for our various
header files, which is somewhat useful, but not essential.
We therefore enable dot if it's present (usually through
the parent graphviz package) but disable it if it's not
available, silencing the warning, but not giving uniform
results.
Ralph Giles correctly points out that the sequence number field in
Ogg pages starts couting at 0, so counting from 1 in the diagram
might be confusing.
For RFC 6716, the RFC Editor converted our Wikipedia URLs into
stable ones that would always point at the same version of the
page.
We're close enough to the end that we can go ahead and do that in
advance (and also update the dates to reflect the most recent
version).
- Clarify that 125,829,120 is just 120 MB.
- Add a figure to Section 3 of an example logical stream.
- Add a reference for Q notation.
- Refer to the downmixing figures in the text.
- Clarify that user comments are UTF-8.
- Clarify that the -573 and 111 gain values are examples.
- Add specific advice to implementors on areas that have security
implications.
Apparently the IETF does not like having the BSD copyright in the
.xml source (despite the CODEC WG's IPR advisor saying this was
okay), so we need a new version.
The improves the reproducibilit of the build. The date
was nice to have, but there's a version string at the
top which should identify the release correctly.
The copyright date could actually be incorrect, since
it is based on the build date and not the last-changed
date.
This also removes the request for an additional grant from the IETF
Trust on the final RFC.
I believe this is sufficient to exercise our ability to allow
downstream modifications as proposed in RFC 5377 Section 4.4.
See the discussion at
<https://www.ietf.org/mail-archive/web/codec/current/msg03169.html>
for details.
