From d0973d76175e69732fe28c8026d4411afddf3e48 Mon Sep 17 00:00:00 2001 From: Kornel Date: Tue, 10 Feb 2026 19:35:39 +0000 Subject: [PATCH] Backwards-compatible add_cert() --- boring/src/ssl/test/mod.rs | 4 ++-- boring/src/x509/store.rs | 3 ++- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/boring/src/ssl/test/mod.rs b/boring/src/ssl/test/mod.rs index 9317a7ba..3cdc5ed2 100644 --- a/boring/src/ssl/test/mod.rs +++ b/boring/src/ssl/test/mod.rs @@ -317,13 +317,13 @@ fn test_mutable_store() { let cert2 = X509::from_pem(cert2).unwrap(); let mut ctx = SslContext::builder(SslMethod::tls()).unwrap(); - ctx.cert_store_mut().add_cert(&cert.clone()).unwrap(); + ctx.cert_store_mut().add_cert(cert.clone()).unwrap(); assert_eq!(1, ctx.cert_store().objects_len()); ctx.set_cert_store_builder(X509StoreBuilder::new().unwrap()); assert_eq!(0, ctx.cert_store().objects_len()); - ctx.cert_store_mut().add_cert(&cert.clone()).unwrap(); + ctx.cert_store_mut().add_cert(cert.clone()).unwrap(); assert_eq!(1, ctx.cert_store().objects_len()); let mut new_store = X509StoreBuilder::new().unwrap(); diff --git a/boring/src/x509/store.rs b/boring/src/x509/store.rs index 7b9a2317..95aedda4 100644 --- a/boring/src/x509/store.rs +++ b/boring/src/x509/store.rs @@ -80,7 +80,8 @@ impl X509StoreBuilder { impl X509StoreBuilderRef { /// Adds a certificate to the certificate store. #[corresponds(X509_STORE_add_cert)] - pub fn add_cert(&mut self, cert: &X509Ref) -> Result<(), ErrorStack> { + pub fn add_cert(&mut self, cert: impl AsRef) -> Result<(), ErrorStack> { + let cert = cert.as_ref(); unsafe { cvt(ffi::X509_STORE_add_cert(self.as_ptr(), cert.as_ptr())) } }