From 1d6e3bd1d6399b15626f5a9d49ef50b76c12726b Mon Sep 17 00:00:00 2001 From: Max Radermacher Date: Mon, 25 Jul 2022 09:52:03 -0700 Subject: [PATCH] Fix `pod lib lint` warnings MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * Remove constant (unused since 64410ab6b3b8f6). * Remove description * Set Swift version to 5.0 * Don’t allow warnings during `pod lib lint` --- SignalCoreKit.podspec | 7 ++----- SignalCoreKit/src/Cryptography.m | 3 --- bin/build_and_test.sh | 2 +- 3 files changed, 3 insertions(+), 9 deletions(-) diff --git a/SignalCoreKit.podspec b/SignalCoreKit.podspec index 073fa1e..2a92f42 100644 --- a/SignalCoreKit.podspec +++ b/SignalCoreKit.podspec @@ -10,11 +10,6 @@ Pod::Spec.new do |s| s.name = "SignalCoreKit" s.version = "1.0.0" s.summary = "A Swift & Objective-C library used by other Signal libraries." - - s.description = <<-DESC -A Swift & Objective-C library used by other Signal libraries. - DESC - s.homepage = "https://github.com/signalapp/SignalCoreKit" s.license = 'GPLv3' s.author = { "iOS Team" => "ios@signal.org" } @@ -24,6 +19,8 @@ A Swift & Objective-C library used by other Signal libraries. s.platform = :ios, '10.0' s.requires_arc = true + s.swift_version = '5.0' + s.source_files = 'SignalCoreKit/src/**/*.{h,m,mm,swift}', 'SignalCoreKit/Private/**/*.{h,m,mm,swift}' s.public_header_files = 'SignalCoreKit/src/**/*.h' diff --git a/SignalCoreKit/src/Cryptography.m b/SignalCoreKit/src/Cryptography.m index 336b65a..313bfbc 100644 --- a/SignalCoreKit/src/Cryptography.m +++ b/SignalCoreKit/src/Cryptography.m @@ -23,9 +23,6 @@ const NSUInteger kAES256CTR_IVLength = 16; // length of authentication tag for AES256-GCM static const NSUInteger kAESGCM256_TagLength = 16; -// length of key used for websocket envelope authentication -static const NSUInteger kHMAC256_EnvelopeKeyLength = 20; - const NSUInteger kAES256_KeyByteLength = 32; @implementation OWSAES256Key diff --git a/bin/build_and_test.sh b/bin/build_and_test.sh index e55a361..3d611e7 100755 --- a/bin/build_and_test.sh +++ b/bin/build_and_test.sh @@ -4,4 +4,4 @@ set -u set -o pipefail XCODE_XCCONFIG_FILE=SignalCoreKit/CI.xcconfig \ - pod lib lint --verbose --allow-warnings + pod lib lint --verbose