da322d3bf9
To improve message reliability, we're adding an urgency flag to outgoing messages. For example, outgoing calls are urgent, but delivery receipts are not. [Android][] and [Desktop][] have already done this work. At a high level, I added an `isUrgent` property to `TSOutgoingMessage`s. It defaults to `true`. Some subclasses, like `OWSReceiptsForSenderMessage`, override it to return `false`. Builds off of a few other commits (not necessary to understand this commit, but might be useful for posterity): -e858a0d916-8c6d2ebe8c-402b117221-2ba0cd764d-266a4663e9-8e5009bbf7[Android]:dc04c8ed98[Desktop]:06190b1434
59 lines
1.9 KiB
Swift
59 lines
1.9 KiB
Swift
//
|
|
// Copyright (c) 2022 Open Whisper Systems. All rights reserved.
|
|
//
|
|
|
|
import XCTest
|
|
import SignalServiceKit
|
|
|
|
class OutgoingGroupUpdateMessageTest: SSKBaseTestSwift {
|
|
override func setUp() {
|
|
super.setUp()
|
|
tsAccountManager.registerForTests(withLocalNumber: "+12225550101", uuid: UUID(), pni: UUID())
|
|
}
|
|
|
|
func createThread(transaction: SDSAnyWriteTransaction) throws -> TSGroupThread {
|
|
try GroupManager.createGroupForTests(
|
|
members: [],
|
|
name: "Test group",
|
|
groupsVersion: .V2,
|
|
transaction: transaction
|
|
)
|
|
}
|
|
|
|
func testShouldBeSaved() throws {
|
|
let thread = try write { try createThread(transaction: $0) }
|
|
read { transaction in
|
|
let metaMessages: [TSGroupMetaMessage: Bool] = [
|
|
.unspecified: true,
|
|
.new: false,
|
|
.update: false,
|
|
.deliver: true,
|
|
.quit: false,
|
|
.requestInfo: false
|
|
]
|
|
for (groupMetaMessage, expected) in metaMessages {
|
|
let message = OutgoingGroupUpdateMessage(
|
|
in: thread,
|
|
groupMetaMessage: groupMetaMessage,
|
|
expiresInSeconds: 60,
|
|
transaction: transaction
|
|
)
|
|
let actual = message.shouldBeSaved
|
|
XCTAssertEqual(actual, expected, "\(groupMetaMessage.rawValue)")
|
|
}
|
|
}
|
|
}
|
|
|
|
func testIsUrgent() throws {
|
|
let message = try write { transaction -> OutgoingGroupUpdateMessage in
|
|
OutgoingGroupUpdateMessage(
|
|
in: try createThread(transaction: transaction),
|
|
groupMetaMessage: .update,
|
|
expiresInSeconds: 60,
|
|
transaction: transaction
|
|
)
|
|
}
|
|
XCTAssertFalse(message.isUrgent)
|
|
}
|
|
}
|