22c1cb8a22
This is the first meaty part of optimizing fetching display names. Some contacts fall back to phone numbers as their display names. This PR fetches them in a single SQL query via `OWSContactsManager.phoneNumbers(for:, transaction)`. To achieve this, this PR introduces `GRDBSignalAccountFinder.signalAccounts(for:,transaction:)` to fetch many accounts at once. In order to fetch many accounts at once, we need to be able to fetch many values from a ModelReadCache at once. So this PR introduces `ModelReadCache.readValues(for:,transaction:)` and `ModelReadCache.getValues(for:,transaction:,returnNilOnCacheMiss:)`. Existing methods that operate on a single value were refactored to use the batch methods. This PR adds tests for this functionality, which necessitated changing the visibility of various private symbols and also improving the fake profile manager to make it more configurable. There's also a tiny optimization for Refinery to avoid calling a closure that has no work to do. This helps elide do-nothing SQL queries that would otherwise have been introduced.
134 lines
3.8 KiB
Swift
134 lines
3.8 KiB
Swift
//
|
|
// Copyright (c) 2022 Open Whisper Systems. All rights reserved.
|
|
//
|
|
|
|
import Foundation
|
|
import XCTest
|
|
@testable import SignalServiceKit
|
|
|
|
class RefineryTest: SSKBaseTestSwift {
|
|
|
|
func testBasic() {
|
|
let keys = [1, 2, 3]
|
|
let refinery = Refinery<Int, String>(keys).refine { values in
|
|
return values.lazy.map {
|
|
if $0 == 1 {
|
|
return "one"
|
|
}
|
|
return nil
|
|
}
|
|
}.refine { values in
|
|
return values.lazy.map {
|
|
XCTAssertFalse($0 == 1) // Already handled 1 and we shouldn't be called again.
|
|
if $0 == 3 {
|
|
return "three"
|
|
}
|
|
return nil
|
|
}
|
|
}
|
|
|
|
let actual = refinery.values
|
|
let expected = ["one", nil, "three"]
|
|
XCTAssertEqual(actual, expected)
|
|
}
|
|
|
|
func testConditional() {
|
|
let keys = [1, 2, 3, 4]
|
|
let refinery = Refinery<Int, String>(keys).refine(condition: {
|
|
$0 % 2 == 0
|
|
}, then: { values in
|
|
return values.lazy.map {
|
|
XCTAssertFalse($0 == 1)
|
|
XCTAssertFalse($0 == 3)
|
|
if $0 == 2 {
|
|
return nil
|
|
}
|
|
return "even: \($0)"
|
|
}
|
|
}, otherwise: { values in
|
|
return values.lazy.map {
|
|
XCTAssertFalse($0 == 0)
|
|
XCTAssertFalse($0 == 2)
|
|
return "odd: \($0)"
|
|
}
|
|
})
|
|
|
|
let actual = refinery.values
|
|
let expected = ["odd: 1", nil, "odd: 3", "even: 4"]
|
|
XCTAssertEqual(actual, expected)
|
|
}
|
|
|
|
func testDuplicateKey() {
|
|
let keys = [1, 2, 3, 1]
|
|
let refinery = Refinery<Int, String>(keys).refine { values in
|
|
return values.lazy.map {
|
|
if $0 == 1 {
|
|
return "one"
|
|
}
|
|
return nil
|
|
}
|
|
}.refine { values in
|
|
return values.lazy.map {
|
|
XCTAssertFalse($0 == 1) // Already handled 1 and we shouldn't be called again.
|
|
if $0 == 3 {
|
|
return "three"
|
|
}
|
|
return nil
|
|
}
|
|
}
|
|
|
|
let actual = refinery.values
|
|
let expected = ["one", nil, "three", "one"]
|
|
XCTAssertEqual(actual, expected)
|
|
}
|
|
|
|
func testOnePass() {
|
|
let keys = [1, 2, 3]
|
|
let refinery = Refinery<Int, String>(keys).refine { values in
|
|
return values.lazy.map {
|
|
switch $0 {
|
|
case 1:
|
|
return "one"
|
|
case 2:
|
|
return "two"
|
|
case 3:
|
|
return "three"
|
|
default:
|
|
return nil
|
|
}
|
|
}
|
|
}
|
|
|
|
let actual = refinery.values
|
|
let expected = ["one", "two", "three"]
|
|
XCTAssertEqual(actual, expected)
|
|
}
|
|
|
|
func testSkipCallWithoutKeys() {
|
|
let keys = [1, 2, 3]
|
|
var thenCalls = 0
|
|
var otherwiseCalls = 0
|
|
_ = Refinery<Int, String>(keys).refine { _ in
|
|
return true
|
|
} then: { values -> [String?] in
|
|
thenCalls += 1
|
|
return values.map { "\($0)"}
|
|
} otherwise: { values -> [String?] in
|
|
otherwiseCalls += 1
|
|
return values.map { _ in "fail" }
|
|
}
|
|
XCTAssertEqual(1, thenCalls)
|
|
XCTAssertEqual(0, otherwiseCalls)
|
|
}
|
|
|
|
func testRefineNonnilKeys() {
|
|
let keys = [1, nil, 3]
|
|
let actual = Refinery<Int?, String>(keys).refineNonnilKeys { (keys: AnySequence<Int>) -> [String?] in
|
|
XCTAssertEqual(Array(keys), [1, 3])
|
|
return keys.map { String($0) }
|
|
}.values
|
|
let expected = ["1", nil, "3"]
|
|
XCTAssertEqual(actual, expected)
|
|
}
|
|
}
|