bcb7eddb63
We're seeing crashes during this data migration step. We fail to init the OWSUserProfile from the Row result returned from the SQLite fetch request. It's likely we're indexing into an out-of-bounds index on Row. (Row._checkIndex is inlined so we can't be sure) GRDB caches the sqlite3_column_count during Row.init and uses that to determine if a subscript access is out-of-bounds. From what I can tell in an amateur reading of sqlite3.c, that just pulls the nResColumn from the prepared statement. SQLite will determine the number of result columns during statement prep, but the column count can change if the table schema changes: > If the database schema changes, instead of returning SQLITE_SCHEMA as it always used to do, sqlite3_step() will automatically recompile the SQL statement and try to run it again. As many as SQLITE_MAX_SCHEMA_RETRY retries will occur before sqlite3_step() gives up and returns an error. We're nesting a deferred read transaction inside of our data migration's immediate transaction. This read is using a different sqlite connection that the connection performing our migrations. So its understanding of the schema is stale and because it's in a deferred transaction it won't figure this out until we call _step(). Once we call _step(), sqlite will realize that the table schema has changed and recompile the prepared statement while opening the deferred transaction. After this, the sqlite_column_count is correct. But Row still has the incorrect value cached from before the schema was resolved. So by the time we try and init our OWSUserProfile, Row falsely asserts that we're indexing beyond the column count by comparing against a stale version of the column count. The fix: Rework the data migration to avoid nesting a deferred read transaction. This is incorrect behavior. Now that our read is using our already open write transaction with the same connection handle, it's understanding of the schema is up-to-date during statement prep. So Row.init grabs the current column count. |
||
|---|---|---|
| .github | ||
| fastlane | ||
| NotificationServiceExtension | ||
| Pods@0f148ca373 | ||
| Scripts | ||
| Signal | ||
| Signal.xcodeproj | ||
| Signal.xcworkspace | ||
| SignalMessaging | ||
| SignalServiceKit | ||
| SignalShareExtension | ||
| ThirdParty | ||
| .clang-format | ||
| .gitattributes | ||
| .gitignore | ||
| .gitmodules | ||
| .ruby-version | ||
| .swiftlint.yml | ||
| .xcode-version | ||
| BUILDING.md | ||
| CONTRIBUTING.md | ||
| Gemfile | ||
| Gemfile.lock | ||
| Jenkinsfile | ||
| LICENSE | ||
| MAINTAINING.md | ||
| Makefile | ||
| Podfile | ||
| Podfile.lock | ||
| README.md | ||
| SignalServiceKit.podspec | ||
Signal iOS
Signal is a free, open source, messaging app for simple private communication with friends.
Also available on Android and Desktop.
Questions?
For troubleshooting and questions, please visit our support center or unofficial community forum.
Contributing Bug Reports
We use GitHub for bug tracking. Please search existing issues and create a new one if the issue is not yet tracked. For Android users, please use the Signal for Android issue tracker.
Contributing Translations
Help us translate Signal! The translation effort happens on Transifex.
Contributing Code
Instructions on how to setup your development environment and build Signal-iOS can be found in BUILDING.md. Other useful instructions for development can be found in the Development Guide wiki page. We also recommend reading the contribution guidelines.
Contributing Ideas
Have something you want to say about Signal Foundation projects or want to be part of the conversation? Get involved in the community forum.
Cryptography Notice
This distribution includes cryptographic software. The country in which you currently reside may have restrictions on the import, possession, use, and/or re-export to another country, of encryption software. BEFORE using any encryption software, please check your country's laws, regulations and policies concerning the import, possession, or use, and re-export of encryption software, to see if this is permitted. See http://www.wassenaar.org/ for more information.
The U.S. Government Department of Commerce, Bureau of Industry and Security (BIS), has classified this software as Export Commodity Control Number (ECCN) 5D002.C.1, which includes information security software using or performing cryptographic functions with asymmetric algorithms. The form and manner of this distribution makes it eligible for export under the License Exception ENC Technology Software Unrestricted (TSU) exception (see the BIS Export Administration Regulations, Section 740.13) for both object code and source code.
License
Licensed under GPLv3
Copyright 2014-2019 Open Whisper Systems
Apple and the Apple logo are trademarks of Apple Inc., registered in the U.S. and other countries. App Store is a service mark of Apple Inc., registered in the U.S. and other countries.