7e8b2e3034
There are multiple places in the codebase we present a conversation. We used to have some very conservative machinery around how this was done, for fear of failing to present the call view controller, which would have left a hidden call in the background. We've since addressed that concern more thoroughly via the separate calling UIWindow. As such, the remaining presentation machinery is overly complex and inflexible for what we need. Sometimes we want to animate-push the conversation. (tap on home, tap on "send message" in contact card/group members) Sometimes we want to dismiss a modal, to reveal the conversation behind it (contact picker, group creation) Sometimes we want to present the conversation with no animation (becoming active from a notification) We also want to ensure that we're never pushing more than one conversation view controller, which was previously a problem since we were "pushing" a newly constructed VC in response to these myriad actions. It turned out there were certain code paths that caused multiple actions to be fired in rapid succession which pushed multiple ConversationVC's. The built-in method: `setViewControllers:animated` easily ensures we only have one ConversationVC on the stack, while being composable enough to faciliate the various more efficient animations we desire. The only thing lost with the complex methods is that the naive `presentViewController:` can fail, e.g. if another view is already presented. E.g. if an alert appears *just* before the user taps compose, the contact picker will fail to present. Since we no longer depend on this for presenting the CallViewController, this isn't catostrophic, and in fact, arguable preferable, since we want the user to read and dismiss any alert explicitly. // FREEBIE |
||
|---|---|---|
| .github | ||
| Carthage@d69c75bfcf | ||
| fastlane | ||
| Pods@4c3935aa74 | ||
| protobuf | ||
| Scripts | ||
| SettingsBundle | ||
| Signal | ||
| Signal.xcodeproj | ||
| Signal.xcworkspace | ||
| SignalMessaging | ||
| SignalServiceKit | ||
| SignalShareExtension | ||
| .clang-format | ||
| .gitattributes | ||
| .gitignore | ||
| .gitmodules | ||
| .ruby-version | ||
| .travis.yml | ||
| BUILDING.md | ||
| Cartfile | ||
| Cartfile.resolved | ||
| CONTRIBUTING.md | ||
| Gemfile | ||
| Gemfile.lock | ||
| LICENSE | ||
| MAINTAINING.md | ||
| Makefile | ||
| Podfile | ||
| Podfile.lock | ||
| README.md | ||
| SignalServiceKit.podspec | ||
Signal for iOS
Signal is a messaging app for simple private communication with friends.
Translation
Help us translate Signal! The translation effort happens on Transifex
Contributing Code
Instructions on how to set up your development environment and build Signal-iOS can be found in BUILDING.md. Other useful instructions for development can be found on the Development Guide wiki page. We also recommend reading the contribution guidelines.
Contributing Ideas
Have something you want to say about Open Whisper Systems projects or want to be part of the conversation? Get involved in the community forum.
SignalServiceKit
Check out the SignalServiceKit README for details about using SignalServiceKit in your own app.
Cryptography Notice
This distribution includes cryptographic software. The country in which you currently reside may have restrictions on the import, possession, use, and/or re-export to another country, of encryption software. BEFORE using any encryption software, please check your country's laws, regulations and policies concerning the import, possession, or use, and re-export of encryption software, to see if this is permitted. See http://www.wassenaar.org/ for more information.
The U.S. Government Department of Commerce, Bureau of Industry and Security (BIS), has classified this software as Export Commodity Control Number (ECCN) 5D002.C.1, which includes information security software using or performing cryptographic functions with asymmetric algorithms. The form and manner of this distribution makes it eligible for export under the License Exception ENC Technology Software Unrestricted (TSU) exception (see the BIS Export Administration Regulations, Section 740.13) for both object code and source code.
License
Copyright 2014-2018 Open Whisper Systems
Licensed under the GPLv3: http://www.gnu.org/licenses/gpl-3.0.html