Signal-iOS/Scripts
Evan Hahn 653cb30a59 Use reserved in protobufs
_This change should have no user impact._ And you can see that the only
changes to generated files are in comments.

Before this change, we used comments to denote reserved or deprecated
fields. This works, but I think we should instead use the `reserved`
keyword, which offers a few advantages. From [the protobuf docs][0]:

> If you update a message type by entirely removing a field, or
> commenting it out, future users can reuse the field number when making
> their own updates to the type. This can cause severe issues if they
> later load old versions of the same .proto, including data corruption,
> privacy bugs, and so on. One way to make sure this doesn't happen is
> to specify that the field numbers (and/or names, which can also cause
> issues for JSON serialization) of your deleted fields are reserved.
> The protocol buffer compiler will complain if any future users try to
> use these field identifiers.

This updates our proto files to use `reserved` instead of comments. It
also adds support to our wrapper script. (I moved a few things around in
that script, too, for consistency.)

I think this is a useful change on its own, but I think it'll make
things a little better when we deprecate some fields, which we're
planning to do soon.

[0]: https://developers.google.com/protocol-buffers/docs/proto3#reserved
2022-09-27 18:45:38 +00:00
..
git_hooks Remove reverse integration script 2022-06-10 13:56:32 +00:00
sds_codegen PR Feedback 2022-09-22 14:53:29 -07:00
translation Fix Spanish App Store Connect language support 2022-07-28 09:43:50 -07:00
AuditStringH.py More Python 3 script fixes 2022-03-24 10:28:27 -05:00
bump_build_tag.py Scripts: subprocess.check_output should use text=True for compatibility 2022-03-24 17:28:12 -05:00
ClearDerivedData.sh Respond to CR. 2018-02-09 10:31:29 -05:00
debug_log_upload.py Scripts: subprocess.check_output should use text=True for compatibility 2022-03-24 17:28:12 -05:00
disableUniversalDeviceSupport More Python 3 script fixes 2022-03-24 10:28:27 -05:00
emoji_ranges.py Upgrade scripts to Python 3 2022-03-21 12:58:33 -05:00
emoji-data.txt Respond to CR. 2017-10-30 12:11:42 -04:00
EmojiGenerator.swift Fix operator_whitespace SwiftLint violations 2022-07-07 17:38:38 -07:00
enableUniversalDeviceSupport More Python 3 script fixes 2022-03-24 10:28:27 -05:00
extract_analytics_event_names.py Move script out of SignalServiceKit 2022-08-01 16:29:43 -05:00
feature_flags_beta.py Upgrade scripts to Python 3 2022-03-21 12:58:33 -05:00
feature_flags_common.py Scripts: subprocess.check_output should use text=True for compatibility 2022-03-24 17:28:12 -05:00
feature_flags_openPreview.py Upgrade scripts to Python 3 2022-03-21 12:58:33 -05:00
feature_flags_production.py Upgrade scripts to Python 3 2022-03-21 12:58:33 -05:00
feature_flags_qa.py Upgrade scripts to Python 3 2022-03-21 12:58:33 -05:00
HardResetGit.sh Hard reset git script. 2017-01-31 13:58:13 -05:00
precommit.py Sort the Xcode project's visible files 2022-08-19 15:38:25 -07:00
ProtoWrappers.py Use reserved in protobufs 2022-09-27 18:45:38 +00:00
schema_dump Firm up database schema 2021-11-09 14:25:42 -08:00
set_release_notes set_release_notes: support EDITOR with arguments 2022-05-25 15:59:47 -07:00
setup_private_pods Fix setup_private_pods script for newly-cloned repos 2022-01-28 10:04:00 -08:00
sort-Xcode-project-file Sort the Xcode project's visible files 2022-08-19 15:38:25 -07:00
sqlclient Don't read or write dbPath in debug dbPaypload 2022-09-26 14:13:06 -07:00
sqlclient-legacy sql client scripts 2019-04-05 10:50:45 -06:00
symbolicate.py Pretty-print symbolicated crashes 2022-05-23 22:08:36 +00:00
unused_strings.py Improve script to find unused strings 2022-04-15 15:28:15 -05:00
update_plist_info.sh Fix update_plist_info.sh to not assume no decorate on git log 2022-05-10 19:49:30 -05:00
update_share_plist_info.sh PR Feedback 2019-05-28 13:07:34 -07:00
upload_metadata Harden upload_metadata script 2022-05-05 10:13:47 -05:00