signalapp/Signal-iOS
signalapp/Signal-iOS
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases 4 Wiki Activity
5be184dc21
Signal-iOS/SignalUI/Views
History
Evan Hahn b459e22026 Improve "dim when highlighted" logic for OWSButtons 
This dims the button:

    let button = OWSButton()
    button.dimsWhenHighlighted = true
    button.isHighlighted = true

This did not, and I think it should (last 2 lines are switched):

    let button = OWSButton()
    button.isHighlighted = true
    button.dimsWhenHighlighted = true

This also removes an unnecessary `@objc` annotation.

I think this is a useful change on its own but I expect it to make an
upcoming change easier, too.
2022-10-13 12:45:02 -05:00
..
ConversationView Change license to AGPL 2022-10-13 08:25:37 -05:00
ImageEditor Change license to AGPL 2022-10-13 08:25:37 -05:00
Link Preview Change license to AGPL 2022-10-13 08:25:37 -05:00
Mentions Change license to AGPL 2022-10-13 08:25:37 -05:00
Tooltips Change license to AGPL 2022-10-13 08:25:37 -05:00
VideoEditor Change license to AGPL 2022-10-13 08:25:37 -05:00
AvatarImageView.swift Change license to AGPL 2022-10-13 08:25:37 -05:00
CaptchaView.swift Change license to AGPL 2022-10-13 08:25:37 -05:00
CircleView.swift Change license to AGPL 2022-10-13 08:25:37 -05:00
ColorPickerBar.swift Change license to AGPL 2022-10-13 08:25:37 -05:00
ContactCell.swift Change license to AGPL 2022-10-13 08:25:37 -05:00
ContactCellView.swift Change license to AGPL 2022-10-13 08:25:37 -05:00
ContactsViewHelper.h Change license to AGPL 2022-10-13 08:25:37 -05:00
ContactsViewHelper.m Change license to AGPL 2022-10-13 08:25:37 -05:00
ContactsViewHelper.swift Change license to AGPL 2022-10-13 08:25:37 -05:00
ContactTableViewCell.swift Change license to AGPL 2022-10-13 08:25:37 -05:00
ConversationAvatarView.swift Change license to AGPL 2022-10-13 08:25:37 -05:00
CustomKeyboard.swift Change license to AGPL 2022-10-13 08:25:37 -05:00
DirectionalPanGestureRecognizer.swift Change license to AGPL 2022-10-13 08:25:37 -05:00
DisappearingTimerConfigurationView.swift Change license to AGPL 2022-10-13 08:25:37 -05:00
GalleryRailView.swift Change license to AGPL 2022-10-13 08:25:37 -05:00
GradientView.swift Change license to AGPL 2022-10-13 08:25:37 -05:00
GroupTableViewCell.swift Change license to AGPL 2022-10-13 08:25:37 -05:00
InputAccessoryViewPlaceholder.swift Change license to AGPL 2022-10-13 08:25:37 -05:00
LinkingTextView.swift Change license to AGPL 2022-10-13 08:25:37 -05:00
LoopingVideoView.swift Change license to AGPL 2022-10-13 08:25:37 -05:00
ManualLayoutView.swift Change license to AGPL 2022-10-13 08:25:37 -05:00
ManualStackView.swift Change license to AGPL 2022-10-13 08:25:37 -05:00
MediaTextView.swift Change license to AGPL 2022-10-13 08:25:37 -05:00
NonContactTableViewCell.swift Change license to AGPL 2022-10-13 08:25:37 -05:00
OWSActionSheets.swift Change license to AGPL 2022-10-13 08:25:37 -05:00
OWSBezierPathView.h Change license to AGPL 2022-10-13 08:25:37 -05:00
OWSBezierPathView.m Change license to AGPL 2022-10-13 08:25:37 -05:00
OWSBubbleShapeView.swift Change license to AGPL 2022-10-13 08:25:37 -05:00
OWSBubbleView.h Change license to AGPL 2022-10-13 08:25:37 -05:00
OWSButton.swift Improve "dim when highlighted" logic for OWSButtons 2022-10-13 12:45:02 -05:00
OWSFlatButton.swift Change license to AGPL 2022-10-13 08:25:37 -05:00
OWSLayerView.swift Change license to AGPL 2022-10-13 08:25:37 -05:00
OWSNavigationBar.swift Change license to AGPL 2022-10-13 08:25:37 -05:00
OWSSearchBar.h Change license to AGPL 2022-10-13 08:25:37 -05:00
OWSSearchBar.m Change license to AGPL 2022-10-13 08:25:37 -05:00
OWSStackView.swift Change license to AGPL 2022-10-13 08:25:37 -05:00
OWSTextField.h Change license to AGPL 2022-10-13 08:25:37 -05:00
OWSTextField.m Change license to AGPL 2022-10-13 08:25:37 -05:00
OWSTextView.h Change license to AGPL 2022-10-13 08:25:37 -05:00
OWSTextView.m Change license to AGPL 2022-10-13 08:25:37 -05:00
PrimaryImageView.swift Change license to AGPL 2022-10-13 08:25:37 -05:00
ReminderView.swift Change license to AGPL 2022-10-13 08:25:37 -05:00
ResizingScrollView.swift Change license to AGPL 2022-10-13 08:25:37 -05:00
RoundMediaButton.swift Change license to AGPL 2022-10-13 08:25:37 -05:00
TappableStackView.swift Change license to AGPL 2022-10-13 08:25:37 -05:00
TappableView.swift Change license to AGPL 2022-10-13 08:25:37 -05:00
TextAttachmentView.swift Change license to AGPL 2022-10-13 08:25:37 -05:00
TextFieldWithPlaceholder.swift Change license to AGPL 2022-10-13 08:25:37 -05:00
TextViewWithPlaceholder.swift Change license to AGPL 2022-10-13 08:25:37 -05:00
ThemeHeaderView.swift Change license to AGPL 2022-10-13 08:25:37 -05:00
Toast.swift Change license to AGPL 2022-10-13 08:25:37 -05:00
VideoPlayerView.swift Change license to AGPL 2022-10-13 08:25:37 -05:00