Change license to AGPL
This commit:
- Updates the `LICENSE` file
- Start every file with something like:
// Copyright YEAR_FIRST_PUBLISHED Signal Messenger, LLC
// SPDX-License-Identifier: AGPL-3.0-only
---
First, I removed existing license headers with this Ruby 3.1.2 script:
require 'set'
EXTENSIONS_TO_CHECK = Set['.h', '.hpp', '.cpp', '.m', '.mm', '.pch', '.swift']
same = 0
different = 0
all_files = `git ls-files`.lines.map { |line| line.strip }
all_files.each do |relative_path|
if relative_path == 'Pods'
next
end
unless EXTENSIONS_TO_CHECK.include? File.extname(relative_path)
next
end
path = File.expand_path(relative_path)
contents = File.read(path)
new_contents = contents.sub(/\/\/\n\/\/ Copyright .*\n\/\/\n\n/, '')
if contents == new_contents
same += 1
else
different += 1
end
File.write(path, new_contents)
end
puts "updated #{different} file(s), left #{same} untouched"
I'm sure this script could be improved, but it worked well enough.
Then, I created `Scripts/lint/lint-license-headers` and ran it to auto-
fix a lot of files. This changed the mode of some files, but I think
that's actually desirable. For example,
`SignalServiceKit/src/Util/AppContext.m` previously had a mode of
`0755/-rwxr-xr-x`, and it's now `0644/-rw-r--r--`.
Then I fixed some stragglers and updated the precommit script.
See [a similar change in the Desktop app][0].
[0]: 8bfaf598af
241 lines
8.4 KiB
Swift
241 lines
8.4 KiB
Swift
//
|
|
// Copyright 2018 Signal Messenger, LLC
|
|
// SPDX-License-Identifier: AGPL-3.0-only
|
|
//
|
|
|
|
import XCTest
|
|
@testable import SignalServiceKit
|
|
|
|
class MessageSenderJobQueueTest: SSKBaseTestSwift {
|
|
private var fakeMessageSender: FakeMessageSender {
|
|
MockSSKEnvironment.shared.messageSender as! FakeMessageSender
|
|
}
|
|
|
|
// MARK:
|
|
|
|
func test_messageIsSent() {
|
|
let message: TSOutgoingMessage = OutgoingMessageFactory().create()
|
|
|
|
let expectation = sentExpectation(message: message)
|
|
|
|
let jobQueue = MessageSenderJobQueue()
|
|
self.write { transaction in
|
|
jobQueue.add(message: message.asPreparer, transaction: transaction)
|
|
}
|
|
jobQueue.setup()
|
|
// Make sure the default global queue has a chance to process.
|
|
// Note that for this to work, this code must be using the same QoS as MessageSenderJobQueue.
|
|
DispatchQueue.global().sync(flags: .barrier) {}
|
|
self.wait(for: [expectation], timeout: 0.1)
|
|
}
|
|
|
|
func test_waitsForSetup() {
|
|
let message: TSOutgoingMessage = OutgoingMessageFactory().create()
|
|
|
|
let sentBeforeReadyExpectation = sentExpectation(message: message)
|
|
sentBeforeReadyExpectation.isInverted = true
|
|
|
|
let jobQueue = MessageSenderJobQueue()
|
|
|
|
self.write { transaction in
|
|
jobQueue.add(message: message.asPreparer, transaction: transaction)
|
|
}
|
|
|
|
self.wait(for: [sentBeforeReadyExpectation], timeout: 0.1)
|
|
|
|
let sentAfterReadyExpectation = sentExpectation(message: message)
|
|
|
|
jobQueue.setup()
|
|
|
|
self.wait(for: [sentAfterReadyExpectation], timeout: 0.1)
|
|
}
|
|
|
|
func test_respectsQueueOrder() {
|
|
let message1: TSOutgoingMessage = OutgoingMessageFactory().create()
|
|
let message2: TSOutgoingMessage = OutgoingMessageFactory().create()
|
|
let message3: TSOutgoingMessage = OutgoingMessageFactory().create()
|
|
|
|
let jobQueue = MessageSenderJobQueue()
|
|
self.write { transaction in
|
|
jobQueue.add(message: message1.asPreparer, transaction: transaction)
|
|
jobQueue.add(message: message2.asPreparer, transaction: transaction)
|
|
jobQueue.add(message: message3.asPreparer, transaction: transaction)
|
|
}
|
|
|
|
let sendGroup = DispatchGroup()
|
|
sendGroup.enter()
|
|
sendGroup.enter()
|
|
sendGroup.enter()
|
|
|
|
var sentMessages: [TSOutgoingMessage] = []
|
|
fakeMessageSender.sendMessageWasCalledBlock = { sentMessage in
|
|
sentMessages.append(sentMessage)
|
|
sendGroup.leave()
|
|
}
|
|
|
|
jobQueue.setup()
|
|
|
|
let expectation = self.expectation(description: "sent messages")
|
|
// Block on self.wait(), use sendGroup.wait() off the main thread.
|
|
// self.wait() will process the main run loop.
|
|
DispatchQueue.global().async {
|
|
switch sendGroup.wait(timeout: .now() + 1.0) {
|
|
case .timedOut:
|
|
XCTFail("timed out waiting for sends")
|
|
case .success:
|
|
expectation.fulfill()
|
|
}
|
|
}
|
|
self.wait(for: [expectation], timeout: 1.0)
|
|
|
|
XCTAssertEqual([message1, message2, message3].map { $0.uniqueId }, sentMessages.map { $0.uniqueId })
|
|
}
|
|
|
|
func test_sendingInvisibleMessage() {
|
|
let jobQueue = MessageSenderJobQueue()
|
|
jobQueue.setup()
|
|
|
|
let message = OutgoingMessageFactory().buildDeliveryReceipt()
|
|
let expectation = sentExpectation(message: message)
|
|
self.write { transaction in
|
|
jobQueue.add(message: message.asPreparer, transaction: transaction)
|
|
}
|
|
|
|
self.wait(for: [expectation], timeout: 0.1)
|
|
}
|
|
|
|
func test_retryableFailure() {
|
|
let message: TSOutgoingMessage = OutgoingMessageFactory().create()
|
|
|
|
let jobQueue = MessageSenderJobQueue()
|
|
self.write { transaction in
|
|
jobQueue.add(message: message.asPreparer, transaction: transaction)
|
|
}
|
|
|
|
let finder = AnyJobRecordFinder()
|
|
var readyRecords: [SSKJobRecord] = []
|
|
self.read { transaction in
|
|
readyRecords = finder.allRecords(label: MessageSenderJobQueue.jobRecordLabel, status: .ready, transaction: transaction)
|
|
}
|
|
XCTAssertEqual(1, readyRecords.count)
|
|
|
|
let jobRecord = readyRecords.first!
|
|
XCTAssertEqual(0, jobRecord.failureCount)
|
|
|
|
// simulate permanent failure
|
|
let error = OWSRetryableError()
|
|
fakeMessageSender.stubbedFailingError = error
|
|
let expectation = sentExpectation(message: message) {
|
|
jobQueue.isSetup.set(false)
|
|
}
|
|
|
|
jobQueue.setup()
|
|
self.wait(for: [expectation], timeout: 0.1)
|
|
|
|
self.read { transaction in
|
|
jobRecord.anyReload(transaction: transaction)
|
|
}
|
|
|
|
XCTAssertEqual(1, jobRecord.failureCount)
|
|
XCTAssertEqual(.running, jobRecord.status)
|
|
|
|
let retryCount: UInt = MessageSenderJobQueue.maxRetries
|
|
(1..<retryCount).forEach { _ in
|
|
let expectedResend = sentExpectation(message: message)
|
|
// Manually kick queue restart.
|
|
//
|
|
// OWSOperation uses an NSTimer backed retry mechanism, but NSTimer's are not fired
|
|
// during `self.wait(for:,timeout:` unless the timer was scheduled on the
|
|
// `RunLoop.main`.
|
|
//
|
|
// We could move the timer to fire on the main RunLoop (and have the selector dispatch
|
|
// back to a background queue), but the production code is simpler if we just manually
|
|
// kick every retry in the test case.
|
|
XCTAssertNotNil(jobQueue.runAnyQueuedRetry())
|
|
self.wait(for: [expectedResend], timeout: 1)
|
|
}
|
|
|
|
// Verify one retry left
|
|
self.read { transaction in
|
|
jobRecord.anyReload(transaction: transaction)
|
|
}
|
|
XCTAssertEqual(retryCount, jobRecord.failureCount)
|
|
XCTAssertEqual(.running, jobRecord.status)
|
|
|
|
// Verify final send fails permanently
|
|
let expectedFinalResend = sentExpectation(message: message)
|
|
XCTAssertNotNil(jobQueue.runAnyQueuedRetry())
|
|
self.wait(for: [expectedFinalResend], timeout: 0.1)
|
|
|
|
self.read { transaction in
|
|
jobRecord.anyReload(transaction: transaction)
|
|
}
|
|
|
|
XCTAssertEqual(retryCount + 1, jobRecord.failureCount)
|
|
XCTAssertEqual(.permanentlyFailed, jobRecord.status)
|
|
|
|
// No remaining retries
|
|
XCTAssertNil(jobQueue.runAnyQueuedRetry())
|
|
}
|
|
|
|
func test_permanentFailure() {
|
|
let message: TSOutgoingMessage = OutgoingMessageFactory().create()
|
|
|
|
let jobQueue = MessageSenderJobQueue()
|
|
self.write { transaction in
|
|
jobQueue.add(message: message.asPreparer, transaction: transaction)
|
|
}
|
|
|
|
let finder = AnyJobRecordFinder()
|
|
var readyRecords: [SSKJobRecord] = []
|
|
self.read { transaction in
|
|
readyRecords = finder.allRecords(label: MessageSenderJobQueue.jobRecordLabel, status: .ready, transaction: transaction)
|
|
}
|
|
XCTAssertEqual(1, readyRecords.count)
|
|
|
|
let jobRecord = readyRecords.first!
|
|
XCTAssertEqual(0, jobRecord.failureCount)
|
|
|
|
// simulate permanent failure
|
|
let error = OWSUnretryableError()
|
|
fakeMessageSender.stubbedFailingError = error
|
|
let expectation = sentExpectation(message: message) {
|
|
jobQueue.isSetup.set(false)
|
|
}
|
|
jobQueue.setup()
|
|
self.wait(for: [expectation], timeout: 1)
|
|
|
|
self.read { transaction in
|
|
jobRecord.anyReload(transaction: transaction)
|
|
}
|
|
|
|
XCTAssertEqual(1, jobRecord.failureCount)
|
|
XCTAssertEqual(.permanentlyFailed, jobRecord.status)
|
|
}
|
|
|
|
// MARK: Private
|
|
|
|
private func sentExpectation(message: TSOutgoingMessage, block: @escaping () -> Void = { }) -> XCTestExpectation {
|
|
let expectation = self.expectation(description: "sent message")
|
|
|
|
fakeMessageSender.sendMessageWasCalledBlock = { [weak fakeMessageSender] sentMessage in
|
|
guard let fakeMessageSender = fakeMessageSender else {
|
|
owsFailDebug("Lost track of the message sender!")
|
|
return
|
|
}
|
|
|
|
guard sentMessage.uniqueId == message.uniqueId else {
|
|
XCTFail("unexpected sentMessage: \(sentMessage)")
|
|
return
|
|
}
|
|
|
|
fakeMessageSender.sendMessageWasCalledBlock = nil
|
|
|
|
expectation.fulfill()
|
|
block()
|
|
}
|
|
|
|
return expectation
|
|
}
|
|
}
|