242dfd2bce
Currently, only some `JobQueue` types are initialized during startup (as part of `Environment`, or `SSKEnvironment`). Initialization is required, however, for a `JobQueue` type to restart any latent jobs. That means that, for example, a durable `SendGiftBadge` job that failed, and should be reattempted at a later date, will not in fact be restarted since no `SendGiftBadgeJobQueue` will be initialized at launch. This change adds `SSKJobQueues` and `SignalMessagingJobQueues` types, which are intended to be singletons that hold within them a singleton job queue for each of our `JobQueue` types. These wrappers are added to `SSKEnvironment` and `Environment` (from SignalMessaging) respectively, ensuring that all the `JobQueue`s they contain are initialized as part of environment setup. The wrappers also avoid the need to add a new property to the (already large) environment types for each new future `JobQueue`. This change also updates all existing call sites that accessed a `JobQueue` from an environment object, to direct that access now through the wrapper type.
500 lines
19 KiB
Swift
500 lines
19 KiB
Swift
//
|
|
// Copyright 2018 Signal Messenger, LLC
|
|
// SPDX-License-Identifier: AGPL-3.0-only
|
|
//
|
|
|
|
import Foundation
|
|
|
|
/// JobQueue - A durable work queue
|
|
///
|
|
/// When work needs to be done, add it to the JobQueue.
|
|
/// The JobQueue will persist a JobRecord to be sure that work can be restarted if the app is killed.
|
|
///
|
|
/// The actual work, is carried out in a DurableOperation which the JobQueue spins off, based on the contents
|
|
/// of a JobRecord.
|
|
///
|
|
/// For a concrete example, take message sending.
|
|
/// Add an outgoing message to the MessageSenderJobQueue, which first records a SSKMessageSenderJobRecord.
|
|
/// The MessageSenderJobQueue then uses that SSKMessageSenderJobRecord to create a MessageSenderOperation which
|
|
/// takes care of the actual business of communicating with the service.
|
|
///
|
|
/// DurableOperations are retryable - via their `remainingRetries` logic. However, if the operation encounters
|
|
/// an error where `error.isRetryable == false`, the operation will fail, regardless of available retries.
|
|
|
|
extension SSKJobRecordStatus: CustomStringConvertible {
|
|
public var description: String {
|
|
switch self {
|
|
case .ready:
|
|
return "ready"
|
|
case .unknown:
|
|
return "unknown"
|
|
case .running:
|
|
return "running"
|
|
case .permanentlyFailed:
|
|
return "permanentlyFailed"
|
|
case .obsolete:
|
|
return "obsolete"
|
|
}
|
|
}
|
|
}
|
|
|
|
public enum JobError: Error {
|
|
case assertionFailure(description: String)
|
|
case obsolete(description: String)
|
|
}
|
|
|
|
public protocol DurableOperation: AnyObject, Equatable {
|
|
associatedtype JobRecordType: SSKJobRecord
|
|
associatedtype DurableOperationDelegateType: DurableOperationDelegate
|
|
|
|
var jobRecord: JobRecordType { get }
|
|
var durableOperationDelegate: DurableOperationDelegateType? { get set }
|
|
var operation: OWSOperation { get }
|
|
var remainingRetries: UInt { get set }
|
|
}
|
|
|
|
public protocol DurableOperationDelegate: AnyObject {
|
|
associatedtype DurableOperationType: DurableOperation
|
|
|
|
func durableOperationDidSucceed(_ operation: DurableOperationType, transaction: SDSAnyWriteTransaction)
|
|
func durableOperation(_ operation: DurableOperationType, didReportError: Error, transaction: SDSAnyWriteTransaction)
|
|
func durableOperation(_ operation: DurableOperationType, didFailWithError error: Error, transaction: SDSAnyWriteTransaction)
|
|
}
|
|
|
|
public protocol JobQueue: DurableOperationDelegate, Dependencies {
|
|
typealias DurableOperationDelegateType = Self
|
|
typealias JobRecordType = DurableOperationType.JobRecordType
|
|
|
|
var runningOperations: AtomicArray<DurableOperationType> { get set }
|
|
var jobRecordLabel: String { get }
|
|
|
|
var isSetup: AtomicBool { get set }
|
|
func setup()
|
|
func didMarkAsReady(oldJobRecord: JobRecordType, transaction: SDSAnyWriteTransaction)
|
|
func didFlushQueue(transaction: SDSAnyWriteTransaction)
|
|
|
|
func operationQueue(jobRecord: JobRecordType) -> OperationQueue
|
|
func buildOperation(jobRecord: JobRecordType, transaction: SDSAnyReadTransaction) throws -> DurableOperationType
|
|
|
|
/// When `requiresInternet` is true, we immediately run any jobs which are waiting for retry upon detecting Reachability.
|
|
///
|
|
/// Because `Reachability` isn't 100% reliable, the jobs will be attempted regardless of what we think our current Reachability is.
|
|
/// However, because these jobs will likely fail many times in succession, their `retryInterval` could be quite long by the time we
|
|
/// are back online.
|
|
var requiresInternet: Bool { get }
|
|
static var maxRetries: UInt { get }
|
|
|
|
var isEnabled: Bool { get }
|
|
}
|
|
|
|
// MARK: -
|
|
|
|
public extension JobQueue {
|
|
|
|
// MARK: - Dependencies
|
|
|
|
var finder: AnyJobRecordFinder<JobRecordType> {
|
|
return AnyJobRecordFinder<JobRecordType>()
|
|
}
|
|
|
|
// MARK: Default Implementations
|
|
|
|
func add(jobRecord: JobRecordType, transaction: SDSAnyWriteTransaction) {
|
|
owsAssertDebug(jobRecord.status == .ready)
|
|
|
|
jobRecord.anyInsert(transaction: transaction)
|
|
|
|
transaction.addTransactionFinalizationBlock(
|
|
forKey: "jobQueue.\(jobRecordLabel).startWorkImmediatelyIfAppIsReady"
|
|
) { transaction in
|
|
self.startWorkImmediatelyIfAppIsReady(transaction: transaction)
|
|
}
|
|
|
|
transaction.addAsyncCompletion(queue: .global()) {
|
|
self.startWorkWhenAppIsReady()
|
|
}
|
|
}
|
|
|
|
func hasPendingJobs(transaction: SDSAnyReadTransaction) -> Bool {
|
|
return nil != finder.getNextReady(label: self.jobRecordLabel, transaction: transaction)
|
|
}
|
|
|
|
func startWorkImmediatelyIfAppIsReady(transaction: SDSAnyWriteTransaction) {
|
|
guard isEnabled else { return }
|
|
guard !CurrentAppContext().isRunningTests else { return }
|
|
guard AppReadiness.isAppReady else { return }
|
|
guard !DebugFlags.suppressBackgroundActivity else { return }
|
|
guard isSetup.get() else { return }
|
|
workStep(transaction: transaction)
|
|
}
|
|
|
|
func startWorkWhenAppIsReady() {
|
|
guard isEnabled else { return }
|
|
|
|
guard !CurrentAppContext().isRunningTests else {
|
|
DispatchQueue.global().async {
|
|
self.workStep()
|
|
}
|
|
return
|
|
}
|
|
|
|
AppReadiness.runNowOrWhenAppDidBecomeReadyAsync {
|
|
guard self.isSetup.get() else {
|
|
return
|
|
}
|
|
DispatchQueue.global().async {
|
|
self.workStep()
|
|
}
|
|
}
|
|
}
|
|
|
|
func workStep() {
|
|
Logger.debug("")
|
|
|
|
guard isEnabled else { return }
|
|
|
|
guard !DebugFlags.suppressBackgroundActivity else {
|
|
// Don't process queues.
|
|
return
|
|
}
|
|
|
|
guard isSetup.get() else {
|
|
if !CurrentAppContext().isRunningTests {
|
|
owsFailDebug("not setup")
|
|
}
|
|
|
|
return
|
|
}
|
|
|
|
databaseStorage.write { self.workStep(transaction: $0) }
|
|
}
|
|
|
|
func workStep(transaction: SDSAnyWriteTransaction) {
|
|
guard let nextJob: JobRecordType = self.finder.getNextReady(label: jobRecordLabel, transaction: transaction) else {
|
|
Logger.verbose("nothing left to enqueue")
|
|
didFlushQueue(transaction: transaction)
|
|
return
|
|
}
|
|
|
|
do {
|
|
try nextJob.saveAsStarted(transaction: transaction)
|
|
|
|
let operationQueue = operationQueue(jobRecord: nextJob)
|
|
let durableOperation = try buildOperation(jobRecord: nextJob, transaction: transaction)
|
|
|
|
durableOperation.durableOperationDelegate = self as? Self.DurableOperationType.DurableOperationDelegateType
|
|
owsAssertDebug(durableOperation.durableOperationDelegate != nil)
|
|
|
|
let remainingRetries = remainingRetries(durableOperation: durableOperation)
|
|
durableOperation.remainingRetries = remainingRetries
|
|
|
|
transaction.addSyncCompletion {
|
|
self.runningOperations.append(durableOperation)
|
|
|
|
Logger.debug("adding operation: \(durableOperation) with remainingRetries: \(remainingRetries)")
|
|
operationQueue.addOperation(durableOperation.operation)
|
|
}
|
|
} catch JobError.assertionFailure(let description) {
|
|
owsFailDebug("assertion failure: \(description)")
|
|
nextJob.saveAsPermanentlyFailed(transaction: transaction)
|
|
} catch JobError.obsolete(let description) {
|
|
// TODO is this even worthwhile to have obsolete state? Should we just delete the task outright?
|
|
Logger.verbose("marking obsolete task as such. description:\(description)")
|
|
nextJob.saveAsObsolete(transaction: transaction)
|
|
} catch {
|
|
owsFailDebug("unexpected error")
|
|
}
|
|
|
|
transaction.addAsyncCompletionOffMain { self.workStep() }
|
|
}
|
|
|
|
func restartOldJobs() {
|
|
guard CurrentAppContext().isMainApp else { return }
|
|
guard isEnabled else { return }
|
|
|
|
guard !DebugFlags.suppressBackgroundActivity else {
|
|
// Don't process queues.
|
|
return
|
|
}
|
|
databaseStorage.write { transaction in
|
|
let runningRecords = self.finder.allRecords(label: self.jobRecordLabel, status: .running, transaction: transaction)
|
|
Logger.info("marking old `running` \(self.jobRecordLabel) JobRecords as ready: \(runningRecords.count)")
|
|
for jobRecord in runningRecords {
|
|
do {
|
|
try jobRecord.saveRunningAsReady(transaction: transaction)
|
|
self.didMarkAsReady(oldJobRecord: jobRecord, transaction: transaction)
|
|
} catch {
|
|
owsFailDebug("failed to mark old running records as ready error: \(error)")
|
|
jobRecord.saveAsPermanentlyFailed(transaction: transaction)
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
func pruneStaleJobs() {
|
|
guard CurrentAppContext().isMainApp else { return }
|
|
guard isEnabled else { return }
|
|
|
|
guard !DebugFlags.suppressBackgroundActivity else {
|
|
// Don't process queues.
|
|
return
|
|
}
|
|
databaseStorage.write { transaction in
|
|
let staleRecords = self.finder.staleReadyRecords(label: self.jobRecordLabel, transaction: transaction)
|
|
Logger.info("Pruning stale \(self.jobRecordLabel) JobRecords exclusively for previous process: \(staleRecords.count)")
|
|
for jobRecord in staleRecords {
|
|
jobRecord.anyRemove(transaction: transaction)
|
|
}
|
|
}
|
|
}
|
|
|
|
/// Unless you need special handling, your setup method can be as simple as
|
|
///
|
|
/// func setup() {
|
|
/// defaultSetup()
|
|
/// }
|
|
///
|
|
/// So you might ask, why not just rename this method to `setup`? Because
|
|
/// `setup` is called from objc, and default implementations from a protocol
|
|
/// cannot be marked as @objc.
|
|
func defaultSetup() {
|
|
guard isEnabled else { return }
|
|
|
|
guard !isSetup.get() else {
|
|
owsFailDebug("already ready already")
|
|
return
|
|
}
|
|
|
|
DispatchQueue.global().async(.promise) {
|
|
self.restartOldJobs()
|
|
self.pruneStaleJobs()
|
|
}.done { [weak self] in
|
|
guard let self = self else {
|
|
return
|
|
}
|
|
if self.requiresInternet {
|
|
// FIXME: The returned observer token is never unregistered.
|
|
// In practice all our JobQueues live forever, so this isn't a problem.
|
|
NotificationCenter.default.addObserver(forName: SSKReachability.owsReachabilityDidChange,
|
|
object: nil,
|
|
queue: nil) { _ in
|
|
|
|
if self.reachabilityManager.isReachable {
|
|
Logger.verbose("isReachable: true")
|
|
self.becameReachable()
|
|
} else {
|
|
Logger.verbose("isReachable: false")
|
|
}
|
|
}
|
|
}
|
|
|
|
self.isSetup.set(true)
|
|
self.startWorkWhenAppIsReady()
|
|
}
|
|
}
|
|
|
|
func remainingRetries(durableOperation: DurableOperationType) -> UInt {
|
|
let maxRetries = type(of: self).maxRetries
|
|
let failureCount = durableOperation.jobRecord.failureCount
|
|
|
|
guard maxRetries > failureCount else {
|
|
return 0
|
|
}
|
|
|
|
return maxRetries - failureCount
|
|
}
|
|
|
|
func becameReachable() {
|
|
guard requiresInternet else {
|
|
owsFailDebug("should only be called if `requiresInternet` is true")
|
|
return
|
|
}
|
|
|
|
_ = self.runAnyQueuedRetry()
|
|
}
|
|
|
|
func runAnyQueuedRetry() -> DurableOperationType? {
|
|
guard let runningDurableOperation = self.runningOperations.first else {
|
|
return nil
|
|
}
|
|
runningDurableOperation.operation.runAnyQueuedRetry()
|
|
|
|
return runningDurableOperation
|
|
}
|
|
|
|
// MARK: DurableOperationDelegate
|
|
|
|
func durableOperationDidSucceed(_ operation: DurableOperationType, transaction: SDSAnyWriteTransaction) {
|
|
runningOperations.remove(operation)
|
|
operation.jobRecord.anyRemove(transaction: transaction)
|
|
|
|
notifyFlushQueueIfPossible(transaction: transaction)
|
|
}
|
|
|
|
func durableOperation(_ operation: DurableOperationType, didReportError: Error, transaction: SDSAnyWriteTransaction) {
|
|
do {
|
|
try operation.jobRecord.addFailure(transaction: transaction)
|
|
} catch {
|
|
owsFailDebug("error while addingFailure: \(error)")
|
|
operation.jobRecord.saveAsPermanentlyFailed(transaction: transaction)
|
|
}
|
|
}
|
|
|
|
func durableOperation(_ operation: DurableOperationType, didFailWithError error: Error, transaction: SDSAnyWriteTransaction) {
|
|
runningOperations.remove(operation)
|
|
operation.jobRecord.saveAsPermanentlyFailed(transaction: transaction)
|
|
|
|
notifyFlushQueueIfPossible(transaction: transaction)
|
|
}
|
|
|
|
func notifyFlushQueueIfPossible(transaction: SDSAnyWriteTransaction) {
|
|
guard nil == finder.getNextReady(label: jobRecordLabel, transaction: transaction) else {
|
|
return
|
|
}
|
|
self.didFlushQueue(transaction: transaction)
|
|
}
|
|
|
|
func didFlushQueue(transaction: SDSAnyWriteTransaction) {
|
|
// Do nothing.
|
|
}
|
|
}
|
|
|
|
public protocol JobRecordFinder {
|
|
associatedtype ReadTransaction
|
|
associatedtype JobRecordType: SSKJobRecord
|
|
|
|
func getNextReady(label: String, transaction: ReadTransaction) -> JobRecordType?
|
|
func allRecords(label: String, status: SSKJobRecordStatus, transaction: ReadTransaction) -> [JobRecordType]
|
|
func staleReadyRecords(label: String, transaction: ReadTransaction) -> [JobRecordType]
|
|
func enumerateJobRecords(label: String, transaction: ReadTransaction, block: @escaping (JobRecordType, UnsafeMutablePointer<ObjCBool>) -> Void)
|
|
func enumerateJobRecords(label: String, status: SSKJobRecordStatus, transaction: ReadTransaction, block: @escaping (JobRecordType, UnsafeMutablePointer<ObjCBool>) -> Void)
|
|
}
|
|
|
|
extension JobRecordFinder {
|
|
public func getNextReady(label: String, transaction: ReadTransaction) -> JobRecordType? {
|
|
var result: JobRecordType?
|
|
self.enumerateJobRecords(label: label, status: .ready, transaction: transaction) { jobRecord, stopPointer in
|
|
if let exclusiveProcessIdentifier = jobRecord.exclusiveProcessIdentifier,
|
|
exclusiveProcessIdentifier != SSKJobRecord.currentProcessIdentifier {
|
|
// Skip job records that aren't for the current process, we can't run these.
|
|
return
|
|
}
|
|
result = jobRecord
|
|
stopPointer.pointee = true
|
|
}
|
|
return result
|
|
}
|
|
|
|
public func allRecords(label: String, status: SSKJobRecordStatus, transaction: ReadTransaction) -> [JobRecordType] {
|
|
var result: [JobRecordType] = []
|
|
self.enumerateJobRecords(label: label, status: status, transaction: transaction) { jobRecord, _ in
|
|
result.append(jobRecord)
|
|
}
|
|
return result
|
|
}
|
|
|
|
public func staleReadyRecords(label: String, transaction: ReadTransaction) -> [JobRecordType] {
|
|
var result: [JobRecordType] = []
|
|
self.enumerateJobRecords(label: label, status: .ready, transaction: transaction) { jobRecord, _ in
|
|
guard let exclusiveProcessIdentifier = jobRecord.exclusiveProcessIdentifier,
|
|
exclusiveProcessIdentifier != SSKJobRecord.currentProcessIdentifier else { return }
|
|
result.append(jobRecord)
|
|
}
|
|
return result
|
|
}
|
|
}
|
|
|
|
@objc
|
|
public class JobRecordFinderObjC: NSObject {
|
|
private let jobRecordFinder = AnyJobRecordFinder<SSKJobRecord>()
|
|
|
|
@objc
|
|
public func enumerateJobRecords(label: String, transaction: SDSAnyReadTransaction, block: @escaping (SSKJobRecord, UnsafeMutablePointer<ObjCBool>) -> Void) {
|
|
jobRecordFinder.enumerateJobRecords(label: label, transaction: transaction, block: block)
|
|
}
|
|
|
|
@objc
|
|
public func enumerateJobRecords(label: String, status: SSKJobRecordStatus, transaction: SDSAnyReadTransaction, block: @escaping (SSKJobRecord, UnsafeMutablePointer<ObjCBool>) -> Void) {
|
|
jobRecordFinder.enumerateJobRecords(label: label, status: status, transaction: transaction, block: block)
|
|
}
|
|
}
|
|
|
|
public class AnyJobRecordFinder<JobRecordType> where JobRecordType: SSKJobRecord {
|
|
lazy var grdbAdapter = GRDBJobRecordFinder<JobRecordType>()
|
|
|
|
public init() {}
|
|
}
|
|
|
|
extension AnyJobRecordFinder: JobRecordFinder {
|
|
public func enumerateJobRecords(label: String, transaction: SDSAnyReadTransaction, block: @escaping (JobRecordType, UnsafeMutablePointer<ObjCBool>) -> Void) {
|
|
switch transaction.readTransaction {
|
|
case .grdbRead(let grdbRead):
|
|
grdbAdapter.enumerateJobRecords(label: label, transaction: grdbRead, block: block)
|
|
}
|
|
}
|
|
|
|
public func enumerateJobRecords(label: String, status: SSKJobRecordStatus, transaction: SDSAnyReadTransaction, block: @escaping (JobRecordType, UnsafeMutablePointer<ObjCBool>) -> Void) {
|
|
switch transaction.readTransaction {
|
|
case .grdbRead(let grdbRead):
|
|
grdbAdapter.enumerateJobRecords(label: label, status: status, transaction: grdbRead, block: block)
|
|
}
|
|
}
|
|
}
|
|
|
|
class GRDBJobRecordFinder<JobRecordType> where JobRecordType: SSKJobRecord {
|
|
|
|
}
|
|
|
|
extension GRDBJobRecordFinder: JobRecordFinder {
|
|
private func iterateJobsWith(cursor: SSKJobRecordCursor, block: @escaping (JobRecordType, UnsafeMutablePointer<ObjCBool>) -> Void) {
|
|
var stop: ObjCBool = false
|
|
while true {
|
|
do {
|
|
if let next = try cursor.next() {
|
|
guard let jobRecord = next as? JobRecordType else {
|
|
owsFailDebug("expecting jobRecord but found: \(next)")
|
|
return
|
|
}
|
|
block(jobRecord, &stop)
|
|
if stop.boolValue {
|
|
return
|
|
}
|
|
} else {
|
|
return
|
|
}
|
|
} catch let error {
|
|
owsFailDebug("error fetching jobRecord: \(error)")
|
|
}
|
|
}
|
|
}
|
|
|
|
func enumerateJobRecords(label: String, transaction: GRDBReadTransaction, block: @escaping (JobRecordType, UnsafeMutablePointer<ObjCBool>) -> Void) {
|
|
|
|
let sql = """
|
|
SELECT * FROM \(JobRecordRecord.databaseTableName)
|
|
WHERE \(jobRecordColumn: .label) = ?
|
|
ORDER BY \(jobRecordColumn: .id)
|
|
"""
|
|
|
|
let cursor = JobRecordType.grdbFetchCursor(sql: sql,
|
|
arguments: [label],
|
|
transaction: transaction)
|
|
iterateJobsWith(cursor: cursor, block: block)
|
|
}
|
|
|
|
func enumerateJobRecords(label: String, status: SSKJobRecordStatus, transaction: GRDBReadTransaction, block: @escaping (JobRecordType, UnsafeMutablePointer<ObjCBool>) -> Void) {
|
|
|
|
let sql = """
|
|
SELECT * FROM \(JobRecordRecord.databaseTableName)
|
|
WHERE \(jobRecordColumn: .status) = ?
|
|
AND \(jobRecordColumn: .label) = ?
|
|
ORDER BY \(jobRecordColumn: .id)
|
|
"""
|
|
|
|
let cursor = JobRecordType.grdbFetchCursor(sql: sql,
|
|
arguments: [status.rawValue, label],
|
|
transaction: transaction)
|
|
iterateJobsWith(cursor: cursor, block: block)
|
|
}
|
|
}
|