22c1cb8a22
This is the first meaty part of optimizing fetching display names. Some contacts fall back to phone numbers as their display names. This PR fetches them in a single SQL query via `OWSContactsManager.phoneNumbers(for:, transaction)`. To achieve this, this PR introduces `GRDBSignalAccountFinder.signalAccounts(for:,transaction:)` to fetch many accounts at once. In order to fetch many accounts at once, we need to be able to fetch many values from a ModelReadCache at once. So this PR introduces `ModelReadCache.readValues(for:,transaction:)` and `ModelReadCache.getValues(for:,transaction:,returnNilOnCacheMiss:)`. Existing methods that operate on a single value were refactored to use the batch methods. This PR adds tests for this functionality, which necessitated changing the visibility of various private symbols and also improving the fake profile manager to make it more configurable. There's also a tiny optimization for Refinery to avoid calling a closure that has no work to do. This helps elide do-nothing SQL queries that would otherwise have been introduced. |
||
|---|---|---|
| .github | ||
| fastlane | ||
| Instruments | ||
| Pods@2e96325502 | ||
| Scripts | ||
| Signal | ||
| Signal.xcodeproj | ||
| Signal.xcworkspace | ||
| SignalMessaging | ||
| SignalNSE | ||
| SignalServiceKit | ||
| SignalShareExtension | ||
| SignalUI | ||
| SignalUITests | ||
| ThirdParty | ||
| .clang-format | ||
| .gitattributes | ||
| .gitignore | ||
| .gitmodules | ||
| .ruby-version | ||
| .swiftlint.yml | ||
| .xcode-version | ||
| BUILDING.md | ||
| CONTRIBUTING.md | ||
| Gemfile | ||
| Gemfile.lock | ||
| Jenkinsfile | ||
| LICENSE | ||
| MAINTAINING.md | ||
| Makefile | ||
| Podfile | ||
| Podfile.lock | ||
| README.md | ||
| SignalServiceKit.podspec | ||
Signal iOS
Signal is a free, open source, messaging app for simple private communication with friends.
Also available on Android and Desktop.
Questions?
For troubleshooting and questions, please visit our support center or unofficial community forum.
Contributing Bug Reports
We use GitHub for bug tracking. Please search existing issues and create a new one if the issue is not yet tracked. For Android users, please use the Signal for Android issue tracker.
Contributing Translations
Help us translate Signal! The translation effort happens on Transifex.
Contributing Code
Instructions on how to setup your development environment and build Signal-iOS can be found in BUILDING.md. Other useful instructions for development can be found in the Development Guide wiki page. We also recommend reading the contribution guidelines.
Contributing Ideas
Have something you want to say about Signal Foundation projects or want to be part of the conversation? Get involved in the community forum.
Cryptography Notice
This distribution includes cryptographic software. The country in which you currently reside may have restrictions on the import, possession, use, and/or re-export to another country, of encryption software. BEFORE using any encryption software, please check your country's laws, regulations and policies concerning the import, possession, or use, and re-export of encryption software, to see if this is permitted. See http://www.wassenaar.org/ for more information.
The U.S. Government Department of Commerce, Bureau of Industry and Security (BIS), has classified this software as Export Commodity Control Number (ECCN) 5D002.C.1, which includes information security software using or performing cryptographic functions with asymmetric algorithms. The form and manner of this distribution makes it eligible for export under the License Exception ENC Technology Software Unrestricted (TSU) exception (see the BIS Export Administration Regulations, Section 740.13) for both object code and source code.
License
Licensed under GPLv3
Copyright 2014-2022 Open Whisper Systems
Apple and the Apple logo are trademarks of Apple Inc., registered in the U.S. and other countries. App Store is a service mark of Apple Inc., registered in the U.S. and other countries.