Commit Graph

10 Commits

Author SHA1 Message Date
Matthew Chen
154805cf68 Fix broken tests. 2020-06-23 10:04:39 -03:00
Matthew Chen
3cedd3ccdf Overhaul database observation. 2020-06-18 09:28:49 -03:00
Matthew Chen
dd42dcca49 Remove YDB from views. 2020-04-07 13:51:02 -03:00
Matthew Chen
031eafe8fe Fix broken tests. 2019-10-04 16:31:50 -03:00
Michael Kirk
1a9c0fae1d GRDB: Fix disappearing messages vs. long text or media details
The generic observer delete was broken for GRDB, because we can't fetch the
uniqueId's of rowIds if the corresponding row was deleted. So instead, we
split the logic: Yap uses uniqueIds, GRDB uses row ids.
2019-09-16 07:53:00 -07:00
Michael Kirk
53b2fc1929 touches take effect even in a no-op deferred transaction.
UIDatabaseObserver orchestrates notifying views when a transaction commits.
We back UIDatabaseObserver with a DatabaseRegionObserver

DatabaseRegionObservers are not notified if the transaction contains no changes:

    https://github.com/groue/GRDB.swift/blob/af0ac15/GRDB/Core/DatabaseRegionObservation.swift#L119

However the more general TransactionObservers *are* notified even if the
transaction contains no changes. Nicely, GRDB does some work to ensure this is
true even in the event of a deferred transaction. See this comment on `databaseDidCommitEmptyDeferredTransaction`

da459386a0/GRDB/Core/TransactionObserver.swift (L444)
2019-09-04 21:47:57 -06:00
Matthew Chen
c2ae2037d4 Fix rebase breakage. 2019-08-26 13:18:49 -03:00
Matthew Chen
79b1d31f20 Don't load YDB unless necessary.
Don't load YDB unless necessary.

Don't load YDB unless necessary.

Don't load YDB unless necessary.
2019-08-26 13:18:30 -03:00
Matthew Chen
58eccfe357 Fix test breakage. 2019-08-13 17:03:09 -03:00
Matthew Chen
8ca337e2c3 Rework generic change observation. 2019-08-13 09:58:27 -03:00